From nobody Fri May 3 01:48:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1504626665763601.2477347667591; Tue, 5 Sep 2017 08:51:05 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6B8BC7538E; Tue, 5 Sep 2017 15:51:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 124D7666A0; Tue, 5 Sep 2017 15:51:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4CD8F3FACE; Tue, 5 Sep 2017 15:51:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v85FWAfR025043 for ; Tue, 5 Sep 2017 11:32:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id B74F16B68B; Tue, 5 Sep 2017 15:32:10 +0000 (UTC) Received: from inaba.usersys.redhat.com (ovpn-204-76.brq.redhat.com [10.40.204.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BC4F86AF5 for ; Tue, 5 Sep 2017 15:32:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B8BC7538E Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 5 Sep 2017 17:32:03 +0200 Message-Id: <20170905153203.25638-1-abologna@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] m4: Disable -Wdisabled-optimization X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 05 Sep 2017 15:51:04 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" After b4f7793ce269, qemuxml2xmltest has apparently become big enough to trigger a compilation error on aarch64: CC qemuxml2xmltest.o qemuxml2xmltest.c: In function 'mymain': qemuxml2xmltest.c:1216:1: error: const/copy propagation disabled: 4361 ba= sic blocks and 99285 registers [-Werror=3Ddisabled-optimization] } ^ qemuxml2xmltest.c:1216:1: error: PRE disabled: 4361 basic blocks and 9928= 5 registers [-Werror=3Ddisabled-optimization] qemuxml2xmltest.c:1216:1: error: const/copy propagation disabled: 4361 ba= sic blocks and 99285 registers [-Werror=3Ddisabled-optimization] qemuxml2xmltest.c:1216:1: error: const/copy propagation disabled: 4361 ba= sic blocks and 99285 registers [-Werror=3Ddisabled-optimization] However, as the GCC documentation states, this warning is not really caused by issues in our code, so it makes sense to disable it. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrange --- m4/virt-compile-warnings.m4 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index e8f135126..f18a08a8f 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -64,6 +64,11 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ # Several conditionals expand the same on both branches # depending on the particular platform/architecture dontwarn=3D"$dontwarn -Wduplicated-branches" + # > This warning does not generally indicate that there is anything wr= ong + # > with your code; it merely indicates that GCC's optimizers are unab= le + # > to handle the code effectively. + # Source: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html + dontwarn=3D"$dontwarn -Wdisabled-optimization" =20 # gcc 4.2 treats attribute(format) as an implicit attribute(nonnull), # which triggers spurious warnings for our usage --=20 2.13.5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list