[libvirt] [PATCH v2] news: Prepare for 3.7.0 release

Andrea Bolognani posted 1 patch 6 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170901150118.25005-1-abologna@redhat.com
docs/news.xml | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 76 insertions(+)
[libvirt] [PATCH v2] news: Prepare for 3.7.0 release
Posted by Andrea Bolognani 6 years, 7 months ago
Documents some changes that have slipped through the cracks
during the development cycle.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
Changes from [v1]:

  * rebase on top of master
  * remove the part about guests no longer disappearing if the
    QEMU binary is missing, since Peter already documented that

[v1] https://www.redhat.com/archives/libvir-list/2017-September/msg00030.html

 docs/news.xml | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index dd8967e25..141b1a42a 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -69,6 +69,18 @@
           you can configure reconnect timeout if the connection is closed.
         </description>
       </change>
+      <change>
+        <summary>
+          qemu: Implement editing guest configuration for managed save files
+        </summary>
+        <description>
+          New <code>managedsave-define</code>, <code>managedsave-edit</code>
+          and <code>managedsave-dumpxml</code> commands have been added to
+          <code>virsh</code> to allow editing the guest configuration for
+          managed save files just like it was already possible for unmanaged
+          save files.
+        </description>
+      </change>
     </section>
     <section title="Improvements">
       <change>
@@ -81,6 +93,43 @@
           indication for users (and devs).
         </description>
       </change>
+      <change>
+        <summary>
+          apparmor: Update for QEMU 2.10 compatibility
+        </summary>
+        <description>
+          Starting with version 2.10, QEMU locks disk images and NVRAM files
+          to prevent them from being corrupted; however, file locking needs to
+          be explicitly allowed through <code>virt-aa-helper</code> or AppArmor
+          will reject the requests and the guest will not be able to run.
+        </description>
+      </change>
+      <change>
+        <summary>
+          virsh: List Unix sockets in 'domdisplay' output
+        </summary>
+        <description>
+          VNC and SPICE graphics can use Unix sockets instead of TCP/IP sockets
+          as connection endpoints, but such a configuration was not handled
+          correctly by <code>virsh domdisplay</code>, causing the respective
+          endpoints to be missing from the output.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Don't check whether offline migration is safe
+        </summary>
+        <description>
+          Since offline migration only copies the guest definition to the
+          destination host, data corruption is not a concern and the operation
+          can always be performed safely.
+        </description>
+      </change>
+      <change>
+        <summary>
+          virt-host-validate: Fix IOMMU detection on ppc64
+        </summary>
+      </change>
     </section>
     <section title="Bug fixes">
       <change>
@@ -115,6 +164,33 @@
           are missing during startup.
         </description>
       </change>
+      <change>
+        <summary>
+          qemu: Prevent pSeries guests from disappearing in some situations
+        </summary>
+        <description>
+          pSeries guest would disappear if any of the host devices they were
+          configured to use was not available during libvirtd startup, which
+          could easily happen for SR-IOV Virtual Functions. This scenario is
+          now handled correctly.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Honor <code>&lt;on_reboot/&gt;</code> setting
+        </summary>
+        <description>
+          The setting was accepted by the parser, but not actually implemented.
+        </description>
+      </change>
+      <change>
+        <summary>
+          daemon: Fix <code>--verbose</code> option
+        </summary>
+        <description>
+          The option had not been working as intended from v3.0.0 onwards.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v3.6.0" date="2017-08-02">
-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] news: Prepare for 3.7.0 release
Posted by John Ferlan 6 years, 7 months ago

On 09/01/2017 11:01 AM, Andrea Bolognani wrote:
> Documents some changes that have slipped through the cracks
> during the development cycle.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
> Changes from [v1]:
> 
>   * rebase on top of master
>   * remove the part about guests no longer disappearing if the
>     QEMU binary is missing, since Peter already documented that
> 
> [v1] https://www.redhat.com/archives/libvir-list/2017-September/msg00030.html
> 
>  docs/news.xml | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)
> 

Hrmph... Guess we have to get better at remembering this when we do
reviews as the last few release cycles there's been a need to update
news.xml appropriately at the last moment...

> diff --git a/docs/news.xml b/docs/news.xml
> index dd8967e25..141b1a42a 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -69,6 +69,18 @@
>            you can configure reconnect timeout if the connection is closed.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          qemu: Implement editing guest configuration for managed save files
> +        </summary>
> +        <description>
> +          New <code>managedsave-define</code>, <code>managedsave-edit</code>
> +          and <code>managedsave-dumpxml</code> commands have been added to
> +          <code>virsh</code> to allow editing the guest configuration for
> +          managed save files just like it was already possible for unmanaged
> +          save files.
> +        </description>
> +      </change>

FWIW:

https://www.redhat.com/archives/libvir-list/2017-August/msg00953.html

No one ACK'd it yet...  The 1/2 of the v2 series was pushed from the v1
posting, but v2 looks lost in the volume ;-(

IDC how you decide to "handle" that - either apply Kothapally's change
or go with yours...

>      </section>
>      <section title="Improvements">
>        <change>
> @@ -81,6 +93,43 @@
>            indication for users (and devs).
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          apparmor: Update for QEMU 2.10 compatibility
> +        </summary>
> +        <description>
> +          Starting with version 2.10, QEMU locks disk images and NVRAM files

The way this reads it seems it could be libvirt 2.10...  I'd go with
"QEMU 2.10" (although some will point out it's possible to backport
things into earlier versions)...

> +          to prevent them from being corrupted; however, file locking needs to
> +          be explicitly allowed through <code>virt-aa-helper</code> or AppArmor
> +          will reject the requests and the guest will not be able to run.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          virsh: List Unix sockets in 'domdisplay' output
> +        </summary>
> +        <description>
> +          VNC and SPICE graphics can use Unix sockets instead of TCP/IP sockets
> +          as connection endpoints, but such a configuration was not handled
> +          correctly by <code>virsh domdisplay</code>, causing the respective
> +          endpoints to be missing from the output.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          qemu: Don't check whether offline migration is safe
> +        </summary>
> +        <description>
> +          Since offline migration only copies the guest definition to the
> +          destination host, data corruption is not a concern and the operation
> +          can always be performed safely.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          virt-host-validate: Fix IOMMU detection on ppc64
> +        </summary>
> +      </change>
>      </section>
>      <section title="Bug fixes">
>        <change>
> @@ -115,6 +164,33 @@
>            are missing during startup.
>          </description>
>        </change>
> +      <change>
> +        <summary>
> +          qemu: Prevent pSeries guests from disappearing in some situations
> +        </summary>
> +        <description>
> +          pSeries guest would disappear if any of the host devices they were
> +          configured to use was not available during libvirtd startup, which
> +          could easily happen for SR-IOV Virtual Functions. This scenario is
> +          now handled correctly.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          qemu: Honor <code>&lt;on_reboot/&gt;</code> setting
> +        </summary>
> +        <description>
> +          The setting was accepted by the parser, but not actually implemented.
> +        </description>
> +      </change>
> +      <change>
> +        <summary>
> +          daemon: Fix <code>--verbose</code> option

Should we state for all the daemon's fixed? Looks very strange naked
like this unless you know "daemon" means more than one place.

> +        </summary>
> +        <description>
> +          The option had not been working as intended from v3.0.0 onwards.

This option has not been working properly since v3.0.0.

> +        </description>
> +      </change>
>      </section>
>    </release>
>    <release version="v3.6.0" date="2017-08-02">
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>


John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] news: Prepare for 3.7.0 release
Posted by Andrea Bolognani 6 years, 7 months ago
On Fri, 2017-09-01 at 11:45 -0400, John Ferlan wrote:
> > Documents some changes that have slipped through the cracks
> > during the development cycle.
> > 
> > Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > ---
> > Changes from [v1]:
> > 
> >   * rebase on top of master
> >   * remove the part about guests no longer disappearing if the
> >     QEMU binary is missing, since Peter already documented that
> > 
> > [v1] https://www.redhat.com/archives/libvir-list/2017-September/msg00030.html
> > 
> >  docs/news.xml | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 76 insertions(+)
> 
> Hrmph... Guess we have to get better at remembering this when we do
> reviews as the last few release cycles there's been a need to update
> news.xml appropriately at the last moment...

Yeah, we haven't gotten as good at this as I hoped we would have
by now. Even I forgot to update the release notes once during
this development cycle! .-.

> > +      <change>
> > +        <summary>
> > +          qemu: Implement editing guest configuration for managed save files
> > +        </summary>
> > +        <description>
> > +          New <code>managedsave-define</code>, <code>managedsave-edit</code>
> > +          and <code>managedsave-dumpxml</code> commands have been added to
> > +          <code>virsh</code> to allow editing the guest configuration for
> > +          managed save files just like it was already possible for unmanaged
> > +          save files.
> > +        </description>
> > +      </change>
> 
> FWIW:
> 
> https://www.redhat.com/archives/libvir-list/2017-August/msg00953.html
> 
> No one ACK'd it yet...  The 1/2 of the v2 series was pushed from the v1
> posting, but v2 looks lost in the volume ;-(
> 
> IDC how you decide to "handle" that - either apply Kothapally's change
> or go with yours...

I've dropped this hunk and pushed the author's version.

> > +      <change>
> > +        <summary>
> > +          apparmor: Update for QEMU 2.10 compatibility
> > +        </summary>
> > +        <description>
> > +          Starting with version 2.10, QEMU locks disk images and NVRAM files
> 
> The way this reads it seems it could be libvirt 2.10...  I'd go with
> "QEMU 2.10" (although some will point out it's possible to backport
> things into earlier versions)...

I don't think there's much room for confusion, but there's also
no harm in being explicit :)

> > +      <change>
> > +        <summary>
> > +          daemon: Fix <code>--verbose</code> option
> 
> Should we state for all the daemon's fixed? Looks very strange naked
> like this unless you know "daemon" means more than one place.

Fair enough, I hadn't realized that myself :)

I changed the structure quite a bit, hopefully it's not a complete
trainwreck.

> Reviewed-by: John Ferlan <jferlan@redhat.com>

Pushed now, thanks for the review.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list