[v3] More virsecretobj changes to prepare for common object

[libvirt] [PATCH v3 0/3] More virsecretobj changes to prepare for common object

John Ferlan posted 3 patches 6 years, 9 months ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170725132155.5150-1-jferlan@redhat.com

src/conf/virsecretobj.c    | 14 ++++++--------
src/secret/secret_driver.c | 31 ++++++++++++++++++-------------
2 files changed, 24 insertions(+), 21 deletions(-)

Expand all Fold all

[libvirt] [PATCH v3 0/3] More virsecretobj changes to prepare for common object

Posted by John Ferlan 6 years, 9 months ago

v2: https://www.redhat.com/archives/libvir-list/2017-July/msg00520.html

Changes in v3:

Former patch 1, dropped
Former patch 2, pushed
Former patch 3, adjusted:
  -> Use @objDef instead of @objdef
  -> Handle the if (backup) leak shown during review
Former patch 4, split
  -> Patch 3 handles the virsecretobj call to virSecretObjListRemove
  -> Patch 4 handles the secret_driver calls to virSecretObjListRemove

John Ferlan (3):
  secret: Properly handle @def after virSecretObjAdd in driver
  secret: Fix memory leak in virSecretLoad
  secret: Handle object list removal and deletion properly

 src/conf/virsecretobj.c    | 14 ++++++--------
 src/secret/secret_driver.c | 31 ++++++++++++++++++-------------
 2 files changed, 24 insertions(+), 21 deletions(-)

-- 
2.9.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/3] More virsecretobj changes to prepare for common object

Posted by Pavel Hrdina 6 years, 9 months ago

On Tue, Jul 25, 2017 at 09:21:52AM -0400, John Ferlan wrote:
> v2: https://www.redhat.com/archives/libvir-list/2017-July/msg00520.html
> 
> Changes in v3:
> 
> Former patch 1, dropped
> Former patch 2, pushed
> Former patch 3, adjusted:
>   -> Use @objDef instead of @objdef
>   -> Handle the if (backup) leak shown during review
> Former patch 4, split
>   -> Patch 3 handles the virsecretobj call to virSecretObjListRemove
>   -> Patch 4 handles the secret_driver calls to virSecretObjListRemove
> 
> John Ferlan (3):
>   secret: Properly handle @def after virSecretObjAdd in driver
>   secret: Fix memory leak in virSecretLoad
>   secret: Handle object list removal and deletion properly

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list