storage: Fix editing mistake in storagePoolSetAutostart

[libvirt] [PATCH] storage: Fix editing mistake in storagePoolSetAutostart

John Ferlan posted 1 patch 6 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170724125202.31318-1-jferlan@redhat.com

src/storage/storage_driver.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[libvirt] [PATCH] storage: Fix editing mistake in storagePoolSetAutostart

Posted by John Ferlan 6 years, 9 months ago

Commit id '905f1024b' had a rogue editing mistake that inadvertently
dropped a goto cleanup in storagePoolSetAutostart, but Coverity noted it.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

 NB: Pushed as trivial the other day, but forgot to send the email to
     the list on it.

 src/storage/storage_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index df563f1..e616ae0 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1280,6 +1280,7 @@ storagePoolSetAutostart(virStoragePoolPtr pool,
     if (!obj->configFile) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        "%s", _("pool has no config file"));
+        goto cleanup;
     }
 
     autostart = (autostart != 0);
-- 
2.9.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list