From nobody Thu May 2 22:12:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1498578986126896.7430524261684; Tue, 27 Jun 2017 08:56:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FA13C04574B; Tue, 27 Jun 2017 15:56:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40DEE80DAC; Tue, 27 Jun 2017 15:56:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4289A1800C83; Tue, 27 Jun 2017 15:56:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v5RFsvfj016479 for ; Tue, 27 Jun 2017 11:54:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id AB3C68A785; Tue, 27 Jun 2017 15:54:57 +0000 (UTC) Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A196A8D77A for ; Tue, 27 Jun 2017 15:54:55 +0000 (UTC) Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3AD347F407 for ; Tue, 27 Jun 2017 15:54:54 +0000 (UTC) Received: by mail-qt0-f196.google.com with SMTP id w12so4276541qta.2 for ; Tue, 27 Jun 2017 08:54:54 -0700 (PDT) Received: from pc (dyn-160-39-135-156.dyn.columbia.edu. [160.39.135.156]) by smtp.gmail.com with ESMTPSA id 127sm2430526qkd.24.2017.06.27.08.54.51 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Jun 2017 08:54:52 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9FA13C04574B Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9FA13C04574B Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="enBoRbYO" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3AD347F407 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=srwx4096@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3AD347F407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=N9yEwocaqFQADnVG7QiGAFa31m4fwGRTTnvCkeMGKOk=; b=enBoRbYOGt15LggTEEY2U50zkE0lLD+x7+DkjnGd0sRY6bxinj3MLVRHHLaZWruB+A ImiTm66zSeM2eD5dJk2RLVcIwHReS7YtBy5RQV5YPi4WDsKrqASlyHbMcPqJ4aFtL5+a cMQYx9vdOu0wW5gsGZJHTHMJn9iJBX6SKVUivdD+tFtUKhTQn/uhQ78T1VnBqD3LyZZX D5l9wFYKOoLb8ci16pbttCh/ZSwmcdQwDHUMkES/MRF5ca/DCENIp2SzZ/FgfnuPRlN5 xv57j9u3b0l/ylAtz0Ybp870KR4rR7/jY0rRg8SERDH8wKKlK7B8rvrgoY6CY9ku5Ifd 3mXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=N9yEwocaqFQADnVG7QiGAFa31m4fwGRTTnvCkeMGKOk=; b=NWi1hwtOJ0n3OL3Qyk+2MI5ufio8KGFX3xY2H3YzgZ7A5ENnRqjkLNNIVJABrdiQ0s mrVqW2CJHZ7op0vTud+nC+LXsEUuz0W3VI16LHyHEmFnbeZKcg2Ef9KyggsOZTntxtTF INJiiptJbUxa/WQ2iK9RSds5FMNvneG/oV8NtMd2yJQQtXWfSOd7eoQt04BZa3e/vN4l 9dRWdqNn9PFDv/+Ltpcss2ZSYxDqVU4qA4hnaMMxv0F8BI0mn4DDmFpPnMMajT8Zitdf V0VCZlCFFXg/mnMTaitzXlYaM2n9w25j4JbpxgXxH4VcmltvaNw94vDLyoHCOb4ZM4+k 7J+g== X-Gm-Message-State: AKS2vOwHKPu3vVd3o/SlJkM3EUUSrskdBtqtUbQFpFkig7+zEu9Pntk0 F0nBcxTz8eSRGbov X-Received: by 10.200.3.98 with SMTP id w34mr5211201qtg.203.1498578893145; Tue, 27 Jun 2017 08:54:53 -0700 (PDT) Date: Tue, 27 Jun 2017 11:54:50 -0400 From: Daniel Liu To: libvir-list@redhat.com Message-ID: <20170627155450.GA108608@pc> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 27 Jun 2017 15:54:54 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 27 Jun 2017 15:54:54 +0000 (UTC) for IP:'209.85.216.196' DOMAIN:'mail-qt0-f196.google.com' HELO:'mail-qt0-f196.google.com' FROM:'srwx4096@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.42 * (BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.216.196 mail-qt0-f196.google.com 209.85.216.196 mail-qt0-f196.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.25 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virsh: Fix --help problem for domxml-to-native DOMAIN COMMAND X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 27 Jun 2017 15:56:23 +0000 (UTC) X-ZohoMail-DKIM: fail (Computed bodyhash is different from the expected one) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Resolves a bug in domxml-to-native command option, so that the following command displays the help information correctly: 'virsh domxml-to-native --help'. Signed-off-by: Daniel Liu Signed-off-by: Julio Faracco Reviewed-by: John Ferlan --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5311a57c2..55f4e14a4 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9857,12 +9857,12 @@ static const vshCmdOptDef opts_domxmltonative[] =3D= { .help =3D N_("target config data type format") }, {.name =3D "domain", - .type =3D VSH_OT_DATA, + .type =3D VSH_OT_STRING, .flags =3D VSH_OFLAG_REQ_OPT, .help =3D N_("domain name, id or uuid") }, {.name =3D "xml", - .type =3D VSH_OT_DATA, + .type =3D VSH_OT_ARGV, .help =3D N_("xml data file to export from") }, {.name =3D NULL} --=20 2.13.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list