From nobody Mon May 6 06:14:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1496692696320185.2099351671568; Mon, 5 Jun 2017 12:58:16 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 23ED74DB14; Mon, 5 Jun 2017 19:58:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7183C17DF7; Mon, 5 Jun 2017 19:58:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E3817180BAFA; Mon, 5 Jun 2017 19:57:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v55Jvq8M019267 for ; Mon, 5 Jun 2017 15:57:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 224D01711D; Mon, 5 Jun 2017 19:57:52 +0000 (UTC) Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D6C67DFE5 for ; Mon, 5 Jun 2017 19:57:50 +0000 (UTC) Received: from mail-qt0-f176.google.com (mail-qt0-f176.google.com [209.85.216.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BB9C3B470 for ; Mon, 5 Jun 2017 19:57:49 +0000 (UTC) Received: by mail-qt0-f176.google.com with SMTP id u19so43867784qta.3 for ; Mon, 05 Jun 2017 12:57:48 -0700 (PDT) Received: from dawid-fedora.datto.lan ([47.19.105.250]) by smtp.gmail.com with ESMTPSA id q41sm22644259qtc.8.2017.06.05.12.57.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Jun 2017 12:57:47 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 23ED74DB14 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 23ED74DB14 Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=datto-com.20150623.gappssmtp.com header.i=@datto-com.20150623.gappssmtp.com header.b="u/TFEVm9" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0BB9C3B470 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=datto.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dzamirski@datto.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0BB9C3B470 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datto-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=m59vV8Cb5wpBsQ2vn+HgKQJszZwpiZSNHtieYdIqIj4=; b=u/TFEVm9pbssLSTObNCivQE7rmSq9cfptbIJ2YPdfekLy/CFxqm41EauZvcX+o+vl5 /3J/mwqSBu+zMFZNM3DW2/Y46qzZU27M/Ah/kWxMCYY0FMxN+DOxhH4etJXmF9hh8gD5 gmE04OpgzCl+XPAQ7IQdpNdmq5pQIRCF18R87gIhKSlutd3hko5eiW7CKy0Gw2bvJGDa GDnt3fffWlCAQ/YlGveayFm/Wh7RwNVgb9UeIQqGh68z5gWNJFnvoaGzAOTzc3KVSMw5 L6UAQlNbN0+/49P4PKkU4+rpCRRdgYG10g4Xg7BQpLEnVqMw1ZuPNLoxn55j8+b5PVic yRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=m59vV8Cb5wpBsQ2vn+HgKQJszZwpiZSNHtieYdIqIj4=; b=F70jAyDumiJoVOLwBuART2Xc1NZqvKtgam9W9ezMBo2SY5VuIDdgyUAMpx2LhAyjyY JTvi/XrTJFLwqewS0JuQiK+L0hDfNMS9F+SMChC1iUTU2UT6fKFoQ5mc7YRTbHtQ3Vap S61OPwgHGmm7Jqqd6V7WW+xdaDwYnTfToJ5Tfc+y6yiJMQJUCFnyXvOntp0wu892TLz5 /eCZDMWvGlQ0iCuGvE+fgwDTqIpXIP45noevWWa7pUy2kWzAKxZjP53uwU87AtrsVzjB neBdDOjsg0/KjPcplxsfMdp3ExijLOCl07IUhVQbyNl9yg34lxOCExprF8796TFQtcgB hwEQ== X-Gm-Message-State: AKS2vOySohsRw6jT2AeP4y1XjEseR6YvlcmucX9/LR3Pe7W5uXkF3hAU chgzOTWDTv36z4xjJWVYKg== X-Received: by 10.55.145.7 with SMTP id t7mr9464024qkd.37.1496692667942; Mon, 05 Jun 2017 12:57:47 -0700 (PDT) From: Dawid Zamirski To: libvir-list@redhat.com Date: Mon, 5 Jun 2017 15:57:46 -0400 Message-Id: <20170605195746.10511-1-dzamirski@datto.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 05 Jun 2017 19:57:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 05 Jun 2017 19:57:49 +0000 (UTC) for IP:'209.85.216.176' DOMAIN:'mail-qt0-f176.google.com' HELO:'mail-qt0-f176.google.com' FROM:'dzamirski@datto.com' RCPT:'' X-RedHat-Spam-Score: 0.869 (BAYES_50, DCC_REPUT_00_12, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.216.176 mail-qt0-f176.google.com 209.85.216.176 mail-qt0-f176.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.30 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [libvirt-php PATCH] add API bindings for get/set network autostart X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 05 Jun 2017 19:58:14 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Aside from that: * fix arginfo_libvirt_conn_flags - it has 2 args not 1 * get rid arginfo_libvirt_domain_set_autostart and use arginfo_libvirt_conn_flags instead as it's the same. --- src/libvirt-php.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++----= --- src/libvirt-php.h | 2 ++ 2 files changed, 49 insertions(+), 7 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 99d6397..c2ab0da 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -284,7 +284,7 @@ ZEND_ARG_INFO(0, conn) ZEND_ARG_INFO(0, to) ZEND_END_ARG_INFO() =20 -ZEND_BEGIN_ARG_INFO_EX(arginfo_libvirt_conn_flags, 0, 0, 1) +ZEND_BEGIN_ARG_INFO_EX(arginfo_libvirt_conn_flags, 0, 0, 2) ZEND_ARG_INFO(0, conn) ZEND_ARG_INFO(0, flags) ZEND_END_ARG_INFO() @@ -399,11 +399,6 @@ ZEND_ARG_INFO(0, res) ZEND_ARG_INFO(0, mac) ZEND_END_ARG_INFO() =20 -ZEND_BEGIN_ARG_INFO_EX(arginfo_libvirt_domain_set_autostart, 0, 0, 2) -ZEND_ARG_INFO(0, conn) -ZEND_ARG_INFO(0, flags) -ZEND_END_ARG_INFO() - ZEND_BEGIN_ARG_INFO_EX(arginfo_libvirt_domain_get_metadata, 0, 0, 4) ZEND_ARG_INFO(0, conn) ZEND_ARG_INFO(0, type) @@ -662,7 +657,7 @@ static zend_function_entry libvirt_functions[] =3D { PHP_FE(libvirt_domain_get_block_info, arginfo_libvirt_domain_ge= t_block_info) PHP_FE(libvirt_domain_get_network_info, arginfo_libvirt_domain_ge= t_network_info) PHP_FE(libvirt_domain_get_autostart, arginfo_libvirt_conn) - PHP_FE(libvirt_domain_set_autostart, arginfo_libvirt_domain_se= t_autostart) + PHP_FE(libvirt_domain_set_autostart, arginfo_libvirt_conn_flag= s) PHP_FE(libvirt_domain_get_metadata, arginfo_libvirt_domain_ge= t_metadata) PHP_FE(libvirt_domain_set_metadata, arginfo_libvirt_domain_se= t_metadata) PHP_FE(libvirt_domain_is_active, arginfo_libvirt_conn) @@ -724,6 +719,8 @@ static zend_function_entry libvirt_functions[] =3D { PHP_FE(libvirt_network_get_uuid_string, arginfo_libvirt_conn) PHP_FE(libvirt_network_get_uuid, arginfo_libvirt_conn) PHP_FE(libvirt_network_get_name, arginfo_libvirt_conn) + PHP_FE(libvirt_network_get_autostart, arginfo_libvirt_conn) + PHP_FE(libvirt_network_set_autostart, arginfo_libvirt_conn_flag= s) /* Node functions */ PHP_FE(libvirt_node_get_info, arginfo_libvirt_conn) PHP_FE(libvirt_node_get_cpu_stats, arginfo_libvirt_conn_optc= punr) @@ -10002,6 +9999,49 @@ PHP_FUNCTION(libvirt_network_get_name) } =20 /* + * Function name: libvirt_network_get_autostart + * Since version: 0.5.4 + * Description: Function is getting the autostart value for the network + * Arguments: @res [resource]: libvirt network resource + * Returns: autostart value or -1 on error + */ +PHP_FUNCTION(libvirt_network_get_autostart) +{ + php_libvirt_network *network =3D NULL; + zval *znetwork; + int autostart; + + GET_NETWORK_FROM_ARGS("r", &znetwork); + + if (virNetworkGetAutostart(network->network, &autostart) !=3D 0) + RETURN_LONG(-1); + + RETURN_LONG((long) autostart); +} + +/* + * Function name: libvirt_network_set_autostart + * Since version: 0.5.4 + * Description: Function is setting the autostart value for the network + * Arguments: @res [resource]: libvirt network resource + * @flags [int]: flag to enable/disable autostart + * Returns: TRUE on success, FALSE on error + */ +PHP_FUNCTION(libvirt_network_set_autostart) +{ + php_libvirt_network *network =3D NULL; + zval *znetwork; + zend_long autostart =3D 0; + + GET_NETWORK_FROM_ARGS("rl", &znetwork, &autostart); + + if (virNetworkSetAutostart(network->network, autostart) < 0) + RETURN_FALSE; + + RETURN_TRUE; +} + +/* * Function name: libvirt_version * Since version: 0.4.1(-1) * Description: Function is used to get libvirt, driver and libvirt-ph= p version numbers. Can be used for information purposes, for version checki= ng please use libvirt_check_version() defined below diff --git a/src/libvirt-php.h b/src/libvirt-php.h index f87d180..f9dec09 100644 --- a/src/libvirt-php.h +++ b/src/libvirt-php.h @@ -423,6 +423,8 @@ PHP_FUNCTION(libvirt_network_set_active); PHP_FUNCTION(libvirt_network_get_uuid_string); PHP_FUNCTION(libvirt_network_get_uuid); PHP_FUNCTION(libvirt_network_get_name); +PHP_FUNCTION(libvirt_network_get_autostart); +PHP_FUNCTION(libvirt_network_set_autostart); /* Nodedev functions */ PHP_FUNCTION(libvirt_nodedev_get); PHP_FUNCTION(libvirt_nodedev_capabilities); --=20 2.13.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list