Let's introduce two new capabilities to the node_device driver and fix two
smaller issues on the way.

The first is for CCW devices, most common on the S390 architecture. We expose
the relevant cssid, ssid and devno values.

The second is for fibre channel-backed SCSI devices, where we introduce the
fc_remote_port subcapability for SCSI targets. Here we expose the relevant
rport name as well as the port_name (WWPN).

Bjoern Walk (5):
  node_device: detect CCW devices
  virsh: nodedev: ability to filter CCW capabilities
  util: helper functions for fibre channel devices
  node_device: introduce new capability FC_RPORT
  docs: update news.xml

Marc Hartmayer (2):
  node_device: Use the iterator variable
  node_device: Unlock obj in case of an error too

 docs/formatnode.html.in                           |  12 ++
 docs/news.xml                                     |  11 ++
 docs/schemas/basictypes.rng                       |  31 +++++
 docs/schemas/domaincommon.rng                     |  30 -----
 docs/schemas/nodedev.rng                          |  36 ++++++
 include/libvirt/libvirt-nodedev.h                 |   1 +
 po/POTFILES.in                                    |   1 +
 src/Makefile.am                                   |   1 +
 src/conf/node_device_conf.c                       | 150 +++++++++++++++++++++-
 src/conf/node_device_conf.h                       |  21 ++-
 src/conf/virnodedeviceobj.c                       |   3 +-
 src/libvirt-nodedev.c                             |   1 +
 src/libvirt_private.syms                          |   5 +
 src/node_device/node_device_driver.c              |  16 ++-
 src/node_device/node_device_linux_sysfs.c         |  56 ++++++++
 src/node_device/node_device_linux_sysfs.h         |   2 +
 src/node_device/node_device_udev.c                |  39 +++++-
 src/util/virfcp.c                                 |  96 ++++++++++++++
 src/util/virfcp.h                                 |  32 +++++
 tests/nodedevschemadata/ccw_0_0_10000-invalid.xml |  10 ++
 tests/nodedevschemadata/ccw_0_0_ffff.xml          |  10 ++
 tests/nodedevschemadata/scsi_target1_0_0.xml      |  12 ++
 tests/nodedevxml2xmltest.c                        |   2 +
 tools/virsh-nodedev.c                             |   3 +
 tools/virsh.pod                                   |   2 +-
 25 files changed, 539 insertions(+), 44 deletions(-)
 create mode 100644 src/util/virfcp.c
 create mode 100644 src/util/virfcp.h
 create mode 100644 tests/nodedevschemadata/ccw_0_0_10000-invalid.xml
 create mode 100644 tests/nodedevschemadata/ccw_0_0_ffff.xml
 create mode 100644 tests/nodedevschemadata/scsi_target1_0_0.xml

-- 
2.11.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Thanks a lot for your review John.

If you don't mind, you can make the adjustments you mentioned and push,
as I can only prepare a v2 on Monday and I wanted to get this in v3.4.0.

Best,
Bjoern

-- 
IBM Systems
Linux on z Systems & Virtualization Development
------------------------------------------------------------------------
IBM Deutschland
Schönaicher Str. 220
71032 Böblingen
Phone: +49 7031 16 1819
E-Mail: bwalk@de.ibm.com
------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294 
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 05/26/2017 03:15 AM, Bjoern Walk wrote:
> Thanks a lot for your review John.
> 
> If you don't mind, you can make the adjustments you mentioned and push,
> as I can only prepare a v2 on Monday and I wanted to get this in v3.4.0.
> 
> Best,
> Bjoern
> 

I've made the adjustments and will push this sometime today...

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, May 26, 2017 at 07:11:53AM -0400, John Ferlan wrote:
> 
> 
> On 05/26/2017 03:15 AM, Bjoern Walk wrote:
> > Thanks a lot for your review John.
> > 
> > If you don't mind, you can make the adjustments you mentioned and push,
> > as I can only prepare a v2 on Monday and I wanted to get this in v3.4.0.
> > 
> > Best,
> > Bjoern
> > 
> 
> I've made the adjustments and will push this sometime today...

FYI this broke the build on OS-X


util/virfcp.c:85:5: error: implicit declaration of function 'virReportSystemError' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

    virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));

util/virfcp.c:83:1: error: no previous prototype for function 'virSysfsIsCapableFCRport' [-Werror,-Wmissing-prototypes]

virSysfsIsCapableFCRport(const char *rport ATTRIBUTE_UNUSED)

util/virfcp.c:90:1: error: no previous prototype for function 'virSysfsReadFCRport' [-Werror,-Wmissing-prototypes]

virSysfsReadFCRport(const char *rport ATTRIBUTE_UNUSED,


https://travis-ci.org/libvirt/libvirt/jobs/236407391

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

  Daniel P. Berrange wrote:

> On Fri, May 26, 2017 at 07:11:53AM -0400, John Ferlan wrote:
> > 
> > 
> > On 05/26/2017 03:15 AM, Bjoern Walk wrote:
> > > Thanks a lot for your review John.
> > > 
> > > If you don't mind, you can make the adjustments you mentioned and push,
> > > as I can only prepare a v2 on Monday and I wanted to get this in v3.4.0.
> > > 
> > > Best,
> > > Bjoern
> > > 
> > 
> > I've made the adjustments and will push this sometime today...
> 
> FYI this broke the build on OS-X
> 
> 
> util/virfcp.c:85:5: error: implicit declaration of function 'virReportSystemError' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> 
>     virReportSystemError(ENOSYS, "%s", _("Not supported on this platform"));
> 
> util/virfcp.c:83:1: error: no previous prototype for function 'virSysfsIsCapableFCRport' [-Werror,-Wmissing-prototypes]
> 
> virSysfsIsCapableFCRport(const char *rport ATTRIBUTE_UNUSED)
> 
> util/virfcp.c:90:1: error: no previous prototype for function 'virSysfsReadFCRport' [-Werror,-Wmissing-prototypes]
> 
> virSysfsReadFCRport(const char *rport ATTRIBUTE_UNUSED,
> 
> 
> https://travis-ci.org/libvirt/libvirt/jobs/236407391
> 
> Regards,
> Daniel

This breaks build on FreeBSD as well. I have a fix that I plan to push
shortly.

Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list