From: w00185384 <king.wang@huawei.com>

Since refactoring by commit id 'a7035662', @errbuf is no longer used.
---
 src/util/virpci.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/util/virpci.c b/src/util/virpci.c
index c89b94b..83c7e74 100644
--- a/src/util/virpci.c
+++ b/src/util/virpci.c
@@ -2618,7 +2618,6 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link)
     virPCIDeviceAddressPtr bdf = NULL;
     char *config_address = NULL;
     char *device_path = NULL;
-    char errbuf[64];
 
     if (!virFileExists(device_link)) {
         VIR_DEBUG("'%s' does not exist", device_link);
@@ -2627,7 +2626,6 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link)
 
     device_path = canonicalize_file_name(device_link);
     if (device_path == NULL) {
-        memset(errbuf, '\0', sizeof(errbuf));
         virReportSystemError(errno,
                              _("Failed to resolve device link '%s'"),
                              device_link);
-- 
2.8.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, Apr 27, 2017 at 09:52:52AM +0800, Wang King wrote:
> From: w00185384 <king.wang@huawei.com>

You should tweak your git config to use your real name. Since you already have
a few patches in libvirt, I changed the 'author' field according to those.
I also see you used S-o-B in the past which might become relevant again
regarding the very recent discussion on the list [1] ;).

Anyhow, ACK and pushed.
Erik

[1] https://www.redhat.com/archives/libvir-list/2017-April/msg01244.html

>
> Since refactoring by commit id 'a7035662', @errbuf is no longer used.
> ---
>  src/util/virpci.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/util/virpci.c b/src/util/virpci.c
> index c89b94b..83c7e74 100644
> --- a/src/util/virpci.c
> +++ b/src/util/virpci.c
> @@ -2618,7 +2618,6 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link)
>      virPCIDeviceAddressPtr bdf = NULL;
>      char *config_address = NULL;
>      char *device_path = NULL;
> -    char errbuf[64];
>
>      if (!virFileExists(device_link)) {
>          VIR_DEBUG("'%s' does not exist", device_link);
> @@ -2627,7 +2626,6 @@ virPCIGetDeviceAddressFromSysfsLink(const char *device_link)
>
>      device_path = canonicalize_file_name(device_link);
>      if (device_path == NULL) {
> -        memset(errbuf, '\0', sizeof(errbuf));
>          virReportSystemError(errno,
>                               _("Failed to resolve device link '%s'"),
>                               device_link);
> --
> 2.8.3
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list