On Tue, Apr 25, 2017 at 02:50:34PM -0400, Laine Stump wrote:
>The parser had been clearing out *all* suggested device names for
>type='direct' (aka macvtap) interfaces. All of the code implementing
>macvtap allows for a user-specified device name, so we should allow
>it. In the case that an interface name starts with "macvtap" or
>"macvlan" though, we do still clear it out, just as we do with "vnet"
>(which is the prefix used for automatically generated tap device
>names), since those are the prefixes for the names we autogenerate for
>macvtap and macvlan devices.
>
>Resolves: https://bugzilla.redhat.com/1335798
>
>Changes since V1:
>
>* make a single #define for each of MACVLAN_PREFIX and MACVTAP_PREFIX
> in virnetdevmacvlan.h rather than duplicating #defines from
> virnetdevmacvlan.c into domain_conf.h (as suggested by Martin
>
>* move/rename the auto-generated prefix for regular tap devices to be
> consistent with the macvtap/macvlan prefixes.
>
>Laine Stump (3):
> util: make macvtap/macvlan generated name #defines available to other
> files
> conf: don't ignore <target dev='blah'/> for macvtap interfaces
> util: rename/move VIR_NET_GENERATED_PREFIX to be consistent
>
> docs/formatdomain.html.in | 6 ++--
> src/bhyve/bhyve_command.c | 4 +--
> src/conf/domain_conf.c | 11 ++++--
> src/conf/domain_conf.h | 4 ---
> src/interface/interface_backend_udev.c | 2 +-
> src/qemu/qemu_interface.c | 8 ++---
> src/uml/uml_conf.c | 4 +--
> src/util/virnetdev.h | 5 +++
> src/util/virnetdevmacvlan.c | 65 ++++++++++++++--------------------
> src/util/virnetdevmacvlan.h | 6 ++++
> 10 files changed, 57 insertions(+), 58 deletions(-)
>
ACK series. I, personally, am voting for more features and fixes that
actually remove code ;)
>--
>2.9.3
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list