From nobody Thu May 2 08:56:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1492959457391208.33729014410278; Sun, 23 Apr 2017 07:57:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65BBC7572F; Sun, 23 Apr 2017 14:57:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (unknown [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5429017B4B; Sun, 23 Apr 2017 14:57:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5B9544E9BB; Sun, 23 Apr 2017 14:57:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v3NEvOoi025431 for ; Sun, 23 Apr 2017 10:57:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5798077EB5; Sun, 23 Apr 2017 14:57:24 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 510E177EAA for ; Sun, 23 Apr 2017 14:57:22 +0000 (UTC) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57CA04AE8E for ; Sun, 23 Apr 2017 14:57:20 +0000 (UTC) Received: by mail-lf0-f53.google.com with SMTP id t144so62960672lff.1 for ; Sun, 23 Apr 2017 07:57:20 -0700 (PDT) Received: from kloomba.my.domain ([31.29.233.47]) by smtp.gmail.com with ESMTPSA id 17sm2739597ljo.56.2017.04.23.07.57.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Apr 2017 07:57:17 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 65BBC7572F Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 65BBC7572F Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eXABJShz" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 57CA04AE8E Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=bogorodskiy@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 57CA04AE8E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=pnHDODq3ZsvAj/2zvBF3PLN0NvlC7cGaBXVMLVd4iXs=; b=eXABJShzLGWF1NN197eeibjMpr1hM7/LXz1Mz53icDmv0C4iluDoMuSJfDJtlQ17uz K67OQBBuFpfTlc5PDKp/4602sQ9JNtxl76Dh/GRuMAe7IQe7Sao+BIQ0XBZDJziXRysg V1a0075M6CoAy5M6jzKVJmTyE6zCkJA9CsheAOn57ttPVM1Xz9VIeR1qfxBW3E0bjOHD XoYXrYfYZzS6R2TFr6cZm21HZXfFl8IfTy88uVHWtTQRpTYpclUNVY76eq4xMjgyT7z7 2iDs9H7/qciP7Hlt6njI07J7NS/O/lVmCGGpWCSN3YmAJi7KAOO+gZFOUo5oRq34uQIz XQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pnHDODq3ZsvAj/2zvBF3PLN0NvlC7cGaBXVMLVd4iXs=; b=WG/I/2aPnq8dvtffmq6CZF3ZR22drhM3DlQ1Vn/lCemCA8fpWqBm3uzA12qzbhDo/U I7AujRTV1GJopRlbpjq60e66u0uBMJMMkI0OsibAI0VxCCLLZcKDi0u6ltR3MWhDtmsd MFrrT/gtsRdereKFvP0yGv7LTSAezET86/ttB+wEl6kMJix2jkNgS2PN/Hte4G/k10On +q/+NFQpqsRx5Ot56tbT5X57b2Rw2m2OoQPzk8rEVHTJ0shAJQOh+ELeF6Rtmmnk5tSq nXgBjcSFsqhdvSp47Lj224mlOeQc/saYVVuIaR5CW7yuxH0+v5twUlEdAOa9lLfN4FYP +F2g== X-Gm-Message-State: AN3rC/79zDh/F61hYGHlK2NiIDDrQWgEH78UGFsRxIt+HvGUYr4bDHrv QA/L/+Pj0LubB9ZT X-Received: by 10.25.67.13 with SMTP id q13mr7204187lfa.36.1492959438571; Sun, 23 Apr 2017 07:57:18 -0700 (PDT) From: Roman Bogorodskiy To: libvir-list@redhat.com Date: Sun, 23 Apr 2017 18:57:07 +0400 Message-Id: <20170423145707.81181-1-bogorodskiy@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 23 Apr 2017 14:57:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 23 Apr 2017 14:57:20 +0000 (UTC) for IP:'209.85.215.53' DOMAIN:'mail-lf0-f53.google.com' HELO:'mail-lf0-f53.google.com' FROM:'bogorodskiy@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.77 (BAYES_50, DCC_REPUT_00_12, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.215.53 mail-lf0-f53.google.com 209.85.215.53 mail-lf0-f53.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Roman Bogorodskiy Subject: [libvirt] [PATCH] util: relax virNetDevSetCoalesce() stub X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 23 Apr 2017 14:57:35 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Currently, virNetDevSetCoalesce() stub is always returning error. As it's used by virNetDevTapCreateInBridgePort(), it essentially breaks bridged networking if coalesce is not supported. To make it work, relax the stub to trigger error only when its coalesce argument is not NULL, otherwise report success. --- src/util/virnetdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 131a56a8d..131c4d983 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -3155,8 +3155,11 @@ int virNetDevSetCoalesce(const char *ifname, } # else int virNetDevSetCoalesce(const char *ifname, - virNetDevCoalescePtr coalesce ATTRIBUTE_UNUSED) + virNetDevCoalescePtr coalesce) { + if (!coalesce) + return 0; + virReportSystemError(ENOSYS, _("Cannot set coalesce info on interface '%s'"), ifname); --=20 2.11.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list