[libvirt] [PATCH 0/5] Use-after-free fix and cleanups

Marc Hartmayer posted 5 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170403082439.10180-1-mhartmay@linux.vnet.ibm.com
src/datatypes.c              |  6 ++--
src/qemu/qemu_domain.c       | 72 ++++++++++++++++++++------------------
src/qemu/qemu_domain.h       |  2 --
src/qemu/qemu_monitor.c      | 82 ++++++++++++++++++++++++++++++++++----------
src/qemu/qemu_monitor.h      |  6 ++++
src/qemu/qemu_process.c      | 12 +++----
src/rpc/virnetclientstream.c |  4 +--
src/rpc/virnetserver.c       |  9 ++---
tests/qemumonitortestutils.c |  3 +-
9 files changed, 121 insertions(+), 75 deletions(-)
[libvirt] [PATCH 0/5] Use-after-free fix and cleanups
Posted by Marc Hartmayer 7 years ago
While looking at a use-after-free situation going through how the QEMU
monitor is set up I noticed some things. These cleanups and the fix
for the use-after-free are the result of that.

Marc Hartmayer (5):
  qemu: Fix two use-after-free situations
  qemu: Turn qemuDomainLogContext into virObject
  qemu: Implement qemuMonitorRegister()
  qemu: remove ATTRIBUTE_UNUSED in qemuProcessHandleMonitorEOF
  refactoring: Use the return value of virObjectRef directly

 src/datatypes.c              |  6 ++--
 src/qemu/qemu_domain.c       | 72 ++++++++++++++++++++------------------
 src/qemu/qemu_domain.h       |  2 --
 src/qemu/qemu_monitor.c      | 82 ++++++++++++++++++++++++++++++++++----------
 src/qemu/qemu_monitor.h      |  6 ++++
 src/qemu/qemu_process.c      | 12 +++----
 src/rpc/virnetclientstream.c |  4 +--
 src/rpc/virnetserver.c       |  9 ++---
 tests/qemumonitortestutils.c |  3 +-
 9 files changed, 121 insertions(+), 75 deletions(-)

-- 
2.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] Use-after-free fix and cleanups
Posted by Michal Privoznik 7 years ago
On 04/03/2017 10:24 AM, Marc Hartmayer wrote:
> While looking at a use-after-free situation going through how the QEMU
> monitor is set up I noticed some things. These cleanups and the fix
> for the use-after-free are the result of that.
>
> Marc Hartmayer (5):
>   qemu: Fix two use-after-free situations
>   qemu: Turn qemuDomainLogContext into virObject
>   qemu: Implement qemuMonitorRegister()
>   qemu: remove ATTRIBUTE_UNUSED in qemuProcessHandleMonitorEOF
>   refactoring: Use the return value of virObjectRef directly
>
>  src/datatypes.c              |  6 ++--
>  src/qemu/qemu_domain.c       | 72 ++++++++++++++++++++------------------
>  src/qemu/qemu_domain.h       |  2 --
>  src/qemu/qemu_monitor.c      | 82 ++++++++++++++++++++++++++++++++++----------
>  src/qemu/qemu_monitor.h      |  6 ++++
>  src/qemu/qemu_process.c      | 12 +++----
>  src/rpc/virnetclientstream.c |  4 +--
>  src/rpc/virnetserver.c       |  9 ++---
>  tests/qemumonitortestutils.c |  3 +-
>  9 files changed, 121 insertions(+), 75 deletions(-)
>

ACKed and pushed. Thanks.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/5] Use-after-free fix and cleanups
Posted by Marc Hartmayer 7 years ago
On Mon, Apr 10, 2017 at 02:52 PM +0200, Michal Privoznik <mprivozn@redhat.com> wrote:
> On 04/03/2017 10:24 AM, Marc Hartmayer wrote:
>> While looking at a use-after-free situation going through how the QEMU
>> monitor is set up I noticed some things. These cleanups and the fix
>> for the use-after-free are the result of that.
>>
>> Marc Hartmayer (5):
>>   qemu: Fix two use-after-free situations
>>   qemu: Turn qemuDomainLogContext into virObject
>>   qemu: Implement qemuMonitorRegister()
>>   qemu: remove ATTRIBUTE_UNUSED in qemuProcessHandleMonitorEOF
>>   refactoring: Use the return value of virObjectRef directly
>>
>>  src/datatypes.c              |  6 ++--
>>  src/qemu/qemu_domain.c       | 72 ++++++++++++++++++++------------------
>>  src/qemu/qemu_domain.h       |  2 --
>>  src/qemu/qemu_monitor.c      | 82 ++++++++++++++++++++++++++++++++++----------
>>  src/qemu/qemu_monitor.h      |  6 ++++
>>  src/qemu/qemu_process.c      | 12 +++----
>>  src/rpc/virnetclientstream.c |  4 +--
>>  src/rpc/virnetserver.c       |  9 ++---
>>  tests/qemumonitortestutils.c |  3 +-
>>  9 files changed, 121 insertions(+), 75 deletions(-)
>>
>
> ACKed and pushed. Thanks.

Thanks.

>
> Michal
>
-- 
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list