[libvirt] [PATCH] configure: disable scsi stroage driver on non-Linux

Roman Bogorodskiy posted 1 patch 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170305142023.71726-1-bogorodskiy@gmail.com
configure.ac | 1 +
1 file changed, 1 insertion(+)
[libvirt] [PATCH] configure: disable scsi stroage driver on non-Linux
Posted by Roman Bogorodskiy 7 years ago
Even though scsi storage driver builds fine on non-Linux, it
will not work properly because it relies on Linux procfs, so
disable that in configure if we're not building for Linux.
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure.ac b/configure.ac
index e61ab7ba6..cf50422d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -192,6 +192,7 @@ if test $with_linux = no; then
         with_lxc=no
     fi
     with_dtrace=no
+    with_storage_scsi=no
 fi
 
 if test $with_freebsd = yes; then
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] configure: disable scsi stroage driver on non-Linux
Posted by Michal Privoznik 7 years ago
On 03/05/2017 03:20 PM, Roman Bogorodskiy wrote:
> Even though scsi storage driver builds fine on non-Linux, it
> will not work properly because it relies on Linux procfs, so
> disable that in configure if we're not building for Linux.
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure.ac b/configure.ac
> index e61ab7ba6..cf50422d5 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -192,6 +192,7 @@ if test $with_linux = no; then
>          with_lxc=no
>      fi
>      with_dtrace=no
> +    with_storage_scsi=no
>  fi
>  
>  if test $with_freebsd = yes; then
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] configure: disable scsi stroage driver on non-Linux
Posted by Roman Bogorodskiy 7 years ago
  Michal Privoznik wrote:

> On 03/05/2017 03:20 PM, Roman Bogorodskiy wrote:
> > Even though scsi storage driver builds fine on non-Linux, it
> > will not work properly because it relies on Linux procfs, so
> > disable that in configure if we're not building for Linux.
> > ---
> >  configure.ac | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index e61ab7ba6..cf50422d5 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -192,6 +192,7 @@ if test $with_linux = no; then
> >          with_lxc=no
> >      fi
> >      with_dtrace=no
> > +    with_storage_scsi=no
> >  fi
> >  
> >  if test $with_freebsd = yes; then
> > 
> 
> ACK

Pushed, thanks!

Roman Bogorodskiy
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list