[libvirt] [PATCH 0/3] Clean

John Ferlan posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170304150024.30063-1-jferlan@redhat.com
src/test/test_driver.c | 499 ++++++++++++++++---------------------------------
1 file changed, 166 insertions(+), 333 deletions(-)
[libvirt] [PATCH 0/3] Clean
Posted by John Ferlan 7 years, 1 month ago
More "fallout" from the RFC series to make a common pool object:

http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html

were changes made along the way in the test_driver code to "commonalize"
the various vir*ObjFindBy{Name|UUID} callers. This series will do the
same for the existing code.

Not even attempted was making test_driver to have updated coding style
(maybe another day for that)!

John Ferlan (3):
  test: Make common test*ObjFindByName helpers
  test: Make a common testNetworkObjFindByName
  test: Make common test*ObjFindByUUID helpers

 src/test/test_driver.c | 499 ++++++++++++++++---------------------------------
 1 file changed, 166 insertions(+), 333 deletions(-)

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] Clean
Posted by John Ferlan 7 years, 1 month ago
Obviously something caused truncation of my subject...

Should be "Clean test_driver calls" or something similar.

John

On 03/04/2017 10:00 AM, John Ferlan wrote:
> More "fallout" from the RFC series to make a common pool object:
> 
> http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html
> 
> were changes made along the way in the test_driver code to "commonalize"
> the various vir*ObjFindBy{Name|UUID} callers. This series will do the
> same for the existing code.
> 
> Not even attempted was making test_driver to have updated coding style
> (maybe another day for that)!
> 
> John Ferlan (3):
>   test: Make common test*ObjFindByName helpers
>   test: Make a common testNetworkObjFindByName
>   test: Make common test*ObjFindByUUID helpers
> 
>  src/test/test_driver.c | 499 ++++++++++++++++---------------------------------
>  1 file changed, 166 insertions(+), 333 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] Clean
Posted by Michal Privoznik 7 years, 1 month ago
On 04.03.2017 16:00, John Ferlan wrote:
> More "fallout" from the RFC series to make a common pool object:
> 
> http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html
> 
> were changes made along the way in the test_driver code to "commonalize"
> the various vir*ObjFindBy{Name|UUID} callers. This series will do the
> same for the existing code.
> 
> Not even attempted was making test_driver to have updated coding style
> (maybe another day for that)!
> 
> John Ferlan (3):
>   test: Make common test*ObjFindByName helpers
>   test: Make a common testNetworkObjFindByName
>   test: Make common test*ObjFindByUUID helpers
> 
>  src/test/test_driver.c | 499 ++++++++++++++++---------------------------------
>  1 file changed, 166 insertions(+), 333 deletions(-)
> 

Nice cleanup. ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list