From nobody Mon Apr 29 10:31:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.25 as permitted sender) client-ip=209.132.183.25; envelope-from=libvir-list-bounces@redhat.com; helo=mx4-phx2.redhat.com; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.25 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by mx.zohomail.com with SMTPS id 1488555981554294.67055955283945; Fri, 3 Mar 2017 07:46:21 -0800 (PST) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v23FgIAb021677; Fri, 3 Mar 2017 10:42:19 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v23FgHC5002525 for ; Fri, 3 Mar 2017 10:42:17 -0500 Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.32]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v23FgHhr013017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Mar 2017 10:42:17 -0500 Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B86F0C054C51; Fri, 3 Mar 2017 15:42:15 +0000 (UTC) Received: by mail-pg0-f67.google.com with SMTP id s67so12995178pgb.1; Fri, 03 Mar 2017 07:42:14 -0800 (PST) Received: from lenovo.ireo.local ([122.162.12.169]) by smtp.gmail.com with ESMTPSA id u75sm24229322pfk.3.2017.03.03.07.42.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Mar 2017 07:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=y/3RptgwqeQEDnNmvP27SjPkdZ7Qfo3X+mnWokMoMOo=; b=Au3CoX5J0KIRT2fCZVCYjfFpAjPr0xDKZzKtJzfkLa/EYsgUIr+JXNJ7f+uExaFBtC do2JmlEKyX9sBTzHNBCeMfHavPBXr3FbPN3CMYboPH7mprK0r5tNVE0YYYECkxRIoQ2T XI1lfh6Jw9K272dIE0q9L0SMcqSDFnPlKaslyjbUtXZefGKAFoobUuMVesFNjrIjbPka kErh15uDxTUKQGKZJQzSMl+6F+C4r2sSD8pyxCvKLewLpO+SRchetdTB26km4VU8p4kN a+fjhK8Ga3AF/dKwwgOce1O+UQB6LxEdPmMXfaYq6x2yV+ft0LdKoZC6T1QKgX2B3Cz8 RTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=y/3RptgwqeQEDnNmvP27SjPkdZ7Qfo3X+mnWokMoMOo=; b=MgpJsloLza56Z7Q4GAOASm3n5WyFg32b3I+wDiF/VtpqlSXw16/Pb3ana+pucZ2hgz G8fyIxQno78zE6gRIMwwCrp1gCYF3p0jr7GZkKbMEfckW+dUhwKKgxzdtF92N1IZ2lqj NDJE/KS4TibKpP5sYDyvpCokeBDc9j/39GOBhN+YQ3gQh2PkW93cWEMx4zdPXRq9I+8U Z2Ev/WdAm9LR1vFNr/fYptiZqPgsJnSE3hB2MkHwygFs5xHRsEOSkCXTC8mhJcfdt3PP dOF6661fEQ4SGkiJlg0E24oipHSdyEZ8cqcmC9s9JWCq8tTXIJY9D4ZNY7Lv23hUON3S tt8Q== X-Gm-Message-State: AMke39n9I8khOgyzZ11J9lAYvuciQiQXqVUMTMK/PHYqEaXoA1ExB7Qvf7VLW9oHad2lRQ== X-Received: by 10.99.143.11 with SMTP id n11mr4154989pgd.177.1488555734230; Fri, 03 Mar 2017 07:42:14 -0800 (PST) From: Nehal J Wani To: libvir-list@redhat.com Date: Fri, 3 Mar 2017 21:12:09 +0530 Message-Id: <20170303154209.32536-1-nehaljw.kkd1@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 03 Mar 2017 15:42:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 03 Mar 2017 15:42:15 +0000 (UTC) for IP:'74.125.83.67' DOMAIN:'mail-pg0-f67.google.com' HELO:'mail-pg0-f67.google.com' FROM:'nehaljw.kkd1@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.32 * (BAYES_50, DCC_REPUT_13_19, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 74.125.83.67 mail-pg0-f67.google.com 74.125.83.67 mail-pg0-f67.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.32 X-loop: libvir-list@redhat.com Cc: nehaljw.kkd1@gmail.com, mprivozn@redhat.com Subject: [libvirt] [PATCH] Fix location of blkid.h in include header X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The build system for libvirt correctly detects the location of blkid using PKG_CONFIG_PATH environment variable. The file blkid.pc states that the include flags should be: 'Cflags: -I${includedir}/blkid' but libvirt searches for blkid.h inside ${includedir}/blkid/blkid, which is wrong. Until now, the compilation for libvirt succeeded because of pure luck, as it had -I/usr/include as a CFLAG. This issue was faced while compiling libvirt on Ubuntu 16.04.2 with bare minimum dev packages and a custom compiled blkid kept in a non-standard $prefix. Signed-off-by: Nehal J Wani --- src/lxc/lxc_container.c | 2 +- src/storage/storage_util.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 99bd7e9..e306b6e 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -49,7 +49,7 @@ #endif =20 #if WITH_BLKID -# include +# include #endif =20 #if WITH_SELINUX diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index a665bac..41253b9 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -39,7 +39,7 @@ #endif =20 #if WITH_BLKID -# include +# include #endif =20 #if WITH_SELINUX --=20 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list