[libvirt] [PATCH v2 0/6] Split out node device object into its own module

John Ferlan posted 6 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20170302161427.31535-1-jferlan@redhat.com
po/POTFILES.in                            |   1 +
src/Makefile.am                           |   3 +-
src/conf/node_device_conf.c               | 757 ++++++------------------------
src/conf/node_device_conf.h               | 316 ++++++-------
src/conf/virnodedeviceobj.c               | 558 ++++++++++++++++++++++
src/conf/virnodedeviceobj.h               |  92 ++++
src/libvirt_private.syms                  |  23 +-
src/node_device/node_device_driver.c      |  30 +-
src/node_device/node_device_driver.h      |   2 +-
src/node_device/node_device_hal.c         |  14 +-
src/node_device/node_device_linux_sysfs.c | 134 +++---
src/node_device/node_device_linux_sysfs.h |   4 +-
src/node_device/node_device_udev.c        | 198 ++++----
src/test/test_driver.c                    |  29 +-
14 files changed, 1164 insertions(+), 997 deletions(-)
create mode 100644 src/conf/virnodedeviceobj.c
create mode 100644 src/conf/virnodedeviceobj.h
[libvirt] [PATCH v2 0/6] Split out node device object into its own module
Posted by John Ferlan 7 years ago
v1: http://www.redhat.com/archives/libvir-list/2017-March/msg00046.html

Differences...

patch 1 and 3 are the same and both were ACK'd
patch 2 removes the lower case function name changes (a/k/a "vir" removal)
patch 4 is new adding modifications as requested by Pavel from patch 1 comment
patch 5 & 6 are new based on a type A reaction to seeing a deeply nested
  structure and picking it apart to allow for more direct access to the
  data fields via pointers which patch6 dutify does for virNodeDevCapDataPtr


John Ferlan (6):
  conf: Introduce virnodedeviceobj
  conf: Adjust coding style for nodedev conf sources
  conf: Use consistent function name prefixes for virnodedeviceobj
  conf: Alter coding style of nodedev function prototypes
  conf: Clean up the _virNodeDevCapData
  nodedev: Reduce virNodeDevCapDataPtr usage

 po/POTFILES.in                            |   1 +
 src/Makefile.am                           |   3 +-
 src/conf/node_device_conf.c               | 757 ++++++------------------------
 src/conf/node_device_conf.h               | 316 ++++++-------
 src/conf/virnodedeviceobj.c               | 558 ++++++++++++++++++++++
 src/conf/virnodedeviceobj.h               |  92 ++++
 src/libvirt_private.syms                  |  23 +-
 src/node_device/node_device_driver.c      |  30 +-
 src/node_device/node_device_driver.h      |   2 +-
 src/node_device/node_device_hal.c         |  14 +-
 src/node_device/node_device_linux_sysfs.c | 134 +++---
 src/node_device/node_device_linux_sysfs.h |   4 +-
 src/node_device/node_device_udev.c        | 198 ++++----
 src/test/test_driver.c                    |  29 +-
 14 files changed, 1164 insertions(+), 997 deletions(-)
 create mode 100644 src/conf/virnodedeviceobj.c
 create mode 100644 src/conf/virnodedeviceobj.h

-- 
2.9.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/6] Split out node device object into its own module
Posted by Erik Skultety 7 years ago
On Thu, Mar 02, 2017 at 11:14:21AM -0500, John Ferlan wrote:
> v1: http://www.redhat.com/archives/libvir-list/2017-March/msg00046.html
> 
> Differences...
> 
> patch 1 and 3 are the same and both were ACK'd
> patch 2 removes the lower case function name changes (a/k/a "vir" removal)
> patch 4 is new adding modifications as requested by Pavel from patch 1 comment
> patch 5 & 6 are new based on a type A reaction to seeing a deeply nested
>   structure and picking it apart to allow for more direct access to the
>   data fields via pointers which patch6 dutify does for virNodeDevCapDataPtr

ACK series.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list