[libvirt] [PATCH go v2] domain.go: wrong calculation of bitmask in PinVcpuFlags()

Leonid Podolny posted 1 patch 7 years ago
Failed in applying to current master (apply log)
domain.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH go v2] domain.go: wrong calculation of bitmask in PinVcpuFlags()
Posted by Leonid Podolny 7 years ago
---
 domain.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/domain.go b/domain.go
index 2bd9852..7276ef8 100644
--- a/domain.go
+++ b/domain.go
@@ -1768,7 +1768,7 @@ func (d *Domain) PinVcpuFlags(vcpu uint, cpuMap []bool, flags DomainModification
 	ccpumap := make([]C.uchar, maplen)
 	for i := 0; i < len(cpuMap); i++ {
 		if cpuMap[i] {
-			byte := (i + 7) / 8
+			byte := i / 8
 			bit := i % 8
 			ccpumap[byte] |= (1 << uint(bit))
 		}
-- 
2.11.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH go v2] domain.go: wrong calculation of bitmask in PinVcpuFlags()
Posted by Daniel P. Berrange 7 years ago
On Mon, Feb 27, 2017 at 07:23:12PM -0500, Leonid Podolny wrote:
> ---
>  domain.go | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/domain.go b/domain.go
> index 2bd9852..7276ef8 100644
> --- a/domain.go
> +++ b/domain.go
> @@ -1768,7 +1768,7 @@ func (d *Domain) PinVcpuFlags(vcpu uint, cpuMap []bool, flags DomainModification
>  	ccpumap := make([]C.uchar, maplen)
>  	for i := 0; i < len(cpuMap); i++ {
>  		if cpuMap[i] {
> -			byte := (i + 7) / 8
> +			byte := i / 8
>  			bit := i % 8
>  			ccpumap[byte] |= (1 << uint(bit))
>  		}

Thanks, applied to git master.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list