rpc: fix typo in admin code generation

[libvirt PATCH] rpc: fix typo in admin code generation

Ján Tomko posted 1 patch 1 year, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1d5c35f5ff2735ef4ea7843cffb8eb3afb15ea62.1678969208.git.jtomko@redhat.com

src/rpc/gendispatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] rpc: fix typo in admin code generation

Posted by Ján Tomko 1 year, 2 months ago

An extra '&' introduced a crash.

https://bugzilla.redhat.com/show_bug.cgi?id=2178866

Fixes: 778c3004609ede0a9df4cf3e01c031047530efb7
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/rpc/gendispatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
index b186849606..704c133215 100755
--- a/src/rpc/gendispatch.pl
+++ b/src/rpc/gendispatch.pl
@@ -1812,7 +1812,7 @@ elsif ($mode eq "client") {
         }
 
         if ($structprefix eq "admin") {
-            print "    VIR_LOCK_GUARD lock = virObjectLockGuard(&priv);\n";
+            print "    VIR_LOCK_GUARD lock = virObjectLockGuard(priv);\n";
         } else {
             print "    VIR_LOCK_GUARD lock = remoteDriverLock(priv);\n";
         }
-- 
2.39.2

Re: [libvirt PATCH] rpc: fix typo in admin code generation

Posted by Peter Krempa 1 year, 2 months ago

On Thu, Mar 16, 2023 at 13:20:16 +0100, Ján Tomko wrote:
> An extra '&' introduced a crash.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2178866
> 
> Fixes: 778c3004609ede0a9df4cf3e01c031047530efb7
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/rpc/gendispatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>