qemuAssignDeviceInputAlias: Be tolerant to pre-existent alias

[libvirt] [PATCH] qemuAssignDeviceInputAlias: Be tolerant to pre-existent alias

Michal Privoznik posted 1 patch 6 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/16866552c8fb3a22b1e1c22ea96efc5b34299951.1520948238.git.mprivozn@redhat.com

Test syntax-check passed

src/qemu/qemu_alias.c | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[libvirt] [PATCH] qemuAssignDeviceInputAlias: Be tolerant to pre-existent alias

Posted by Michal Privoznik 6 years, 1 month ago

This is missing in 6bc4a371cf and therefore we are effectively
overwriting user provided aliases for <input/> devices.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_alias.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c
index ae30f7df8..d0ca15bae 100644
--- a/src/qemu/qemu_alias.c
+++ b/src/qemu/qemu_alias.c
@@ -513,6 +513,9 @@ qemuAssignDeviceInputAlias(virDomainDefPtr def,
                            virDomainInputDefPtr input,
                            int idx)
 {
+    if (input->info.alias)
+        return 0;
+
     if (idx == -1) {
         int thisidx;
         size_t i;
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemuAssignDeviceInputAlias: Be tolerant to pre-existent alias

Posted by Ján Tomko 6 years, 1 month ago

On Tue, Mar 13, 2018 at 02:37:30PM +0100, Michal Privoznik wrote:
>This is missing in 6bc4a371cf and therefore we are effectively
>overwriting user provided aliases for <input/> devices.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/qemu/qemu_alias.c | 3 +++
> 1 file changed, 3 insertions(+)
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list