From nobody Fri May 17 12:56:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1659609405; cv=none; d=zohomail.com; s=zohoarc; b=IAUJK+Di4li0G2kdnUC3jBZ4v8wtoyU39R1maHNLHrq8qSdJdPNKMAnrUp/31UYn6B6GgMwKePkzU7qCkALdr6UwJxzBw4klknu/qvCPb83sKFps/N/vFG7KMTDsa8reULkWJEt9BQRQ1lubn/BxeJkPY40oRTfi0VWFy3NQC1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659609405; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/0xV0cY2+lUo+MPfXPmBUTTneyuFdM7Lt5YRwZIGXrA=; b=nahT8VOgovb9B/63xUMAeLET0en8o+O/O9OTkTF1yZyQrrNScbI0uTQbIwFBubwf+DPJCVUK/wE0QIIjyAPOrG2c8urHSBtNhp9cBm3k98/tmA/GgLnQZiXlMgzaAOHbSrg0diUu6/xcwEEZXr4tpcYesiZqzd5j8tU8OsoGci8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1659609405943675.0590252418845; Thu, 4 Aug 2022 03:36:45 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-MarlVRAlOaSFlEWOG8OB_g-1; Thu, 04 Aug 2022 06:36:40 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B01285A581; Thu, 4 Aug 2022 10:36:39 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98E901410DDA; Thu, 4 Aug 2022 10:36:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7DF981946A53; Thu, 4 Aug 2022 10:36:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2B3931946A52 for ; Thu, 4 Aug 2022 10:36:37 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C764240CFD0A; Thu, 4 Aug 2022 10:36:36 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7344340CFD0E for ; Thu, 4 Aug 2022 10:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659609404; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/0xV0cY2+lUo+MPfXPmBUTTneyuFdM7Lt5YRwZIGXrA=; b=RRF6soTj+1hAoSWubZw2L8wR9816mqvO4F5ZeqEpKADsnWPG4p5nl5lxkksoaZ+GYC1bsi OBFCflOcdCha/7rXd9ExavxaaiouS+ui6zDTbE5c5G6eFs/hJQ70UJPmCwlkTe9LjFTOGX 44KB7ZKyjJ37OM5RgJ5hL+UDAMeTnI0= X-MC-Unique: MarlVRAlOaSFlEWOG8OB_g-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] virhostcpu: Fix non-Linux virHostCPUGetPhysAddrSize() stub Date: Thu, 4 Aug 2022 12:36:35 +0200 Message-Id: <155416ed77120d2c5615b66fa8a96c36feb3f439.1659609383.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1659609406742100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The non-Linux version of virHostCPUGetPhysAddrSize() is lacking G_GNUC_UNUSED attribute to its @size argument which triggers an error on all non-Linux builds. And while at it, make the function actually signal error (ENOSYS) since it does not set the argument. Signed-off-by: Michal Privoznik --- Pushed as build breaker fix. src/util/virhostcpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index 3a02e224e8..54d0166b85 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -1672,9 +1672,10 @@ virHostCPUGetSignature(char **signature) } =20 int -virHostCPUGetPhysAddrSize(unsigned int *size) +virHostCPUGetPhysAddrSize(unsigned int *size G_GNUC_UNUSED) { - return 0; + errno =3D ENOSYS; + return -1; } =20 #endif /* __linux__ */ --=20 2.35.1