adding virGetLastErrorCode/Domain to paritally replace virGetLastError

[libvirt] [PATCH v2 0/3] adding virGetLastErrorCode/Domain to paritally replace virGetLastError

ramyelkest posted 3 patches 5 years, 11 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1525521861-32624-1-git-send-email-ramyelkest@gmail.com

Test syntax-check passed

include/libvirt/virterror.h     |  2 ++
src/libvirt_public.syms         |  6 ++++++
src/locking/lock_driver_lockd.c |  3 +--
src/lxc/lxc_controller.c        |  4 +---
src/qemu/qemu_agent.c           |  3 +--
src/qemu/qemu_conf.c            |  3 +--
src/qemu/qemu_domain.c          |  2 +-
src/qemu/qemu_driver.c          | 12 ++++++------
src/qemu/qemu_hotplug.c         |  2 +-
src/qemu/qemu_migration.c       |  4 ++--
src/qemu/qemu_monitor.c         |  5 ++---
src/qemu/qemu_monitor_json.c    |  2 +-
src/qemu/qemu_process.c         |  4 ++--
src/remote/remote_driver.c      |  3 +--
src/rpc/virnetclient.c          |  2 +-
src/rpc/virnetlibsshsession.c   |  4 +---
src/util/virerror.c             | 42 +++++++++++++++++++++++++++++++++++++++++
src/util/virfilecache.c         |  3 +--
src/util/virmodule.c            |  3 +--
src/util/virxml.c               |  4 ++--
tests/commandtest.c             |  2 +-
tests/testutils.c               |  6 ++----
tests/virhostcputest.c          |  2 +-
tests/virstoragetest.c          |  8 ++++----
tools/virsh-domain-monitor.c    |  7 +++----
tools/virsh-domain.c            |  4 +---
tools/virsh-util.c              |  3 +--
tools/vsh.c                     |  2 +-
28 files changed, 90 insertions(+), 57 deletions(-)

Expand all Fold all

[libvirt] [PATCH v2 0/3] adding virGetLastErrorCode/Domain to paritally replace virGetLastError

Posted by ramyelkest 5 years, 11 months ago

Changes from v1[1]:

* removed virHasLastError() and s/virHasLastError/virGetLastErrorCode/g
* replaced in missed files: virmodule.c and virnetlibsshsession.c
* better split of patches

[1] https://www.redhat.com/archives/libvir-list/2018-May/msg00259.html

ramyelkest (3):
  util: cleanup: using virGetLastErrorMessage instead of err->message
  util: added virGetLastErrorCode/Domain
  all: replacing virGetLastError with virGetLastErrorCode where we can

 include/libvirt/virterror.h     |  2 ++
 src/libvirt_public.syms         |  6 ++++++
 src/locking/lock_driver_lockd.c |  3 +--
 src/lxc/lxc_controller.c        |  4 +---
 src/qemu/qemu_agent.c           |  3 +--
 src/qemu/qemu_conf.c            |  3 +--
 src/qemu/qemu_domain.c          |  2 +-
 src/qemu/qemu_driver.c          | 12 ++++++------
 src/qemu/qemu_hotplug.c         |  2 +-
 src/qemu/qemu_migration.c       |  4 ++--
 src/qemu/qemu_monitor.c         |  5 ++---
 src/qemu/qemu_monitor_json.c    |  2 +-
 src/qemu/qemu_process.c         |  4 ++--
 src/remote/remote_driver.c      |  3 +--
 src/rpc/virnetclient.c          |  2 +-
 src/rpc/virnetlibsshsession.c   |  4 +---
 src/util/virerror.c             | 42 +++++++++++++++++++++++++++++++++++++++++
 src/util/virfilecache.c         |  3 +--
 src/util/virmodule.c            |  3 +--
 src/util/virxml.c               |  4 ++--
 tests/commandtest.c             |  2 +-
 tests/testutils.c               |  6 ++----
 tests/virhostcputest.c          |  2 +-
 tests/virstoragetest.c          |  8 ++++----
 tools/virsh-domain-monitor.c    |  7 +++----
 tools/virsh-domain.c            |  4 +---
 tools/virsh-util.c              |  3 +--
 tools/vsh.c                     |  2 +-
 28 files changed, 90 insertions(+), 57 deletions(-)

-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/3] adding virGetLastErrorCode/Domain to paritally replace virGetLastError

Posted by Erik Skultety 5 years, 11 months ago

On Sat, May 05, 2018 at 01:04:18PM +0100, ramyelkest wrote:
> Changes from v1[1]:
>
> * removed virHasLastError() and s/virHasLastError/virGetLastErrorCode/g
> * replaced in missed files: virmodule.c and virnetlibsshsession.c
> * better split of patches
>
> [1] https://www.redhat.com/archives/libvir-list/2018-May/msg00259.html
>
> ramyelkest (3):
>   util: cleanup: using virGetLastErrorMessage instead of err->message
>   util: added virGetLastErrorCode/Domain
>   all: replacing virGetLastError with virGetLastErrorCode where we can

I suggested some minor adjustments to your patches without the need for a v3,
so let me know if you agree and I'll merge the series.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list