[v1] guests: Make rpcgen mapping more future-proof

[libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof

Posted by Andrea Bolognani 6 years, 3 months ago

Since whatever is in Fedora Rawhide will end up in future Fedora
releases, it makes sense to use the newer package as default and
override it for existing releases (as well as CentOS), so that
no tweaking will be needed when Fedora 28 and later are added to
the CI setup.

Suggested-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/vars/mappings.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index b79757e..0b32f90 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -606,8 +606,10 @@ mappings:
 
   rpcgen:
     deb: libc-dev-bin
-    rpm: glibc-common
-    FedoraRawhide: glibc-rpcgen
+    rpm: glibc-rpcgen
+    CentOS: glibc-common
+    Fedora26: glibc-common
+    Fedora27: glibc-common
     FreeBSD:
 
   rpmbuild:
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof

Posted by Daniel P. Berrange 6 years, 3 months ago

On Fri, Jan 12, 2018 at 01:31:22PM +0100, Andrea Bolognani wrote:
> Since whatever is in Fedora Rawhide will end up in future Fedora
> releases, it makes sense to use the newer package as default and
> override it for existing releases (as well as CentOS), so that
> no tweaking will be needed when Fedora 28 and later are added to
> the CI setup.
> 
> Suggested-by: Peter Krempa <pkrempa@redhat.com>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/vars/mappings.yml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
> index b79757e..0b32f90 100644
> --- a/guests/vars/mappings.yml
> +++ b/guests/vars/mappings.yml
> @@ -606,8 +606,10 @@ mappings:
>  
>    rpcgen:
>      deb: libc-dev-bin
> -    rpm: glibc-common
> -    FedoraRawhide: glibc-rpcgen
> +    rpm: glibc-rpcgen

You shouldn't refer to glibc-rpcgen - use the name 'rpcgen' which
is a virtual provide, because existance of glibc-rpcgen is a
temporary hack


> +    CentOS: glibc-common
> +    Fedora26: glibc-common
> +    Fedora27: glibc-common
>      FreeBSD:

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof

Posted by Andrea Bolognani 6 years, 3 months ago

On Fri, 2018-01-12 at 13:17 +0000, Daniel P. Berrange wrote:
> >    rpcgen:
> >      deb: libc-dev-bin
> > -    rpm: glibc-common
> > -    FedoraRawhide: glibc-rpcgen
> > +    rpm: glibc-rpcgen
> 
> You shouldn't refer to glibc-rpcgen - use the name 'rpcgen' which
> is a virtual provide, because existance of glibc-rpcgen is a
> temporary hack

Makes sense, I'll change it.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list