From nobody Sat May 4 09:54:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1514919165248120.31439724400695; Tue, 2 Jan 2018 10:52:45 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 887264900E; Tue, 2 Jan 2018 18:52:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C81135D964; Tue, 2 Jan 2018 18:52:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3D106180474A; Tue, 2 Jan 2018 18:52:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w02IqZpq020083 for ; Tue, 2 Jan 2018 13:52:35 -0500 Received: by smtp.corp.redhat.com (Postfix) id B187E171BE; Tue, 2 Jan 2018 18:52:35 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABE775C3F8 for ; Tue, 2 Jan 2018 18:52:32 +0000 (UTC) Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EB687E420 for ; Tue, 2 Jan 2018 18:52:31 +0000 (UTC) Received: by mail-qt0-f194.google.com with SMTP id w10so63682461qtb.10 for ; Tue, 02 Jan 2018 10:52:31 -0800 (PST) Received: from localhost.localdomain ([177.188.108.93]) by smtp.googlemail.com with ESMTPSA id q52sm29451610qtc.16.2018.01.02.10.52.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 Jan 2018 10:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=hVxi/bx3GRQPsBdEyYu+HcfZ4DdR/FhqlFQOkIFXoNQ=; b=BSpPoVuLtVI96pwP0GWc+qV6brRVNypVRzspTU41Qvu1SwyJKgKpAO5EMjLwsWRkhk n0QVldO924GgK3AqbeDJ0jtY9+1qjkgU5W+5fqCr5d+VSVVwh2tIN6FUuIfH+9L+AVk1 sFNj2V0Ccm2oZqlTvR5fZ/YKKNbMnKhPQaFvMJk5cFINe6Kunbz+Tvfekc4Q8sKksR7f lnH+a0LqDr4H/iKZxcL5iWVT8toGLxcLfdeBnyAH2swGpOxWgeAtV8zXptzD9fD6XZc6 oz+TBubu6u6FdFXZc/yuwIRIttv1h2rT8sjzxwaBwpN8E73D3UN/bdhVOlCdsorOgC9S BX3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=hVxi/bx3GRQPsBdEyYu+HcfZ4DdR/FhqlFQOkIFXoNQ=; b=XbdPdc2NnNoI1/ET2eeO67N+I2kPuRj6pqVj7e6RPcpwbOInQKbRNlasa2iPgZFO7Q 1pURhjNjE/KHWa2idNm36wyY1Ls7cYiiewGZ4kchxGWcB0lIqFr8ZaQ58NhUt/Vof2xZ LM7YBK3HkzGHaZSEdWlVY/SuggyK1MRA/FOJ2UBU7RRM+moutO3fCJ21sS6UJB9bajup eLMct6UQzjxZJMlUiuCOS/DoeK7QW9Pe2LBd4uZke0WEeHzHYSAwn7jm18kKNM2tDRjy 6tStkzX/OSCULNBkDdkczm6VPP5k3EYLeAaMdj5U06FUlv0e1TcOlJyXtzF1V/CSww0M I1uA== X-Gm-Message-State: AKGB3mJBAjGlKWO8OWAg1KCzCFHHPbIcMZrBtILVBFjm8Qiz54mdgh7r v5gmGByb4Trrffj2tnLr2bT5pQ== X-Google-Smtp-Source: ACJfBous0P+QpNYKiantDhRgRYphlhPy6k9eCFEg/3AHgJfATr7ltwv0/a15Q1u7dE8xhTWuPwW2FA== X-Received: by 10.237.59.247 with SMTP id s52mr57609597qte.139.1514919150223; Tue, 02 Jan 2018 10:52:30 -0800 (PST) From: Julio Faracco To: libvir-list@redhat.com Date: Tue, 2 Jan 2018 16:52:20 -0200 Message-Id: <1514919140-20375-1-git-send-email-jcfaracco@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 02 Jan 2018 18:52:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 02 Jan 2018 18:52:31 +0000 (UTC) for IP:'209.85.216.194' DOMAIN:'mail-qt0-f194.google.com' HELO:'mail-qt0-f194.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 209.85.216.194 mail-qt0-f194.google.com 209.85.216.194 mail-qt0-f194.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] storage: Fixing missing 'backingStore' tag from volume XML dumps. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 02 Jan 2018 18:52:43 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" After commit a693fdb 'vol-dumpxml' missed the ability to show backingStore information. This commit adds a volume type for files that fixes this problem. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D1529663 Signed-off-by: Julio Faracco --- src/storage/storage_util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 899a557..9e1b63a 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -1957,6 +1957,8 @@ virStorageBackendUpdateVolTargetInfoFD(virStorageSour= cePtr target, target->timestamps->ctime =3D get_stat_ctime(sb); target->timestamps->mtime =3D get_stat_mtime(sb); =20 + target->type =3D VIR_STORAGE_TYPE_FILE; + VIR_FREE(target->perms->label); =20 #if WITH_SELINUX --=20 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list