[libvirt] [PATCH] virsh: domifstat: clarify description of --help option

ZhiPeng Lu posted 1 patch 6 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1510989717-4772-1-git-send-email-lu.zhipeng@zte.com.cn
tools/virsh-domain-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] virsh: domifstat: clarify description of --help option
Posted by ZhiPeng Lu 6 years, 4 months ago
<interface-device> can be the interface target by
name or MAC address. So clarify description of --help option

Signed-off-by:ZhiPeng Lu <lu.zhipeng@zte.com.cn>
---
 tools/virsh-domain-monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
index 960fd37..4e8fc46 100644
--- a/tools/virsh-domain-monitor.c
+++ b/tools/virsh-domain-monitor.c
@@ -995,7 +995,7 @@ static const vshCmdOptDef opts_domifstat[] = {
     {.name = "interface",
      .type = VSH_OT_DATA,
      .flags = VSH_OFLAG_REQ,
-     .help = N_("interface device")
+     .help = N_("interface device (MAC Address)")
     },
     {.name = NULL}
 };
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] virsh: domifstat: clarify description of --help option
Posted by Erik Skultety 6 years, 4 months ago
On Sat, Nov 18, 2017 at 03:21:57PM +0800, ZhiPeng Lu wrote:
> <interface-device> can be the interface target by
> name or MAC address. So clarify description of --help option
>
> Signed-off-by:ZhiPeng Lu <lu.zhipeng@zte.com.cn>
> ---
>  tools/virsh-domain-monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
> index 960fd37..4e8fc46 100644
> --- a/tools/virsh-domain-monitor.c
> +++ b/tools/virsh-domain-monitor.c
> @@ -995,7 +995,7 @@ static const vshCmdOptDef opts_domifstat[] = {
>      {.name = "interface",
>       .type = VSH_OT_DATA,
>       .flags = VSH_OFLAG_REQ,
> -     .help = N_("interface device")
> +     .help = N_("interface device (MAC Address)")
>      },
>      {.name = NULL}

In that case I'd prefer to be explicit about using a name as well - I adjusted
that along with the commit message and pushed.

Thanks,
Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list