From nobody Mon Apr 29 09:15:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1508427327461669.0946092292959; Thu, 19 Oct 2017 08:35:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3B51C641DB; Thu, 19 Oct 2017 15:35:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 175F81821F; Thu, 19 Oct 2017 15:35:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D67893FAEF; Thu, 19 Oct 2017 15:35:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v9JFZODu013317 for ; Thu, 19 Oct 2017 11:35:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id 59713BA23C; Thu, 19 Oct 2017 15:35:24 +0000 (UTC) Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 502E6BA224 for ; Thu, 19 Oct 2017 15:35:21 +0000 (UTC) Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A07C7D714E for ; Thu, 19 Oct 2017 15:35:15 +0000 (UTC) Received: by mail-qk0-f193.google.com with SMTP id l194so10830448qke.13 for ; Thu, 19 Oct 2017 08:35:15 -0700 (PDT) Received: from localhost.localdomain ([191.190.188.58]) by smtp.googlemail.com with ESMTPSA id n31sm5444238qtf.62.2017.10.19.08.35.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Oct 2017 08:35:13 -0700 (PDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3B51C641DB Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3B51C641DB Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="afut+GB8" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A07C7D714E Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jcfaracco@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A07C7D714E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=2+ViiCmTN1rIrYtsNx8FwFHWEyYHc6XX46cGRkHW0YY=; b=afut+GB8Hm9bY91H5Z2Vf7TGzogJ5HGjJ3Df/rhY5nSWA9ukj12RpM7Y4WTm3xzUrz hLa63SaWFaKznXJRQpLR0rLCdhA+sTX95TNpIKQnmzwU3pn3ywgQfXppdvVmZRb34p2n ZpQ0iOiiB1NTBwwWszhwwpSj907q4Hv6PoIOllpSPooacZ2NxhDDaEZI7R6he6gF3lbP Mz5wPuIFoWa8pmimy+ujKNUZdqnTTjHwJsMd5mgdfjMIUGlDxXE1SDUyVstsg09fxF6/ jPSfeqMsuHoAOvRk72NUl09ZBGIMv27rZQRWU3dtxRPjcgNKxUGNxy4xnTexwmvTjznl optA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=2+ViiCmTN1rIrYtsNx8FwFHWEyYHc6XX46cGRkHW0YY=; b=iwHKx25V6a02MPr0SYpIiOwM069v8sb3YT0cHnV1OHaNzqUY8Zck6pIsYtuOWYRpok liGXWtiU8DUEeQKIGUzqJ6P6LwATzjYunBdTj9WmvUXzP/PY240DDMK4OjR6EMptrdjK 9JMj7ATarY0YJT7beM4yxi5CjnHkHLI9rkzD0mww6IJBfM/Iq7axC4hgBM/qznZQ66TN eQhfVL/8ZJYwrySXRWXeizje+ssYCgMAICG4RnUGRvYbzDpJJDAaTPWvkxJC/7eqXqC4 RWJpFsGo71MKcPWnQkEG5jelcIM33VBzANDrbl4rsHYQewxwPCModj8VDJAiJciZ7GPB v0Ew== X-Gm-Message-State: AMCzsaV4lTGDZGQGS/YZhtPfEWr6ISQt+7crQNQCgczYv/J5h1/SmhvN xGsDXnmlFvwvnmF/D+cNOEBoPg== X-Google-Smtp-Source: ABhQp+SDxN643ixOiNpXOeecvvbJHefyueVZpecgxKZlC6Y1eR7nFqIT9HzEzIWVF9vGRgkhq5/aDg== X-Received: by 10.55.70.67 with SMTP id t64mr2539683qka.103.1508427314534; Thu, 19 Oct 2017 08:35:14 -0700 (PDT) From: Julio Faracco To: libvir-list@redhat.com Date: Thu, 19 Oct 2017 13:35:03 -0200 Message-Id: <1508427303-14536-1-git-send-email-jcfaracco@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 19 Oct 2017 15:35:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 19 Oct 2017 15:35:15 +0000 (UTC) for IP:'209.85.220.193' DOMAIN:'mail-qk0-f193.google.com' HELO:'mail-qk0-f193.google.com' FROM:'jcfaracco@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.37 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 209.85.220.193 mail-qk0-f193.google.com 209.85.220.193 mail-qk0-f193.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.38 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] util: Missing 'removeTimeoutImpl' check variable inside virEventRegisterImpl() function. X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 19 Oct 2017 15:35:26 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The function virEventRegisterImpl() checks the attempt to replace the registered events. But there is a duplicate variable inside the IF statemen= t. The variable 'removeHandleImpl' was wrongly repeated. One of them needs to = be replaced by 'removeTimeoutImpl'. Signed-off-by: Julio Faracco Reviewed-by: Andrea Bolognani Reviewed-by: John Ferlan --- src/util/virevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virevent.c b/src/util/virevent.c index 51d8714..87069e3 100644 --- a/src/util/virevent.c +++ b/src/util/virevent.c @@ -241,7 +241,7 @@ void virEventRegisterImpl(virEventAddHandleFunc addHand= le, addTimeout, updateTimeout, removeTimeout); =20 if (addHandleImpl || updateHandleImpl || removeHandleImpl || - addTimeoutImpl || updateTimeoutImpl || removeHandleImpl) { + addTimeoutImpl || updateTimeoutImpl || removeTimeoutImpl) { VIR_WARN("Ignoring attempt to replace registered event loop"); return; } --=20 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list