qemu: Remove redundant code in qemuParseCommandLineDisk

[libvirt] [PATCH] qemu: Remove redundant code in qemuParseCommandLineDisk

Kothapally Madhu Pavan posted 1 patch 6 years, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1507454693-133991-1-git-send-email-kmp@linux.vnet.ibm.com

src/qemu/qemu_parse_command.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH] qemu: Remove redundant code in qemuParseCommandLineDisk

Posted by Kothapally Madhu Pavan 6 years, 6 months ago

Signed-off-by: Kothapally Madhu Pavan <kmp@linux.vnet.ibm.com>
---
 src/qemu/qemu_parse_command.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
index 37e1149..7c409b0 100644
--- a/src/qemu/qemu_parse_command.c
+++ b/src/qemu/qemu_parse_command.c
@@ -945,9 +945,7 @@ qemuParseCommandLineDisk(virDomainXMLOptionPtr xmlopt,
     if (virDomainDiskDefAssignAddress(xmlopt, def, dom) < 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("invalid device name '%s'"), def->dst);
-        virDomainDiskDefFree(def);
-        def = NULL;
-        goto cleanup;
+        goto error;
     }
 
  cleanup:
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Remove redundant code in qemuParseCommandLineDisk

Posted by Ján Tomko 6 years, 6 months ago

On Sun, Oct 08, 2017 at 02:54:53PM +0530, Kothapally Madhu Pavan wrote:
>Signed-off-by: Kothapally Madhu Pavan <kmp@linux.vnet.ibm.com>
>---
> src/qemu/qemu_parse_command.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

ACK and pushed.

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list