virsh: delete "id" for domrename OPTIONS

[libvirt] [PATCH] virsh: delete "id" for domrename OPTIONS

Yanqiu Zhang posted 1 patch 6 years, 7 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1505116430-112353-1-git-send-email-yanqzhan@redhat.com

tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] virsh: delete "id" for domrename OPTIONS

Posted by Yanqiu Zhang 6 years, 7 months ago

"domrename" is used to rename an inactive domain, should not use
 id for the --domain OPTION.
---
 tools/virsh-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f235c66..84c8dcc 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10151,7 +10151,7 @@ static const vshCmdInfo info_domrename[] = {
 };
 
 static const vshCmdOptDef opts_domrename[] = {
-    VIRSH_COMMON_OPT_DOMAIN_FULL,
+    VIRSH_COMMON_OPT_DOMAIN(N_("domain name or uuid")),
     {.name = "new-name",
      .type = VSH_OT_DATA,
      .flags = VSH_OFLAG_REQ,
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: delete "id" for domrename OPTIONS

Posted by Martin Kletzander 6 years, 7 months ago

On Mon, Sep 11, 2017 at 03:53:50AM -0400, Yanqiu Zhang wrote:
>"domrename" is used to rename an inactive domain, should not use
> id for the --domain OPTION.
>---
> tools/virsh-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

See
https://www.redhat.com/archives/libvir-list/2017-September/msg00213.html
for NACK details.

>diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
>index f235c66..84c8dcc 100644
>--- a/tools/virsh-domain.c
>+++ b/tools/virsh-domain.c
>@@ -10151,7 +10151,7 @@ static const vshCmdInfo info_domrename[] = {
> };
>
> static const vshCmdOptDef opts_domrename[] = {
>-    VIRSH_COMMON_OPT_DOMAIN_FULL,
>+    VIRSH_COMMON_OPT_DOMAIN(N_("domain name or uuid")),
>     {.name = "new-name",
>      .type = VSH_OT_DATA,
>      .flags = VSH_OFLAG_REQ,
>--
>1.8.3.1
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list