So that you can see nice report on migration:

"error: operation failed: migration of disk sda failed: No space left on device"

diff from v2:
============
1. split into 2 patches
2. change formal documentation where it is present accordingly
3. add variable initialization for safety

Nikolay Shirokovskiy (2):
  qemu: prepare blockjob complete event error usage
  qemu: report drive mirror errors on migration

 src/qemu/qemu_blockjob.c     | 14 +++++++++--
 src/qemu/qemu_blockjob.h     |  3 ++-
 src/qemu/qemu_domain.c       |  1 +
 src/qemu/qemu_domain.h       |  1 +
 src/qemu/qemu_driver.c       |  4 ++--
 src/qemu/qemu_migration.c    | 55 +++++++++++++++++++++++++++++++-------------
 src/qemu/qemu_monitor.c      |  5 ++--
 src/qemu/qemu_monitor.h      |  4 +++-
 src/qemu/qemu_monitor_json.c |  4 +++-
 src/qemu/qemu_process.c      |  4 ++++
 10 files changed, 70 insertions(+), 25 deletions(-)

-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

ping

On 08.09.2017 10:59, Nikolay Shirokovskiy wrote:
> So that you can see nice report on migration:
> 
> "error: operation failed: migration of disk sda failed: No space left on device"
> 
> diff from v2:
> ============
> 1. split into 2 patches
> 2. change formal documentation where it is present accordingly
> 3. add variable initialization for safety
> 
> Nikolay Shirokovskiy (2):
>   qemu: prepare blockjob complete event error usage
>   qemu: report drive mirror errors on migration
> 
>  src/qemu/qemu_blockjob.c     | 14 +++++++++--
>  src/qemu/qemu_blockjob.h     |  3 ++-
>  src/qemu/qemu_domain.c       |  1 +
>  src/qemu/qemu_domain.h       |  1 +
>  src/qemu/qemu_driver.c       |  4 ++--
>  src/qemu/qemu_migration.c    | 55 +++++++++++++++++++++++++++++++-------------
>  src/qemu/qemu_monitor.c      |  5 ++--
>  src/qemu/qemu_monitor.h      |  4 +++-
>  src/qemu/qemu_monitor_json.c |  4 +++-
>  src/qemu/qemu_process.c      |  4 ++++
>  10 files changed, 70 insertions(+), 25 deletions(-)
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Wed, Oct 25, 2017 at 09:57:58 +0300, Nikolay Shirokovskiy wrote:
> ping

Hi,

Unfortunately the second patch is no longer applicable on the current
master. It's definitely our fault we didn't review your patches in time,
but it sometimes happens when people get drowned in other work. Don't
hesitate to ping a lot earlier than after more than a month if you get
no reviews to attract attention to your patches and reduce possible
conflicts with the work of others.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 27.10.2017 13:24, Jiri Denemark wrote:
> On Wed, Oct 25, 2017 at 09:57:58 +0300, Nikolay Shirokovskiy wrote:
>> ping
> 
> Hi,
> 
> Unfortunately the second patch is no longer applicable on the current
> master. It's definitely our fault we didn't review your patches in time,
> but it sometimes happens when people get drowned in other work. Don't
> hesitate to ping a lot earlier than after more than a month if you get
> no reviews to attract attention to your patches and reduce possible
> conflicts with the work of others.
> 
> Jirka
> 

Ok. Thanx for this advice! I do hesitate really.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list