domain: add limit description of parameter 'size' for blockPeek and memoryPeek

[libvirt] [PATCH] domain: add limit description of parameter 'size' for blockPeek and memoryPeek

Posted by Chen Hanxiao 6 years, 7 months ago

From: Chen Hanxiao <chenhanxiao@gmail.com>

  We had 'size' limits for virDomainMemoryPeek
  and virDomainBlockPeek by macro
  REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX and
  REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX.

  The descriptions of the two functions only emphasized
  RPC buffer size.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
---
 src/libvirt-domain.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index ca5a153..646ce72 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -5802,6 +5802,9 @@ virDomainMemoryStats(virDomainPtr dom, virDomainMemoryStatPtr stats,
  * within the device or file.  'size' may be 0 to test if the
  * call would succeed.
  *
+ * 'size' should be <= 1048576(1M). Since v1.0.5, 'size' had been
+ * raised up to 4194304(4M).
+ *
  * 'buffer' is the return buffer and must be at least 'size' bytes.
  *
  * NB. The remote driver imposes a 64K byte limit on 'size'.
@@ -5941,6 +5944,9 @@ virDomainBlockResize(virDomainPtr dom,
  * 'buffer' is the return buffer and must be at least 'size' bytes.
  * 'size' may be 0 to test if the call would succeed.
  *
+ * 'size' should be <= 1048576(1M). Since v1.0.5, 'size' had been
+ * raised up to 4194304(4M).
+ *
  * NB. The remote driver imposes a 64K byte limit on 'size'.
  * For your program to be able to work reliably over a remote
  * connection you should split large requests to <= 65536 bytes.
-- 
2.7.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] domain: add limit description of parameter 'size' for blockPeek and memoryPeek

Posted by Chen Hanxiao 6 years, 7 months ago

At 2017-09-05 22:01:56, "Chen Hanxiao" <chen_han_xiao@126.com> wrote:
>From: Chen Hanxiao <chenhanxiao@gmail.com>
>
>  We had 'size' limits for virDomainMemoryPeek
>  and virDomainBlockPeek by macro
>  REMOTE_DOMAIN_BLOCK_PEEK_BUFFER_MAX and
>  REMOTE_DOMAIN_MEMORY_PEEK_BUFFER_MAX.
>
>  The descriptions of the two functions only emphasized
>  RPC buffer size.
>

ping?

Regards,
- Chen

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list