[v1] phyp: Fix memory leak in phypUUIDTable_Push

[libvirt] [PATCH RESEND] phyp: Fix memory leak in phypUUIDTable_Push

ZhiPeng Lu posted 1 patch 6 years, 9 months ago

Diff against v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1500422556-15545-1-git-send-email-lu.zhipeng@zte.com.cn

src/phyp/phyp_driver.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[libvirt] [PATCH RESEND] phyp: Fix memory leak in phypUUIDTable_Push

Posted by ZhiPeng Lu 6 years, 9 months ago

@remote_file, allocated by virAsprintf, was not freed and leaked.

Signed-off-by: Zhipeng Lu <lu.zhipeng@zte.com.cn>
---
 src/phyp/phyp_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
index 9121581..662e2f7 100644
--- a/src/phyp/phyp_driver.c
+++ b/src/phyp/phyp_driver.c
@@ -568,6 +568,7 @@ phypUUIDTable_Push(virConnectPtr conn)
     ret = 0;
 
  cleanup:
+    VIR_FREE(remote_file);
     if (channel) {
         libssh2_channel_send_eof(channel);
         libssh2_channel_wait_eof(channel);
-- 
1.8.3.1


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RESEND] phyp: Fix memory leak in phypUUIDTable_Push

Posted by Michal Privoznik 6 years, 9 months ago

On 07/19/2017 02:02 AM, ZhiPeng Lu wrote:
> @remote_file, allocated by virAsprintf, was not freed and leaked.
> 
> Signed-off-by: Zhipeng Lu <lu.zhipeng@zte.com.cn>
> ---
>  src/phyp/phyp_driver.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
> index 9121581..662e2f7 100644
> --- a/src/phyp/phyp_driver.c
> +++ b/src/phyp/phyp_driver.c
> @@ -568,6 +568,7 @@ phypUUIDTable_Push(virConnectPtr conn)
>      ret = 0;
>  
>   cleanup:
> +    VIR_FREE(remote_file);
>      if (channel) {
>          libssh2_channel_send_eof(channel);
>          libssh2_channel_wait_eof(channel);
> 

ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list