[v1] Fix documentation errors about the path of conf files

[libvirt] [PATCH] Fix documentation errors about the path of conf files

Posted by Lily Zhu 6 years, 10 months ago

The conf files, for example, libvirtd.conf, virtlockd.conf and
virtlogd.conf, should be located under the directory
"/etc/libvirt", rather than "/etc".

Signed-off-by: Lily Zhu <lizhu@redhat.com>
---
 daemon/libvirtd.pod       | 2 +-
 src/locking/virtlockd.pod | 2 +-
 src/logging/virtlogd.pod  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/daemon/libvirtd.pod b/daemon/libvirtd.pod
index 3b819a2..1bca509 100644
--- a/daemon/libvirtd.pod
+++ b/daemon/libvirtd.pod
@@ -81,7 +81,7 @@ On receipt of B<SIGHUP> libvirtd will reload its configuration.
 
 =over
 
-=item F<SYSCONFDIR/libvirtd.conf>
+=item F<SYSCONFDIR/libvirt/libvirtd.conf>
 
 The default configuration file used by libvirtd, unless overridden on the
 command line using the B<-f>|B<--config> option.
diff --git a/src/locking/virtlockd.pod b/src/locking/virtlockd.pod
index a3bb268..2e155f8 100644
--- a/src/locking/virtlockd.pod
+++ b/src/locking/virtlockd.pod
@@ -67,7 +67,7 @@ upgrades of the virtlockd service.
 
 =over
 
-=item F<SYSCONFDIR/virtlockd.conf>
+=item F<SYSCONFDIR/libvirt/virtlockd.conf>
 
 The default configuration file used by virtlockd, unless overridden on the
 command line using the B<-f>|B<--config> option.
diff --git a/src/logging/virtlogd.pod b/src/logging/virtlogd.pod
index 7e55c9e..5fc20db 100644
--- a/src/logging/virtlogd.pod
+++ b/src/logging/virtlogd.pod
@@ -67,7 +67,7 @@ upgrades of the virtlogd service.
 
 =over
 
-=item F<SYSCONFDIR/virtlogd.conf>
+=item F<SYSCONFDIR/libvirt/virtlogd.conf>
 
 The default configuration file used by virtlogd, unless overridden on the
 command line using the B<-f>|B<--config> option.
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix documentation errors about the path of conf files

Posted by Andrea Bolognani 6 years, 10 months ago

On Wed, 2017-06-21 at 10:47 +0800, Lily Zhu wrote:
> The conf files, for example, libvirtd.conf, virtlockd.conf and
> virtlogd.conf, should be located under the directory
> "/etc/libvirt", rather than "/etc".
> 
> Signed-off-by: Lily Zhu <lizhu@redhat.com>
> ---
>  daemon/libvirtd.pod       | 2 +-
>  src/locking/virtlockd.pod | 2 +-
>  src/logging/virtlogd.pod  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/daemon/libvirtd.pod b/daemon/libvirtd.pod
> index 3b819a2..1bca509 100644
> --- a/daemon/libvirtd.pod
> +++ b/daemon/libvirtd.pod
> @@ -81,7 +81,7 @@ On receipt of B<SIGHUP> libvirtd will reload its configuration.
>  
>  =over
>  
> -=item F<SYSCONFDIR/libvirtd.conf>
> +=item F<SYSCONFDIR/libvirt/libvirtd.conf>

Good catch :)

However, further down in each of the files you can find
something along the lines of

  =item F<$XDG_CONFIG_HOME/libvirtd.conf>

which suffers from the same issue. Would you mind sending
a v2 that takes care of that as well?

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list