datatypes: removing unnecessary return statement.

[libvirt] [PATCH] datatypes: removing unnecessary return statement.

Julio Faracco posted 1 patch 6 years, 11 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1495072403-21964-1-git-send-email-jcfaracco@gmail.com

src/datatypes.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] datatypes: removing unnecessary return statement.

Posted by Julio Faracco 6 years, 11 months ago

There is a wrong 'return' statement after a 'goto' statement inside the
function virConnectCloseCallbackDataRegister(). This commit only removes
the 'return'.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
---
 src/datatypes.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/datatypes.c b/src/datatypes.c
index 59ba956..46414ae 100644
--- a/src/datatypes.c
+++ b/src/datatypes.c
@@ -193,7 +193,6 @@ void virConnectCloseCallbackDataRegister(virConnectCloseCallbackDataPtr closeDat
         VIR_WARN("Attempt to register callback on armed"
                  " close callback object %p", closeData);
         goto cleanup;
-        return;
     }
 
     closeData->conn = virObjectRef(conn);
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] datatypes: removing unnecessary return statement.

Posted by John Ferlan 6 years, 11 months ago


On 05/17/2017 09:53 PM, Julio Faracco wrote:
> There is a wrong 'return' statement after a 'goto' statement inside the
> function virConnectCloseCallbackDataRegister(). This commit only removes
> the 'return'.
> 
> Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
> ---
>  src/datatypes.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

(and pushed)

Tks -

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list