On 04/25/2017 08:16 AM, ZhiPeng Lu wrote:
> it should be a comparison of modes between new and old devices. So
> the argument of the second virDomainNetGetActualDirectMode should be
> newdev.
>
> Signed-off-by: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
> ---
> src/qemu/qemu_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index 120bcdc..eec99af 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -3273,7 +3273,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
>
> if (STRNEQ_NULLABLE(virDomainNetGetActualDirectDev(olddev),
> virDomainNetGetActualDirectDev(newdev)) ||
> - virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(olddev) ||
> + virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(newdev) ||
> !virNetDevVPortProfileEqual(virDomainNetGetActualVirtPortProfile(olddev),
> virDomainNetGetActualVirtPortProfile(newdev)) ||
> !virNetDevVlanEqual(virDomainNetGetActualVlan(olddev),
>
Wow, nice catch. ACKed and pushed.
Congratulations on your first libvirt contribution!
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list