[libvirt] [RFC PATCH] Drop autobuild.sh

Andrea Bolognani posted 1 patch 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/1492096016-30642-1-git-send-email-abologna@redhat.com
autobuild.sh | 122 -----------------------------------------------------------
1 file changed, 122 deletions(-)
delete mode 100755 autobuild.sh
[libvirt] [RFC PATCH] Drop autobuild.sh
Posted by Andrea Bolognani 7 years ago
The Test-AutoBuild project, that this script is supposed to
be used with, hasn't seen any activity in ~6 years; libvirt's
own CI is running on Jenkins with a completely independent
setup that doesn't use the script at all.
---
 autobuild.sh | 122 -----------------------------------------------------------
 1 file changed, 122 deletions(-)
 delete mode 100755 autobuild.sh

diff --git a/autobuild.sh b/autobuild.sh
deleted file mode 100755
index 2143479..0000000
--- a/autobuild.sh
+++ /dev/null
@@ -1,122 +0,0 @@
-#!/bin/sh
-
-set -e
-set -v
-
-# Make things clean.
-
-test -n "$1" && RESULTS=$1 || RESULTS=results.log
-: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder}
-
-# If run under the autobuilder, we must use --nodeps with rpmbuild;
-# but this can lead to odd error diagnosis for normal development.
-nodeps=
-if test "${AUTOBUILD_COUNTER+set}"; then
-  nodeps=--nodeps
-fi
-
-test -f Makefile && make -k distclean || :
-rm -rf coverage
-
-rm -rf build
-mkdir build
-cd build
-
-# Run with options not normally exercised by the rpm build, for
-# more complete code coverage.
-../autogen.sh --prefix="$AUTOBUILD_INSTALL_ROOT" \
-  --enable-expensive-tests \
-  --enable-test-coverage \
-  --disable-nls \
-  --enable-werror \
-  --enable-static
-
-# If the MAKEFLAGS envvar does not yet include a -j option,
-# add -jN where N depends on the number of processors.
-case $MAKEFLAGS in
-  *-j*) ;;
-  *) n=$(getconf _NPROCESSORS_ONLN 2> /dev/null)
-    test "$n" -gt 0 || n=1
-    n=$(expr $n + 1)
-    MAKEFLAGS="$MAKEFLAGS -j$n"
-    export MAKEFLAGS
-    ;;
-esac
-
-make
-make install
-
-# set -o pipefail is a bashism; this use of exec is the POSIX alternative
-exec 3>&1
-st=$(
-  exec 4>&1 >&3
-  { make check syntax-check 2>&1 3>&- 4>&-; echo $? >&4; } | tee "$RESULTS"
-)
-exec 3>&-
-test "$st" = 0
-test -x /usr/bin/lcov && make cov
-
-rm -f *.tar.xz
-make dist
-
-if test -n "$AUTOBUILD_COUNTER" ; then
-  EXTRA_RELEASE=".auto$AUTOBUILD_COUNTER"
-else
-  NOW=`date +"%s"`
-  EXTRA_RELEASE=".$USER$NOW"
-fi
-
-if test -f /usr/bin/rpmbuild ; then
-  rpmbuild $nodeps \
-     --define "extra_release $EXTRA_RELEASE" \
-     --define "_sourcedir `pwd`" \
-     -ba --clean libvirt.spec
-fi
-
-# Test mingw32 cross-compile
-if test -x /usr/bin/i686-w64-mingw32-gcc ; then
-  make distclean
-
-  PKG_CONFIG_LIBDIR="/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig:/usr/i686-w64-mingw32/sys-root/mingw/share/pkgconfig" \
-  PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
-  CC="i686-w64-mingw32-gcc" \
-  ../configure \
-    --build=$(uname -m)-w64-linux \
-    --host=i686-w64-mingw32 \
-    --prefix="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \
-    --enable-expensive-tests \
-    --enable-werror
-
-  make
-  make install
-
-fi
-
-# Test mingw64 cross-compile
-if test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
-  make distclean
-
-  PKG_CONFIG_LIBDIR="/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig:/usr/x86_64-w64-mingw32/sys-root/mingw/share/pkgconfig" \
-  PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig" \
-  CC="x86_64-w64-mingw32-gcc" \
-  ../configure \
-    --build=$(uname -m)-w64-linux \
-    --host=x86_64-w64-mingw32 \
-    --prefix="$AUTOBUILD_INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw" \
-    --enable-expensive-tests \
-    --enable-werror
-
-  make
-  make install
-
-fi
-
-
-if test -x /usr/bin/i686-w64-mingw32-gcc && test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
-  if test -f /usr/bin/rpmbuild ; then
-    rpmbuild $nodeps \
-       --define "extra_release $EXTRA_RELEASE" \
-       --define "_sourcedir `pwd`" \
-       -ba --clean mingw-libvirt.spec
-  fi
-fi
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH] Drop autobuild.sh
Posted by Daniel P. Berrange 7 years ago
On Thu, Apr 13, 2017 at 05:06:56PM +0200, Andrea Bolognani wrote:
> The Test-AutoBuild project, that this script is supposed to
> be used with, hasn't seen any activity in ~6 years; libvirt's
> own CI is running on Jenkins with a completely independent
> setup that doesn't use the script at all.
> ---
>  autobuild.sh | 122 -----------------------------------------------------------
>  1 file changed, 122 deletions(-)
>  delete mode 100755 autobuild.sh

ACK,

Test-AutoBuild was my own project, but its been way too long since I had
any time to work on it, so it is effectively dead :-(

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH] Drop autobuild.sh
Posted by Andrea Bolognani 7 years ago
On Thu, 2017-04-13 at 16:36 +0100, Daniel P. Berrange wrote:
> On Thu, Apr 13, 2017 at 05:06:56PM +0200, Andrea Bolognani wrote:
> > 
> > The Test-AutoBuild project, that this script is supposed to
> > be used with, hasn't seen any activity in ~6 years; libvirt's
> > own CI is running on Jenkins with a completely independent
> > setup that doesn't use the script at all.
> > ---
> >  autobuild.sh | 122 -----------------------------------------------------------
> >  1 file changed, 122 deletions(-)
> >  delete mode 100755 autobuild.sh
> 
> ACK,
> 
> Test-AutoBuild was my own project, but its been way too long since I had
> any time to work on it, so it is effectively dead :-(

Pushed with the following hunk squashed in:

diff --git a/Makefile.am b/Makefile.am
index c6324f5..333ec5a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -36,7 +36,6 @@ EXTRA_DIST = \
   libvirt-qemu.pc.in \
   libvirt-lxc.pc.in \
   libvirt-admin.pc.in \
-  autobuild.sh \
   Makefile.nonreentrant \
   autogen.sh \
   cfg.mk \
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list