[libvirt] [PATCH v2 0/7] Memory locking fixes

Andrea Bolognani posted 7 patches 7 years ago
Failed in applying to current master (apply log)
docs/formatdomain.html.in                          |  39 ++++--
src/qemu/qemu_command.c                            |   4 +-
src/qemu/qemu_domain.c                             |  76 ++++------
src/qemu/qemu_domain.h                             |   1 -
src/util/virprocess.c                              |  20 ++-
tests/Makefile.am                                  |   9 ++
.../qemumemlock-pc-hardlimit+hostdev.xml           |  20 +++
.../qemumemlock-pc-hardlimit+locked+hostdev.xml    |  23 ++++
.../qemumemlock-pc-hardlimit+locked.xml            |  17 +++
tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml |  14 ++
tests/qemumemlockdata/qemumemlock-pc-hostdev.xml   |  17 +++
tests/qemumemlockdata/qemumemlock-pc-kvm.xml       |  11 ++
.../qemumemlock-pc-locked+hostdev.xml              |  20 +++
tests/qemumemlockdata/qemumemlock-pc-locked.xml    |  14 ++
tests/qemumemlockdata/qemumemlock-pc-tcg.xml       |  11 ++
.../qemumemlock-pseries-hardlimit+hostdev.xml      |  20 +++
...emumemlock-pseries-hardlimit+locked+hostdev.xml |  23 ++++
.../qemumemlock-pseries-hardlimit+locked.xml       |  17 +++
.../qemumemlock-pseries-hardlimit.xml              |  14 ++
.../qemumemlock-pseries-hostdev.xml                |  17 +++
tests/qemumemlockdata/qemumemlock-pseries-kvm.xml  |  11 ++
.../qemumemlock-pseries-locked+hostdev.xml         |  20 +++
.../qemumemlockdata/qemumemlock-pseries-locked.xml |  14 ++
tests/qemumemlockdata/qemumemlock-pseries-tcg.xml  |  11 ++
tests/qemumemlocktest.c                            | 153 +++++++++++++++++++++
tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml   |   3 -
tests/testutils.c                                  |  27 ++++
tests/testutils.h                                  |   2 +
28 files changed, 556 insertions(+), 72 deletions(-)
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-kvm.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked+hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pc-tcg.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked+hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-kvm.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked+hostdev.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked.xml
create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-tcg.xml
create mode 100644 tests/qemumemlocktest.c
[libvirt] [PATCH v2 0/7] Memory locking fixes
Posted by Andrea Bolognani 7 years ago
Changes from [v1]:

  * exit early from the loop in patch 2;

  * dropped patch 5/8, as it's no longer needed;

  * rewrote tests not to generate QEMU command line;

  * changed documentation slightly.


[v1] https://www.redhat.com/archives/libvir-list/2017-March/msg01089.html

Andrea Bolognani (7):
  Revert "qemu: Forbid <memoryBacking><locked> without
    <memtune><hard_limit>"
  qemu: Remove qemuDomainRequiresMemLock()
  qemu: Fix memory locking limit calculation
  process: Translate "unlimited" correctly
  tests: Introduce virTestCompareToULL()
  tests: Introduce QEMU memory locking limit tests
  docs: Improve documentation related to memory locking

 docs/formatdomain.html.in                          |  39 ++++--
 src/qemu/qemu_command.c                            |   4 +-
 src/qemu/qemu_domain.c                             |  76 ++++------
 src/qemu/qemu_domain.h                             |   1 -
 src/util/virprocess.c                              |  20 ++-
 tests/Makefile.am                                  |   9 ++
 .../qemumemlock-pc-hardlimit+hostdev.xml           |  20 +++
 .../qemumemlock-pc-hardlimit+locked+hostdev.xml    |  23 ++++
 .../qemumemlock-pc-hardlimit+locked.xml            |  17 +++
 tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml |  14 ++
 tests/qemumemlockdata/qemumemlock-pc-hostdev.xml   |  17 +++
 tests/qemumemlockdata/qemumemlock-pc-kvm.xml       |  11 ++
 .../qemumemlock-pc-locked+hostdev.xml              |  20 +++
 tests/qemumemlockdata/qemumemlock-pc-locked.xml    |  14 ++
 tests/qemumemlockdata/qemumemlock-pc-tcg.xml       |  11 ++
 .../qemumemlock-pseries-hardlimit+hostdev.xml      |  20 +++
 ...emumemlock-pseries-hardlimit+locked+hostdev.xml |  23 ++++
 .../qemumemlock-pseries-hardlimit+locked.xml       |  17 +++
 .../qemumemlock-pseries-hardlimit.xml              |  14 ++
 .../qemumemlock-pseries-hostdev.xml                |  17 +++
 tests/qemumemlockdata/qemumemlock-pseries-kvm.xml  |  11 ++
 .../qemumemlock-pseries-locked+hostdev.xml         |  20 +++
 .../qemumemlockdata/qemumemlock-pseries-locked.xml |  14 ++
 tests/qemumemlockdata/qemumemlock-pseries-tcg.xml  |  11 ++
 tests/qemumemlocktest.c                            | 153 +++++++++++++++++++++
 tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml   |   3 -
 tests/testutils.c                                  |  27 ++++
 tests/testutils.h                                  |   2 +
 28 files changed, 556 insertions(+), 72 deletions(-)
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-kvm.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked+hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pc-tcg.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked+hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-kvm.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked+hostdev.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked.xml
 create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-tcg.xml
 create mode 100644 tests/qemumemlocktest.c

-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/7] Memory locking fixes
Posted by Martin Kletzander 7 years ago
On Mon, Mar 27, 2017 at 05:38:52PM +0200, Andrea Bolognani wrote:
>Changes from [v1]:
>
>  * exit early from the loop in patch 2;
>
>  * dropped patch 5/8, as it's no longer needed;
>
>  * rewrote tests not to generate QEMU command line;
>

About that ^^ there's still something to fix, but if you follow my
advice, ACK series.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/7] Memory locking fixes
Posted by Andrea Bolognani 7 years ago
On Mon, 2017-03-27 at 22:16 +0200, Martin Kletzander wrote:
> About that ^^ there's still something to fix, but if you follow my
> advice, ACK series.

Thanks. Pushed on account of the fact that it was ACKed before
the freeze started.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list