From nobody Sat May 4 07:38:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 149009939521379.7078261334027; Tue, 21 Mar 2017 05:29:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3332961D1F; Tue, 21 Mar 2017 12:29:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D0D2D784A6; Tue, 21 Mar 2017 12:29:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A99DA18523C9; Tue, 21 Mar 2017 12:29:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v2LCTnob022075 for ; Tue, 21 Mar 2017 08:29:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8CF017F466; Tue, 21 Mar 2017 12:29:49 +0000 (UTC) Received: from mx1.redhat.com (ext-mx01.extmail.prod.ext.phx2.redhat.com [10.5.110.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAE2560319; Tue, 21 Mar 2017 12:29:47 +0000 (UTC) Received: from m15-114.126.com (m15-114.126.com [220.181.15.114]) by mx1.redhat.com (Postfix) with ESMTP id 6B2217F6D0; Tue, 21 Mar 2017 12:29:44 +0000 (UTC) Received: from localhost.localdomain.localdomain (unknown [58.213.111.46]) by smtp7 (Coremail) with SMTP id DsmowAAngqiXFdFYIOZIGg--.18798S2; Tue, 21 Mar 2017 19:59:27 +0800 (CST) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3332961D1F Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=126.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3332961D1F Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (1024-bit key) header.d=126.com header.i=@126.com header.b="GuaYxPt+" DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B2217F6D0 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=chen_han_xiao@126.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6B2217F6D0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=KeRGFcNqlEz1YtA5DL w9n4znZC7m93lElDsxlS0MiXg=; b=GuaYxPt+OJGhiHYYgINY0nZ2D1U/rA46BF t+b8a2zLAXdObLpUyACNtzoNWgn8KPRvQbavwtaBBM/m3+V1tMpA9AS7iP+HqV9z rA92gueXTq9xDm0AAYIwvvU+W4KPn/huTCHm3h+HtSz6DZwWZ1hf9WdkdxcvmAbt rB2LUG0QM= From: Chen Hanxiao To: libvir-list@redhat.com Date: Tue, 21 Mar 2017 19:58:27 +0800 Message-Id: <1490097507-2063-1-git-send-email-chen_han_xiao@126.com> X-CM-TRANSID: DsmowAAngqiXFdFYIOZIGg--.18798S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GFy5Zr1kXr15KF48Zw15CFg_yoWDCwc_u3 WrGas7A3y5GF1jk3Z5uFsxAry0v34rXr1rKFn8tFWrCa1jyr4ftrW2q39YkrnrWa1xtF93 XF1YgFnak3s7tjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU17GYtUUUUU== X-Originating-IP: [58.213.111.46] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbikh+hrlag2q8a5QAAs+ X-Greylist: Delayed for 00:30:16 by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 21 Mar 2017 12:29:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 21 Mar 2017 12:29:47 +0000 (UTC) for IP:'220.181.15.114' DOMAIN:'m15-114.126.com' HELO:'m15-114.126.com' FROM:'chen_han_xiao@126.com' RCPT:'' X-RedHat-Spam-Score: 3.599 *** (BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_ANBREP_L2, RCVD_IN_PSBL, RP_MATCHES_RCVD, SPF_PASS) 220.181.15.114 m15-114.126.com 220.181.15.114 m15-114.126.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.25 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: jdenemar@redhat.com, Chen Hanxiao Subject: [libvirt] [PATCH v2] cleanup: qemu_capabilities: remove redundant error messages X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 21 Mar 2017 12:29:55 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Chen Hanxiao We reported error in caller virQEMUCapsCacheLookupByArch. So the same error messages in qemuConnectGetDomainCapabilities is useless. Signed-off-by: Chen Hanxiao --- v2: remove extra error message in qemuConnectGetDomainCapabilities instead of virQEMUCapsCacheLookupByArch. src/qemu/qemu_driver.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index dcd823f..0e06508 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18713,12 +18713,8 @@ qemuConnectGetDomainCapabilities(virConnectPtr con= n, } else { if (!(qemuCaps =3D virQEMUCapsCacheLookupByArch(caps, driver->qemuCapsCach= e, - arch))) { - virReportError(VIR_ERR_INVALID_ARG, - _("unable to find any emulator to serve '%s' " - "architecture"), virArchToString(arch)); + arch))) goto cleanup; - } =20 emulatorbin =3D virQEMUCapsGetBinary(qemuCaps); } --=20 2.7.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list