src/libxl/libxl_driver.c | 58 ++++++- src/libxl/libxl_migration.c | 367 +++++++++++++++++++++++++++++++++++++------- src/libxl/libxl_migration.h | 9 ++ 3 files changed, 381 insertions(+), 53 deletions(-)
Hey! Presented herewith is take 4 from tunnelled migration addressing all previous comments. No functional changes from v2, only revert to v1 on the top level migration functions and removing unnecessary usage of virReportError. Thanks, Joao Bob Liu (1): libxl: add tunnelled migration support Joao Martins (1): libxl: refactor libxlDomainMigrationPrepare src/libxl/libxl_driver.c | 58 ++++++- src/libxl/libxl_migration.c | 367 +++++++++++++++++++++++++++++++++++++------- src/libxl/libxl_migration.h | 9 ++ 3 files changed, 381 insertions(+), 53 deletions(-) -- 2.1.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Joao Martins wrote: > Hey! > > Presented herewith is take 4 from tunnelled migration addressing all previous > comments. No functional changes from v2, only revert to v1 on the top level > migration functions and removing unnecessary usage of virReportError. > > Thanks, > Joao > > Bob Liu (1): > libxl: add tunnelled migration support > > Joao Martins (1): > libxl: refactor libxlDomainMigrationPrepare > > src/libxl/libxl_driver.c | 58 ++++++- > src/libxl/libxl_migration.c | 367 +++++++++++++++++++++++++++++++++++++------- > src/libxl/libxl_migration.h | 9 ++ > 3 files changed, 381 insertions(+), 53 deletions(-) > ACK series. I fixed up the indentation in 2/2 before pushing. This series is newsworthy. Can you post a followup adding an entry to docs/news.xml describing this new feature? Thanks! Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 02/15/2017 09:53 PM, Jim Fehlig wrote: > Joao Martins wrote: >> Hey! >> >> Presented herewith is take 4 from tunnelled migration addressing all previous >> comments. No functional changes from v2, only revert to v1 on the top level >> migration functions and removing unnecessary usage of virReportError. >> >> Thanks, >> Joao >> >> Bob Liu (1): >> libxl: add tunnelled migration support >> >> Joao Martins (1): >> libxl: refactor libxlDomainMigrationPrepare >> >> src/libxl/libxl_driver.c | 58 ++++++- >> src/libxl/libxl_migration.c | 367 +++++++++++++++++++++++++++++++++++++------- >> src/libxl/libxl_migration.h | 9 ++ >> 3 files changed, 381 insertions(+), 53 deletions(-) >> > > ACK series. I fixed up the indentation in 2/2 before pushing. > > This series is newsworthy. Can you post a followup adding an entry to > docs/news.xml describing this new feature? Thanks! Yeap, will do. Thanks! Joao -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 02/15/2017 10:14 PM, Joao Martins wrote: > On 02/15/2017 09:53 PM, Jim Fehlig wrote: >> Joao Martins wrote: >>> Hey! >>> >>> Presented herewith is take 4 from tunnelled migration addressing all previous >>> comments. No functional changes from v2, only revert to v1 on the top level >>> migration functions and removing unnecessary usage of virReportError. >>> >>> Thanks, >>> Joao >>> >>> Bob Liu (1): >>> libxl: add tunnelled migration support >>> >>> Joao Martins (1): >>> libxl: refactor libxlDomainMigrationPrepare >>> >>> src/libxl/libxl_driver.c | 58 ++++++- >>> src/libxl/libxl_migration.c | 367 +++++++++++++++++++++++++++++++++++++------- >>> src/libxl/libxl_migration.h | 9 ++ >>> 3 files changed, 381 insertions(+), 53 deletions(-) >>> >> >> ACK series. I fixed up the indentation in 2/2 before pushing. >> >> This series is newsworthy. Can you post a followup adding an entry to >> docs/news.xml describing this new feature? Thanks! > Yeap, will do. Just sent it over [0]. Maybe it's also worth adding news coverage to your libxl timer improvements, and the many maxmem related fixes :) [0] https://www.redhat.com/archives/libvir-list/2017-February/msg00761.html -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Joao Martins wrote: > On 02/15/2017 10:14 PM, Joao Martins wrote: >> On 02/15/2017 09:53 PM, Jim Fehlig wrote: >>> Joao Martins wrote: >>>> Hey! >>>> >>>> Presented herewith is take 4 from tunnelled migration addressing all previous >>>> comments. No functional changes from v2, only revert to v1 on the top level >>>> migration functions and removing unnecessary usage of virReportError. >>>> >>>> Thanks, >>>> Joao >>>> >>>> Bob Liu (1): >>>> libxl: add tunnelled migration support >>>> >>>> Joao Martins (1): >>>> libxl: refactor libxlDomainMigrationPrepare >>>> >>>> src/libxl/libxl_driver.c | 58 ++++++- >>>> src/libxl/libxl_migration.c | 367 +++++++++++++++++++++++++++++++++++++------- >>>> src/libxl/libxl_migration.h | 9 ++ >>>> 3 files changed, 381 insertions(+), 53 deletions(-) >>>> >>> ACK series. I fixed up the indentation in 2/2 before pushing. >>> >>> This series is newsworthy. Can you post a followup adding an entry to >>> docs/news.xml describing this new feature? Thanks! >> Yeap, will do. > Just sent it over [0]. Maybe it's also worth adding news coverage to your libxl > timer improvements, and the many maxmem related fixes :) Touche :-). I guess those are newsworthy as well. I'll send some patches in a bit. Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.