remote generator: Increase upper limit on lists of node devices

[libvirt] [PATCH] remote generator: Increase upper limit on lists of node devices

Posted by Boris Fiuczynski 8 years, 12 months ago

On a system with 697 SCSI disks each configured with 8 paths the command
virsh nodedev-list fails with
error: Failed to list node devices
error: internal error: Too many node_devices '16816' for limit '16384'
Increasing the upper limit on lists of node devices from 16K to 64K.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
---
 src/remote/remote_protocol.x | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
index 68469a5..cd0a14c 100644
--- a/src/remote/remote_protocol.x
+++ b/src/remote/remote_protocol.x
@@ -86,7 +86,7 @@ const REMOTE_STORAGE_POOL_LIST_MAX = 4096;
 const REMOTE_STORAGE_VOL_LIST_MAX = 16384;
 
 /* Upper limit on lists of node devices. */
-const REMOTE_NODE_DEVICE_LIST_MAX = 16384;
+const REMOTE_NODE_DEVICE_LIST_MAX = 65536;
 
 /* Upper limit on lists of node device capabilities. */
 const REMOTE_NODE_DEVICE_CAPS_LIST_MAX = 65536;
-- 
2.5.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] remote generator: Increase upper limit on lists of node devices

Posted by Michal Privoznik 8 years, 12 months ago

On 02/10/2017 02:56 PM, Boris Fiuczynski wrote:
> On a system with 697 SCSI disks each configured with 8 paths the command
> virsh nodedev-list fails with
> error: Failed to list node devices
> error: internal error: Too many node_devices '16816' for limit '16384'
> Increasing the upper limit on lists of node devices from 16K to 64K.
> 
> Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
> ---
>  src/remote/remote_protocol.x | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index 68469a5..cd0a14c 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -86,7 +86,7 @@ const REMOTE_STORAGE_POOL_LIST_MAX = 4096;
>  const REMOTE_STORAGE_VOL_LIST_MAX = 16384;
>  
>  /* Upper limit on lists of node devices. */
> -const REMOTE_NODE_DEVICE_LIST_MAX = 16384;
> +const REMOTE_NODE_DEVICE_LIST_MAX = 65536;
>  
>  /* Upper limit on lists of node device capabilities. */
>  const REMOTE_NODE_DEVICE_CAPS_LIST_MAX = 65536;
> 

ACKed and pushed. I think history proved that raising these limits is
okay. I did some research of the generated code myself too and both
client & server can cope with the changed limit and different limit on
the other side too (i.e. older client talking to newer server and vice
versa).

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] remote generator: Increase upper limit on lists of node devices

Posted by Boris Fiuczynski 8 years, 12 months ago

On 02/10/2017 04:13 PM, Michal Privoznik wrote:
> On 02/10/2017 02:56 PM, Boris Fiuczynski wrote:
>> On a system with 697 SCSI disks each configured with 8 paths the command
>> virsh nodedev-list fails with
>> error: Failed to list node devices
>> error: internal error: Too many node_devices '16816' for limit '16384'
>> Increasing the upper limit on lists of node devices from 16K to 64K.
>>
>> Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
>> ---
>>  src/remote/remote_protocol.x | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
>> index 68469a5..cd0a14c 100644
>> --- a/src/remote/remote_protocol.x
>> +++ b/src/remote/remote_protocol.x
>> @@ -86,7 +86,7 @@ const REMOTE_STORAGE_POOL_LIST_MAX = 4096;
>>  const REMOTE_STORAGE_VOL_LIST_MAX = 16384;
>>
>>  /* Upper limit on lists of node devices. */
>> -const REMOTE_NODE_DEVICE_LIST_MAX = 16384;
>> +const REMOTE_NODE_DEVICE_LIST_MAX = 65536;
>>
>>  /* Upper limit on lists of node device capabilities. */
>>  const REMOTE_NODE_DEVICE_CAPS_LIST_MAX = 65536;
>>
>
> ACKed and pushed. I think history proved that raising these limits is
> okay. I did some research of the generated code myself too and both
> client & server can cope with the changed limit and different limit on
> the other side too (i.e. older client talking to newer server and vice
> versa).
>
> Michal
>
Thanks, Michal!

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list