From nobody Sat May 11 22:13:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694086950; cv=none; d=zohomail.com; s=zohoarc; b=btu0tsfzZPA5eSGLOklAjaHfUyxrn2/1BePDOanjAyVeOyDfXHlzv3m2XA5IMhp9+BNqEwfQ1Q7g/NNa8SKIYIqqlGG3Ia4ntnU6eGZ9797L58Cf3XPpxNMOkrYdasXdj/sK1K81IgisfMf2No/N/B79X8BdgDKrb0o/kIHmiB8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694086950; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=iCpyhz566yP6JZsMnThghBUdfYGuoa5Tg1w394iA1BY=; b=JBcYxZVvoGOJxxL89x/G85rq1P1l24pwOHZ4+67NROg7lGy7k1P0QDRRgGZLIGzJk+MIe/L5VDKlVNEICfM12JdCAJnGJ2UxjAJM+MyrpxEzfHFHE7l4IHChCvFPnbar7r584XetgnJpVnDlZmZsq/08FjA/Bbb87IcRQLRsx6o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1694086950799347.8005031690499; Thu, 7 Sep 2023 04:42:30 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-xDTKEgZmPNWb-voyAnSXow-1; Thu, 07 Sep 2023 07:42:26 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A25C93C1C997; Thu, 7 Sep 2023 11:42:24 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E36DB140E963; Thu, 7 Sep 2023 11:42:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5B204194658F; Thu, 7 Sep 2023 11:42:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 374C6194658C for ; Thu, 7 Sep 2023 11:42:20 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EFF8221EE56B; Thu, 7 Sep 2023 11:42:19 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F34321EE56A for ; Thu, 7 Sep 2023 11:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694086949; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=iCpyhz566yP6JZsMnThghBUdfYGuoa5Tg1w394iA1BY=; b=fsdqRi7YqWka1Ad5AeGLUS070TscTloh3ksRLOUAgammfdzPeo68eI42YrYoQZDdfaUlZv F7yWQq2mQZ29ThwCGxFPfPmmA3h2dWZZfbQwXJOAMSYOa9FQuxDN3Jvo8Ijsm3TmhhQano 1IxZl63MapeYYOotbuHGUQx8Ud8am44= X-MC-Unique: xDTKEgZmPNWb-voyAnSXow-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] manpage: virsh: Note that 'virsh undefine --remove-all-storage' doesn't remove backing images Date: Thu, 7 Sep 2023 13:42:18 +0200 Message-ID: <1104e7524db16944c5fd522c37de58161d691243.1694086938.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694086951937100001 Content-Type: text/plain; charset="utf-8" Removing a backing image could break other image chains as it's theoretically possible to share backing chains. As --storage/--remove-all-storage is fully implemented in virsh as a helper option, which enumerates and deletes VM's volumes. We do not plan to make it any more complicated. Document that backing chains are not removed. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- docs/manpages/virsh.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 91e1d5de37..4ae3bb4d93 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4614,12 +4614,13 @@ undefined; if not all of the requested volumes coul= d be deleted, the error message indicates what still remains behind. If a volume path is not found in the domain definition, it's treated as if the volume was successf= ully deleted. Only volumes managed by libvirt in storage pools can be removed t= his -way. +way. Note that this also removes only the top level image of a backing cha= in, +any backing stores of the image are kept as they may be shared. (See ``domblklist`` for list of target names associated to a domain). Example: --storage vda,/path/to/storage.img The *--remove-all-storage* flag specifies that all of the domain's storage -volumes should be deleted. +volumes should be deleted as if they were specified via *--storage*. The *--delete-storage-volume-snapshots* (previously *--delete-snapshots*) flag specifies that any snapshots associated with --=20 2.41.0