bhyve: Fix declaration of 'params' in 'bhyveParsePCIFbuf'

[PATCH] bhyve: Fix declaration of 'params' in 'bhyveParsePCIFbuf'

Peter Krempa posted 1 patch 3 years ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/0d0175365199709956befbee4debaa11e4fcbf6e.1618244447.git.pkrempa@redhat.com

src/bhyve/bhyve_parse_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] bhyve: Fix declaration of 'params' in 'bhyveParsePCIFbuf'

Posted by Peter Krempa 3 years ago

In commit ad80bba90a3 I've mistakenly didn't delete '**' from the
variable declaration when converting it to 'GStrv'

Fixes: ad80bba90a3
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---

The patch will be pushed under the build-breaker and trivial rules once
the pipeline passes:

https://gitlab.com/pipo.sk/libvirt/-/pipelines/285158773

 src/bhyve/bhyve_parse_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c
index d86d37b697..2783119a7b 100644
--- a/src/bhyve/bhyve_parse_command.c
+++ b/src/bhyve/bhyve_parse_command.c
@@ -558,7 +558,7 @@ bhyveParsePCIFbuf(virDomainDefPtr def,

     virDomainVideoDefPtr video = NULL;
     virDomainGraphicsDefPtr graphics = NULL;
-    g_auto(GStrv) **params = NULL;
+    g_auto(GStrv) params = NULL;
     GStrv next;

     if (!(video = virDomainVideoDefNew(xmlopt)))
-- 
2.30.2

Re: [PATCH] bhyve: Fix declaration of 'params' in 'bhyveParsePCIFbuf'

Posted by Ján Tomko 3 years ago

On a Monday in 2021, Peter Krempa wrote:
>In commit ad80bba90a3 I've mistakenly didn't delete '**' from the

d/'ve/

>variable declaration when converting it to 'GStrv'
>
>Fixes: ad80bba90a3
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
>
>The patch will be pushed under the build-breaker and trivial rules once
>the pipeline passes:
>
>https://gitlab.com/pipo.sk/libvirt/-/pipelines/285158773
>
> src/bhyve/bhyve_parse_command.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c
>index d86d37b697..2783119a7b 100644
>--- a/src/bhyve/bhyve_parse_command.c
>+++ b/src/bhyve/bhyve_parse_command.c
>@@ -558,7 +558,7 @@ bhyveParsePCIFbuf(virDomainDefPtr def,
>
>     virDomainVideoDefPtr video = NULL;
>     virDomainGraphicsDefPtr graphics = NULL;
>-    g_auto(GStrv) **params = NULL;
>+    g_auto(GStrv) params = NULL;
>     GStrv next;
>
>     if (!(video = virDomainVideoDefNew(xmlopt)))
>-- 
>2.30.2

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano