From nobody Wed May 15 04:49:27 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1705460578831810.9444001034315; Tue, 16 Jan 2024 19:02:58 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8E5741D9B; Tue, 16 Jan 2024 22:02:57 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7DB031D8F; Tue, 16 Jan 2024 22:00:58 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8F4B11CFD; Tue, 16 Jan 2024 22:00:46 -0500 (EST) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 040751D8F for ; Tue, 16 Jan 2024 22:00:44 -0500 (EST) Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2cdeb954640so3995161fa.3 for ; Tue, 16 Jan 2024 19:00:44 -0800 (PST) Received: from [10.60.34.204] ([165.171.224.5]) by smtp.gmail.com with ESMTPSA id e1-20020a028601000000b0046dcaba1adesm179946jai.62.2024.01.16.19.00.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 19:00:42 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705460443; x=1706065243; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+jfu4nM95QRDsNYCbfgrF7w6JrXqwhPbHMOgPSu2OBU=; b=MqU+8AxgtvN6vm+aczyqyV2QKUqJXjWAL5S9o4likCQ4vCuA/YDQ/9GKfhU/lyoGQ7 gqTNSqzucVDTBW/Yne2lImFsK65mD0rjx5h/fhNPPy+rYGOgkGsgDZ1+nwKf8BUJDn7v g+PjdyRgBZaRtijqfmBrwTDfkw9JfVXi7za7Q6S/4xeusjIYLQTqVk1C/+dPT3Dn9aTB 4enewBEaRnzEfIGUKvZA3sGoeBRs39UaD9kJatxiodV3tthZ+b71G81ltvF1onNmcI+b sqQKmLavNZEU2qZs6SI3CCAh848m7cxfQGsUKXC6uq8lbAdFODVi3+Ue8GM3YAjtcKom NPOg== X-Gm-Message-State: AOJu0Yz+SnRj2cpN0A4rR3wL3fd1k/5nat4zJ6DsPhKxZ1tZKu8ZONIe YuUo6K9RhjDpy/3sOXm+gBc/6wSxmerh16Ma+vjO6Gyfbrw= X-Google-Smtp-Source: AGHT+IHmJTNYPHEhGmwMnZfwzgG+qf7pqi6ELUeQWj0rdAchwwtONi0rvNQqidLN6qrgFk14Cgxo0Q== X-Received: by 2002:a2e:8050:0:b0:2cd:10be:cf13 with SMTP id p16-20020a2e8050000000b002cd10becf13mr3670288ljg.2.1705460443330; Tue, 16 Jan 2024 19:00:43 -0800 (PST) Message-ID: <0c94cdab-1d99-4bf1-9888-e7e63fa25473@suse.com> Date: Tue, 16 Jan 2024 20:00:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: devel@lists.libvirt.org From: Jim Fehlig Subject: build failure on ppc64le Message-ID-Hash: DSCORVFVRX5GLGNOPMTNQL2D7MJYBEVU X-Message-ID-Hash: DSCORVFVRX5GLGNOPMTNQL2D7MJYBEVU X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1705460580115100001 Hi All, We recently started noticing build failures of libvirt for ppc64le on some=20 distros in our build service. Seems it's possible for sources in remote to = be=20 built before remote_protocol.h is generated [ 178s] cc -Isrc/virtnodedevd.p -Isrc -I../src -Isrc/conf -I../src/conf=20 -Isrc/remote -I../src/remote -Isrc/admin -I../src/admin -Isrc/access=20 -I../src/access -Isrc/rpc -I../src/rpc -Isrc/util -I../src/util -Iinclude=20 -I../include -I. -I.. -I/usr/include/p11-kit-1 -I/usr/include/libnl3=20 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include=20 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid=20 -I/usr/include/libxml2 -fdiagnostics-color=3Dalways -D_FILE_OFFSET_BITS=3D6= 4 -Wall=20 -Winvalid-pch -Wextra -std=3Dgnu99 -fasynchronous-unwind-tables -fexception= s=20 -fipa-pure-const -fno-common -Waddress -Waggressive-loop-optimizations=20 -Walloc-size-larger-than=3D9223372036854775807 -Walloca -Warray-bounds=3D2=20 -Wattributes -Wbool-compare -Wbool-operation -Wbuiltin-declaration-mismatch=20 -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered -Wcomm= ent=20 -Wcomments -Wcoverage-mismatch -Wcpp -Wdangling-else -Wdate-time=20 -Wdeclaration-after-statement -Wdeprecated-declarations -Wdesignated-init=20 -Wdiscarded-array-qualifiers -Wdiscarded-qualifiers -Wdiv-by-zero=20 -Wduplicated-cond -Wduplicate-decl-specifier -Wempty-body -Wendif-labels=20 -Wexpansion-to-defined -Wformat-contains-nul -Wformat-extra-args=20 -Wno-format-nonliteral -Wformat-overflow=3D2 -Wformat-security=20 -Wno-format-truncation -Wformat-y2k -Wformat-zero-length -Wframe-address=20 -Wframe-larger-than=3D2048 -Wfree-nonheap-object -Whsa -Wignored-attributes=20 -Wignored-qualifiers -Wimplicit -Wimplicit-fallthrough=3D5=20 -Wimplicit-function-declaration -Wimplicit-int -Wincompatible-pointer-types=20 -Winit-self -Winline -Wint-conversion -Wint-in-bool-context=20 -Wint-to-pointer-cast -Winvalid-memory-model -Winvalid-pch -Wjump-misses-in= it=20 -Wlogical-not-parentheses -Wlogical-op -Wmain -Wmaybe-uninitialized=20 -Wmemset-elt-size -Wmemset-transposed-args -Wmisleading-indentation=20 -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers=20 -Wmissing-include-dirs -Wmissing-parameter-type -Wmissing-prototypes -Wmult= ichar=20 -Wnarrowing -Wnested-externs -Wnonnull -Wnonnull-compare -Wnormalized=3Dnfc=20 -Wnull-dereference -Wodr -Wold-style-declaration -Wold-style-definition=20 -Wopenmp-simd -Woverflow -Woverride-init -Wpacked-bitfield-compat -Wparenth= eses=20 -Wpointer-arith -Wpointer-compare -Wpointer-sign -Wpointer-to-int-cast -Wpr= agmas=20 -Wpsabi -Wrestrict -Wreturn-local-addr -Wreturn-type -Wscalar-storage-order=20 -Wsequence-point -Wshadow -Wshift-count-negative -Wshift-count-overflow=20 -Wshift-negative-value -Wshift-overflow=3D2 -Wno-sign-compare=20 -Wsizeof-array-argument -Wsizeof-pointer-memaccess -Wstrict-aliasing=20 -Wstrict-prototypes -Wstringop-overflow=3D2 -Wno-suggest-attribute=3Dconst=20 -Wsuggest-attribute=3Dformat -Wsuggest-attribute=3Dnoreturn=20 -Wno-suggest-attribute=3Dpure -Wsuggest-final-methods -Wsuggest-final-types=20 -Wswitch -Wswitch-bool -Wswitch-enum -Wswitch-unreachable -Wsync-nand=20 -Wtautological-compare -Wtrampolines -Wtrigraphs -Wtype-limits -Wuninitiali= zed=20 -Wunknown-pragmas -Wunused -Wunused-but-set-parameter -Wunused-but-set-vari= able=20 -Wunused-const-variable=3D2 -Wunused-function -Wunused-label=20 -Wunused-local-typedefs -Wunused-parameter -Wunused-result -Wunused-value=20 -Wunused-variable -Wvarargs -Wvariadic-macros -Wvector-operation-performanc= e=20 -Wvla -Wvolatile-register-var -Wwrite-strings -fstack-protector-strong=20 -Wdouble-promotion -fmessage-length=3D0 -grecord-gcc-switches -O2 -Wall=20 -D_FORTIFY_SOURCE=3D2 -fstack-protector-strong -funwind-tables=20 -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIE -pthread=20 -DIN_LIBVIRT=20 '-Dabs_top_builddir=3D"/home/abuild/rpmbuild/BUILD/libvirt-9.10.0/ppc64le-s= use-linux"'=20 '-Dabs_top_srcdir=3D"/home/abuild/rpmbuild/BUILD/libvirt-9.10.0"'=20 '-DDAEMON_NAME=3D"virtnodedevd"' '-DMODULE_NAME=3D"nodedev"' -MD -MQ=20 src/virtnodedevd.p/remote_remote_daemon_config.c.o -MF=20 src/virtnodedevd.p/remote_remote_daemon_config.c.o.d -o=20 src/virtnodedevd.p/remote_remote_daemon_config.c.o -c=20 ../src/remote/remote_daemon_config.c [ 178s] ../src/remote/remote_daemon_config.c: In function =E2=80=98daemonC= onfigNew=E2=80=99: [ 178s] ../src/remote/remote_daemon_config.c:111:30: error:=20 =E2=80=98REMOTE_AUTH_POLKIT=E2=80=99 undeclared (first use in this function= ); did you mean=20 =E2=80=98WITH_POLKIT=E2=80=99? [ 178s] data->auth_unix_rw =3D REMOTE_AUTH_POLKIT; [ 178s] ^~~~~~~~~~~~~~~~~~ [ 178s] WITH_POLKIT [ 178s] ../src/remote/remote_daemon_config.c:111:30: note: each undeclared=20 identifier is reported only once for each function it appears in [ 178s] ../src/remote/remote_daemon_config.c:115:30: error: =E2=80=98REMOT= E_AUTH_NONE=E2=80=99=20 undeclared (first use in this function); did you mean =E2=80=98REMOTE_AUTH_= POLKIT=E2=80=99? [ 178s] data->auth_unix_rw =3D REMOTE_AUTH_NONE; [ 178s] ^~~~~~~~~~~~~~~~ [ 178s] REMOTE_AUTH_POLKIT [ 178s] ../src/remote/remote_daemon_config.c: In function=20 =E2=80=98daemonConfigLoadOptions=E2=80=99: [ 178s] ../src/remote/remote_daemon_config.c:252:31: error:=20 =E2=80=98REMOTE_AUTH_POLKIT=E2=80=99 undeclared (first use in this function= ); did you mean=20 =E2=80=98WITH_POLKIT=E2=80=99? [ 178s] if (data->auth_unix_rw =3D=3D REMOTE_AUTH_POLKIT) { [ 178s] ^~~~~~~~~~~~~~~~~~ [ 178s] WITH_POLKIT [ 178s] [263/1422] /usr/bin/meson --internal exe --capture=20 src/admin/admin_server_dispatch_stubs.h --=20 /home/abuild/rpmbuild/BUILD/libvirt-9.10.0/src/rpc/gendispatch.pl --mode=3D= server=20 admin ADMIN ../src/admin/admin_protocol.x [ 179s] [264/1422]=20 /home/abuild/rpmbuild/BUILD/libvirt-9.10.0/scripts/meson-python.sh=20 /usr/bin/python3=20 /home/abuild/rpmbuild/BUILD/libvirt-9.10.0/scripts/rpcgen/main.py --mode=3D= header=20 ../src/remote/remote_protocol.x src/remote/remote_protocol.h Full build log of one failure case can be found here https://build.opensuse.org/build/Virtualization/15.6/ppc64le/libvirt/_log The below patch fixes the issue in our testing, but I'm not sure if it's th= e=20 best solution, versus e.g. a dependency along the lines of rpc_dep et. al.=20 Thanks for comments/suggestions. Regards, Jim diff --git a/src/meson.build b/src/meson.build index 6538c43628..3f989de7f9 100644 --- a/src/meson.build +++ b/src/meson.build @@ -616,7 +616,7 @@ foreach daemon : virt_daemons bin =3D executable( daemon['name'], [ - daemon.get('sources', [ remote_daemon_sources, remote_daemon_generat= ed ]), + daemon.get('sources', [ remote_daemon_sources, remote_daemon_generat= ed,=20 remote_driver_generated ]), dtrace_gen_objects, ], c_args: [ _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org