From nobody Sat May 18 09:01:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1692709778; cv=none; d=zohomail.com; s=zohoarc; b=euMhLfCBbrzkWoSLgbmMumPsUw+2QuI1opn+REUED/HLLCg7lbA3Y7T/LzbblROBcOm6/p2GXNKgRC/ZJyJyGQUJ9hrVZUe2umgIkSQ6M0/+2QXNUvaJOEkIAt/LhwBNkQNpajideA/+z1OKMhkltldY5xaBO2PdeClgb+IoFrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692709778; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=JW00b4aFf0zsAOwYZIfZuKDXb4yFdwZFr8zAxrYm44g=; b=X61I8ie9KK4bpfBYMXXU1mGKoiuTJPONxzK4UumfkskyzdICRAMQwJcB5h6/pad3SN5khIkX7GxZlktUtSszCjg0IFgDCFwOcIZsQKcXisgfbSI4/+kPP7Aogw55LuDYM5JFuwCCyQg6AOBBLeeO80perC65HRPAFeV1AFfJTHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1692709778765877.5913998419109; Tue, 22 Aug 2023 06:09:38 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-620-b2PwLkGAOj2d8f7I_-pgHQ-1; Tue, 22 Aug 2023 09:09:34 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DAAE985CCE2; Tue, 22 Aug 2023 13:09:30 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02B074094DC0; Tue, 22 Aug 2023 13:09:28 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 88B851946587; Tue, 22 Aug 2023 13:09:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C2B851946586 for ; Tue, 22 Aug 2023 13:09:21 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7DB31140E970; Tue, 22 Aug 2023 13:09:21 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A15A140E96E for ; Tue, 22 Aug 2023 13:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692709777; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JW00b4aFf0zsAOwYZIfZuKDXb4yFdwZFr8zAxrYm44g=; b=jGm31A2x6Tr3STorih+PciBzalnX8e417MyKiTn7qHMnYy10R98pvASV/hUGh/3Hl3cbbO GHHUoJZZKVeIDJtqM9/MAPbZYscZDh2cWBs/sxU8rGgtjJXf9Gl4hvn5n7rA0lF8sPkpXM 6fbKgbjnGa03fzu7snHF07pFn3XNyu8= X-MC-Unique: b2PwLkGAOj2d8f7I_-pgHQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH] qemuValidateDomainVCpuTopology: Remove misconfiguration warning Date: Tue, 22 Aug 2023 15:09:20 +0200 Message-ID: <096bd32d8891474637c2bc5f25365bee6fef9e2c.1692709709.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1692709843584100001 Content-Type: text/plain; charset="utf-8" Since commit baca59a5384 the NUMA definition is automatically fixed if the vCPU count mismatches the NUMA cpu count so that this warning will never be triggered. Additionally VIR_WARN of a misconfiguration of a VM would not really be seen in most cases as it's only simply logged. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- This was originally in my series reworking qemuxml2xmltest. I've removed it but later figured out that it's dead code. This posting has an updated commit message. src/qemu/qemu_validate.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 28e4a4cc99..9e638894a9 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -761,7 +761,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def,= virQEMUCaps *qemuCaps) def->os.machine); unsigned int topologycpus; unsigned int granularity; - unsigned int numacpus; if (virDomainDefGetVcpus(def) =3D=3D 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -785,13 +784,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def= , virQEMUCaps *qemuCaps) } } - numacpus =3D virDomainNumaGetCPUCountTotal(def->numa); - if ((numacpus !=3D 0) && (topologycpus !=3D numacpus)) { - VIR_WARN("CPU topology doesn't match numa CPU count; " - "partial NUMA mapping is obsoleted and will " - "be removed in future"); - } - /* vCPU hotplug granularity must be respected */ granularity =3D qemuValidateDefGetVcpuHotplugGranularity(def); if ((virDomainDefGetVcpus(def) % granularity) !=3D 0) { --=20 2.41.0