qemu: remove input device after receiving the event

[libvirt] [PATCH] qemu: remove input device after receiving the event

Ján Tomko posted 1 patch 6 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/070f9813f2441ece28dc5dbff9a44a0cfadc618a.1513245085.git.jtomko@redhat.com

src/qemu/qemu_hotplug.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemu: remove input device after receiving the event

Posted by Ján Tomko 6 years, 4 months ago

Also call qemuDomainRemoveInputDevice if we receive the
event after the Detach API ends.

Commit 67486bb failed to include this.

https://bugzilla.redhat.com/show_bug.cgi?id=1524837
---
 src/qemu/qemu_hotplug.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index c4f8c0fa4..2033c7dd0 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -4412,10 +4412,13 @@ qemuDomainRemoveDevice(virQEMUDriverPtr driver,
         ret = qemuDomainRemoveShmemDevice(driver, vm, dev->data.shmem);
         break;
 
+    case VIR_DOMAIN_DEVICE_INPUT:
+        ret = qemuDomainRemoveInputDevice(vm, dev->data.input);
+        break;
+
     case VIR_DOMAIN_DEVICE_NONE:
     case VIR_DOMAIN_DEVICE_LEASE:
     case VIR_DOMAIN_DEVICE_FS:
-    case VIR_DOMAIN_DEVICE_INPUT:
     case VIR_DOMAIN_DEVICE_SOUND:
     case VIR_DOMAIN_DEVICE_VIDEO:
     case VIR_DOMAIN_DEVICE_WATCHDOG:
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: remove input device after receiving the event

Posted by Erik Skultety 6 years, 4 months ago

On Thu, Dec 14, 2017 at 10:51:27AM +0100, Ján Tomko wrote:
> Also call qemuDomainRemoveInputDevice if we receive the
> event after the Detach API ends.
>
> Commit 67486bb failed to include this.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1524837
> ---
>  src/qemu/qemu_hotplug.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list