Expose Linux symbols only on Linux

[libvirt] [PATCH] Expose Linux symbols only on Linux

Martin Kletzander posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/057da0ab77ecd1b831f924d51582565327e79c38.1490627826.git.mkletzan@redhat.com

src/libvirt_linux.syms   | 3 +++
src/libvirt_private.syms | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)

Expand all Fold all

[libvirt] [PATCH] Expose Linux symbols only on Linux

Posted by Martin Kletzander 7 years ago

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
Just to make it a teeny tiny nicer, how about this one as well.  I
know the whole file needs way more refactoring and cleaning up, but we
can do that by small pieces.

 src/libvirt_linux.syms   | 3 +++
 src/libvirt_private.syms | 2 --
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/libvirt_linux.syms b/src/libvirt_linux.syms
index 3d66f013062b..5fa2c790efc1 100644
--- a/src/libvirt_linux.syms
+++ b/src/libvirt_linux.syms
@@ -3,7 +3,10 @@
 #

 # util/virhostcpu.h
+virHostCPUGetCore;
 virHostCPUGetInfoPopulateLinux;
+virHostCPUGetSiblingsList;
+virHostCPUGetSocket;
 virHostCPUGetStatsLinux;

 # Let emacs know we want case-insensitive sorting
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 4c14ef59012a..605a6e6785be 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1713,7 +1713,6 @@ virHookPresent;


 # util/virhostcpu.h
-virHostCPUGetCore;
 virHostCPUGetCount;
 virHostCPUGetInfo;
 virHostCPUGetKVMMaxVCPUs;
@@ -1721,7 +1720,6 @@ virHostCPUGetMap;
 virHostCPUGetOnline;
 virHostCPUGetOnlineBitmap;
 virHostCPUGetPresentBitmap;
-virHostCPUGetSocket;
 virHostCPUGetStats;
 virHostCPUGetThreadsPerSubcore;
 virHostCPUHasBitmap;
--
2.12.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Expose Linux symbols only on Linux

Posted by Pavel Hrdina 7 years ago

On Mon, Mar 27, 2017 at 05:17:57PM +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
> Just to make it a teeny tiny nicer, how about this one as well.  I
> know the whole file needs way more refactoring and cleaning up, but we
> can do that by small pieces.

ACK, this also fixes a potential issue that the virHostCPUGetSiblingsList
is not listed in any of the *.syms files.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list