From nobody Sun Apr 28 12:35:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1524147440099578.1616680226089; Thu, 19 Apr 2018 07:17:20 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EA3DC024FE7; Thu, 19 Apr 2018 14:17:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCFF3827B5; Thu, 19 Apr 2018 14:17:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9419F180610F; Thu, 19 Apr 2018 14:17:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w3JEH3fJ006411 for ; Thu, 19 Apr 2018 10:17:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8AE371102E32; Thu, 19 Apr 2018 14:17:03 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DE2D10F1BFA; Thu, 19 Apr 2018 14:17:00 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Thu, 19 Apr 2018 16:16:56 +0200 Message-Id: <006f97fc1d804b84c6cd886dee70a823b2d810e4.1524147416.git.mprivozn@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: jdenemar@redhat.com Subject: [libvirt] [PATCH v2] qemuDomainObjPrivateDataClear: Don't leak @migParams X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 19 Apr 2018 14:17:18 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Allocated in qemuMigrationParamsNew() we need to free priv->job.migParams when no longer needed. =3D=3D8061=3D=3D 234 (192 direct, 42 indirect) bytes in 1 blocks are defini= tely lost in loss record 112 of 123 =3D=3D8061=3D=3D at 0x4C2CF26: calloc (vg_replace_malloc.c:711) =3D=3D8061=3D=3D by 0x5325D05: virAlloc (viralloc.c:144) =3D=3D8061=3D=3D by 0x1984F9: qemuMigrationParamsNew (qemu_migration_par= ams.c:218) =3D=3D8061=3D=3D by 0x19A352: qemuMigrationParamsParse (qemu_migration_p= arams.c:1185) =3D=3D8061=3D=3D by 0x1604D8: qemuDomainObjPrivateXMLParseJob (qemu_doma= in.c:2390) =3D=3D8061=3D=3D by 0x160AE9: qemuDomainObjPrivateXMLParse (qemu_domain.= c:2517) =3D=3D8061=3D=3D by 0x5419EAE: virDomainObjParseXML (domain_conf.c:20442) =3D=3D8061=3D=3D by 0x541A25E: virDomainObjParseNode (domain_conf.c:2055= 5) =3D=3D8061=3D=3D by 0x541A2FC: virDomainObjParseFile (domain_conf.c:2057= 4) =3D=3D8061=3D=3D by 0x13607D: testCompareStatusXMLToXMLFiles (qemuxml2xm= ltest.c:75) =3D=3D8061=3D=3D by 0x14F3E8: virTestRun (testutils.c:180) =3D=3D8061=3D=3D by 0x14DCD0: mymain (qemuxml2xmltest.c:1200) Signed-off-by: Michal Privoznik Reviewed-by: J=EF=BF=BDn Tomko --- src/qemu/qemu_domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index e2a8450e2e..027321e1d4 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1895,6 +1895,8 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivatePtr= priv) =20 virBitmapFree(priv->migrationCaps); priv->migrationCaps =3D NULL; + + qemuMigrationParamsFree(priv->job.migParams); } =20 =20 --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list