From nobody Fri May 17 06:54:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106020+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106020+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1686580703; cv=none; d=zohomail.com; s=zohoarc; b=gFZG1QZW9FSIt1v1fQsID1rFRR/g51rSwU62VWzbavDc99W6pT/8I3Iz2I4nTpBgy0rrbkAY0nGWU1PE/g8OYnlCu/OM05YAf6wehvEblluVKWlC3yXTLp7pW8Hp/2x6nVMv0m/Ep1UFs3crmN1mRfoMDYmVNHaXqPBQShGzcC0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686580703; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=BFjXi1ak8E8sQTelFTYhF5KW4itOLMPPcPBHBHmELHI=; b=YpZumRBdR6Y49nwwCqRKQ8+rEdvQbKZxMOspZgr2R8XpY0o5ZDBJpM3IIAStBYoLQyKcZgBpxNjq00SkStJy3HfXWwGKHGZtybFWEavJgdeZK6N3fLy7mfOT9mfQObDc2u7uZd5o+GentZ5F/Lzz4fCBzWtoMQqdFS3FotKlRGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106020+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1686580703827252.8545029775363; Mon, 12 Jun 2023 07:38:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AJtjYY1788612xKoeJLF8qYG; Mon, 12 Jun 2023 07:38:23 -0700 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.52012.1686547481583531162 for ; Sun, 11 Jun 2023 22:24:42 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="337583815" X-IronPort-AV: E=Sophos;i="6.00,235,1681196400"; d="scan'208";a="337583815" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2023 22:24:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="744188934" X-IronPort-AV: E=Sophos;i="6.00,235,1681196400"; d="scan'208";a="744188934" X-Received: from kurugodx-desk.gar.corp.intel.com ([10.66.234.59]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2023 22:24:36 -0700 From: kurugodx To: devel@edk2.groups.io Cc: kurugodx , Chasel Chiu , Nate DeSimone , Duggapu Chinni B , Chen Gang C , Star Zeng , Ted Kuo , Ashraf Ali S , Susovan Mohapatra Subject: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Get HobListPtr before calling the Multiphase FSPS Date: Sun, 11 Jun 2023 22:24:15 -0700 Message-ID: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kurugodumelmatamx.aishwarya@intel.com X-Gm-Message-State: muPrji5Jmh3nIusmcuceBFjPx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1686580703; bh=gGQR/SD0AAGteYcy+xMgbkzeCNV5spx+k9aJIM2FvA8=; h=Cc:Date:From:Reply-To:Subject:To; b=iHr8h2YhsSpHzoncQ4O35FfA609EX2eZ2dd6HgN/DOUM2vg47Z9srpUaTOUWYaiT4Hm hAxVsNX0IZ7a6+Tjj64Lr+uTQLfj2vaMIBDff0++IUEp3s3fGQ/nwXJkcNsV4TB3bZTZS PMPz/l+wUuI0qGdnbtz+11nUz+zLCuhQzu0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1686580706011100005 Content-Type: text/plain; charset="utf-8" REF : https://bugzilla.tianocore.org/show_bug.cgi?id=3D4480 In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will be able to get the correct FspHobListPtr value Signed-off-by: kurugodx Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Chen Gang C Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra Reviewed-by: Ashraf Ali S Reviewed-by: Chasel Chiu --- .../FspsWrapperPeim/FspsWrapperPeim.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelF= sp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c index 08fe0fdb7e..1d4dd60577 100644 --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify ( =20 DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status)); =20 + // + // Get FspHobList + // + GuidHob =3D GetFirstGuidHob (&gFspHobGuid); + ASSERT (GuidHob !=3D NULL); + FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); + DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); + if (Status =3D=3D FSP_STATUS_VARIABLE_REQUEST) { // // call to Variable request handler @@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify ( DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Sta= tus =3D %r\n", Status)); } =20 - // - // Now FspHobList complete, process it - // - GuidHob =3D GetFirstGuidHob (&gFspHobGuid); - ASSERT (GuidHob !=3D NULL); - FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); - DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); PostFspsHobProcess (FspHobListPtr); =20 // --=20 2.41.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106020): https://edk2.groups.io/g/devel/message/106020 Mute This Topic: https://groups.io/mt/99477287/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-