From nobody Sat May 18 04:30:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+107311+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+107311+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1690516838; cv=none; d=zohomail.com; s=zohoarc; b=KZ7dqyTKUiX+u5KpTxJuU8dl7vx/V76BHA8Ftt7pqKzHFt3rjMscUhdAqdFl6l/zXjxINe4Ku8ccrLlHFnQE1cFWmiBMhnokIPuo9Yn672ksT4vO7zTx4xNPGkJsSLDecj4Kjwq5gxDiELHoINTK4Hg1XvxtqSiagHDSZN58dAY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690516838; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=iLFjjuWE9LYJx0bKi4mQ+4I5lefqLRR69ZM0Iz/Lb6I=; b=iFuaKsLMxpS5q5RWjIBKQ6em9IgAMdYhr+BXYzUHkkTkfDexldFYVU38a3LaM1c0UlShffcU+HYwlZJWRXfmOdq00qv/tH5/fXHr+iaaS+1N4lND7nG6Qoi8vCTOT0iTsIUuztB3/WLFVQPm1YqxuhFCC/1huUoSC39gltZXI5s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+107311+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1690516838108319.780725555049; Thu, 27 Jul 2023 21:00:38 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=w8AS3lUTt5NZA7wPtP4yMujLS3qV2GHDpKsr3bFIgzk=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-Received:From:To:Cc:Subject:Date:Message-Id:MIME-Version:X-CM-TRANSID:X-Coremail-Antispam:X-Originating-IP:X-CM-SenderInfo:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Transfer-Encoding; s=20140610; t=1690516837; v=1; b=LGyAO3yomxqEY2A4b3gqaDIglRVoKk8+oflNoYi2c8kfdIri7c17FjtlM99znUasW85GsNlu p8Bpnt2abHgqYTbuajdXR6OsHCYXoATQvBFVG0yVA2wuDSk5i/hg99rGMmpm6ahbm/zjCSmbcEZ b3fdYsXBZWWxo3AgWNlndhWg= X-Received: by 127.0.0.2 with SMTP id V8ALYY1788612xCQDcwGPL0d; Thu, 27 Jul 2023 21:00:37 -0700 X-Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.214]) by mx.groups.io with SMTP id smtpd.web11.25793.1690516836487839731 for ; Thu, 27 Jul 2023 21:00:37 -0700 X-Received: from localhost.localdomain (unknown [219.141.235.82]) by zwqz-smtp-mta-g4-3 (Coremail) with SMTP id _____wB3S0A_PcNkvSY3Bg--.14904S2; Fri, 28 Jul 2023 12:00:00 +0800 (CST) From: "wangy" To: devel@edk2.groups.io Cc: pedro.falcato@gmail.com, Yang Wang , Leif Lindholm , Ard Biesheuvel , Ran Wang Subject: [edk2-devel] [edk2-platforms][PATCH V1] Silicon/Synopsys/DesignWare: DwEmacSnpDxe: Fix bug in EmacGetDmaStatus Date: Fri, 28 Jul 2023 11:59:57 +0800 Message-Id: MIME-Version: 1.0 X-CM-TRANSID: _____wB3S0A_PcNkvSY3Bg--.14904S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7AF18Ar4xJw1xuw13Ww1DAwb_yoW8Zw1xpF ZrArZrurn8GFyrA3WYyF4qqF15GFZxGrWvk347twnaqFnxJFn3uFyagFW3JFnrGry0yry3 GFZaq34xGrZ5taUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pEasUJUUUUU= X-Originating-IP: [219.141.235.82] X-CM-SenderInfo: 5zdqw5p2kd06i6rwjhhfrp/xtbBDQG6JVaEPqZyNgAAsd Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wangyzhaoz@163.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HwiKUoEK2wap3I0UJTrvck7Qx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1690516840257100003 Content-Type: text/plain; charset="utf-8" From: Yang Wang If IrqStat is NULL, the interrupt status will not be read from the device.When the interrupt status is read, it will also be cleared. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Ran Wang Signed-off-by: Yang Wang Acked-by: Pedro Falcato --- .../Drivers/DwEmacSnpDxe/EmacDxeUtil.c | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c= b/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c index 3b982ce984..26d3ff6138 100755 --- a/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c +++ b/Silicon/Synopsys/DesignWare/Drivers/DwEmacSnpDxe/EmacDxeUtil.c @@ -500,24 +500,30 @@ EmacGetDmaStatus ( UINT32 ErrorBit; UINT32 Mask =3D 0; =20 + if (IrqStat !=3D NULL) { + *IrqStat =3D 0; + } + DmaStatus =3D MmioRead32 (MacBaseAddress + DW_EMAC_DMAGRP_STATUS_OFST); if (DmaStatus & DW_EMAC_DMAGRP_STATUS_NIS_SET_MSK) { Mask |=3D DW_EMAC_DMAGRP_STATUS_NIS_SET_MSK; // Rx interrupt if (DmaStatus & DW_EMAC_DMAGRP_STATUS_RI_SET_MSK) { - *IrqStat |=3D EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT; - Mask |=3D DW_EMAC_DMAGRP_STATUS_RI_SET_MSK; - } else { - *IrqStat &=3D ~EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT; + if (IrqStat !=3D NULL) { + *IrqStat |=3D EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT; + Mask |=3D DW_EMAC_DMAGRP_STATUS_RI_SET_MSK; + } } + // Tx interrupt if (DmaStatus & DW_EMAC_DMAGRP_STATUS_TI_SET_MSK) { - *IrqStat |=3D EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT; - Mask |=3D DW_EMAC_DMAGRP_STATUS_TI_SET_MSK; - } else { - *IrqStat &=3D ~EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT; + if (IrqStat !=3D NULL) { + *IrqStat |=3D EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT; + Mask |=3D DW_EMAC_DMAGRP_STATUS_TI_SET_MSK; + } } + // Tx Buffer if (DmaStatus & DW_EMAC_DMAGRP_STATUS_TU_SET_MSK){ Mask |=3D DW_EMAC_DMAGRP_STATUS_TU_SET_MSK; --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107311): https://edk2.groups.io/g/devel/message/107311 Mute This Topic: https://groups.io/mt/100404855/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-