1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

Ning Feng posted 1 patch 1 year, 3 months ago
Failed in applying to current master (apply log)
.../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c     | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Posted by Ning Feng 1 year, 3 months ago 
fix debug print error level hob not save correct debugprinterrorlevel

should cover the case:

Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()

Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b
BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264
Signed-off-by: Ning Feng <ning.feng@intel.com>
---
 .../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c
index 4f6b4ef1fb..10bdbe2bbc 100644
--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c
+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c
@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (
       {
         if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) {
           DebugPrintErrorLevel =  (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);
-          if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {
+          if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {
             gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel;
           }
         }
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98099): https://edk2.groups.io/g/devel/message/98099
Mute This Topic: https://groups.io/mt/96090853/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Posted by Ning Feng 1 year, 3 months ago 
fix debug print error level hob not save correct debugprinterrorlevel

should cover the case:

Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()

Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b

BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Signed-off-by: Ning Feng < ning.feng@intel.com >

---

.../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c     | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

index 4f6b4ef1fb..10bdbe2bbc 100644

--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL

+++ evelLibHob.c

@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (

{         if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) {           DebugPrintErrorLevel =  (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);-          if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+          if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {             gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel;           }         }--

2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98160): https://edk2.groups.io/g/devel/message/98160
Mute This Topic: https://groups.io/mt/96090853/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Posted by Guo, Gua 1 year, 3 months ago 
@Feng, Ning<mailto:ning.feng@intel.com>

Could you send Edk2 PR ? we can check in it.
https://github.com/tianocore/edk2/pulls

And please also change commit message like below

“””

UefiPayloadPkg: Fix debug print error level hob not save correct

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4264


Fix debug print error level hob not save correct DebugPrintErrorlevel

Should cover the case:
Header.Length == UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Cc: Sean Rhodes <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Cc: James Lu <james.lu@intel.com<mailto:james.lu@intel.com>>
Cc: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
“””

Reviewed-by: Gua Guo <gua.guo@intel.com>
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ning Feng
Sent: Monday, January 9, 2023 9:44 AM
To: Feng, Ning <ning.feng@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob


fix debug print error level hob not save correct debugprinterrorlevel



should cover the case:



Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()



Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b

BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>

---

 .../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c     | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

index 4f6b4ef1fb..10bdbe2bbc 100644

--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL

+++ evelLibHob.c

@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (

       {         if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) {           DebugPrintErrorLevel =  (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);-          if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+          if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {             gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel;           }         }--

2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98161): https://edk2.groups.io/g/devel/message/98161
Mute This Topic: https://groups.io/mt/96090853/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Posted by Ning Feng 1 year, 3 months ago 
Hi, @Guo, Gua<mailto:gua.guo@intel.com>,
Thanks for the review.
I have already fix the commit message, and create the PR.
UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3868>

Thanks,
Ning

From: Guo, Gua <gua.guo@intel.com>
Sent: Monday, January 9, 2023 9:58 AM
To: devel@edk2.groups.io; Feng, Ning <ning.feng@intel.com>
Cc: Lu, James <james.lu@intel.com>; Guo, Dong <dong.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

@Feng, Ning<mailto:ning.feng@intel.com>

Could you send Edk2 PR ? we can check in it.
https://github.com/tianocore/edk2/pulls

And please also change commit message like below

“””

UefiPayloadPkg: Fix debug print error level hob not save correct

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Fix debug print error level hob not save correct DebugPrintErrorlevel

Should cover the case:
Header.Length == UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Cc: Sean Rhodes <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Cc: James Lu <james.lu@intel.com<mailto:james.lu@intel.com>>
Cc: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
“””

Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ning Feng
Sent: Monday, January 9, 2023 9:44 AM
To: Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob


fix debug print error level hob not save correct debugprinterrorlevel



should cover the case:



Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()



Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b

BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>

---

 .../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c     | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

index 4f6b4ef1fb..10bdbe2bbc 100644

--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL

+++ evelLibHob.c

@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (

       {         if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) {           DebugPrintErrorLevel =  (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);-          if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+          if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {             gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel;           }         }--

2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98169): https://edk2.groups.io/g/devel/message/98169
Mute This Topic: https://groups.io/mt/96090853/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Posted by Guo, Gua 1 year, 3 months ago 
@Lu, James<mailto:james.lu@intel.com>
I may need to get your help to add push label for the PR.

Thanks,
Gua

From: Feng, Ning <ning.feng@intel.com>
Sent: Monday, January 9, 2023 1:04 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Cc: Lu, James <james.lu@intel.com>; Guo, Dong <dong.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

Hi, @Guo, Gua<mailto:gua.guo@intel.com>,
Thanks for the review.
I have already fix the commit message, and create the PR.
UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3868>

Thanks,
Ning

From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Sent: Monday, January 9, 2023 9:58 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Cc: Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Guo, Dong <dong.guo@intel.com<mailto:dong.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

@Feng, Ning<mailto:ning.feng@intel.com>

Could you send Edk2 PR ? we can check in it.
https://github.com/tianocore/edk2/pulls

And please also change commit message like below

“””

UefiPayloadPkg: Fix debug print error level hob not save correct

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Fix debug print error level hob not save correct DebugPrintErrorlevel

Should cover the case:
Header.Length == UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Cc: Sean Rhodes <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Cc: James Lu <james.lu@intel.com<mailto:james.lu@intel.com>>
Cc: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
“””

Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ning Feng
Sent: Monday, January 9, 2023 9:44 AM
To: Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob


fix debug print error level hob not save correct debugprinterrorlevel



should cover the case:



Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()



Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b

BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>

---

 .../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c     | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

index 4f6b4ef1fb..10bdbe2bbc 100644

--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL

+++ evelLibHob.c

@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (

       {         if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) {           DebugPrintErrorLevel =  (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);-          if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+          if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {             gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel;           }         }--

2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98170): https://edk2.groups.io/g/devel/message/98170
Mute This Topic: https://groups.io/mt/96090853/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob
Posted by Ning Feng 1 year, 3 months ago 
Hi, @Lu, James<mailto:james.lu@intel.com>

will you please check if the code change make sense then merge the pr?

I have already fix the commit message, and create the PR.
UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3868>

Thank you!

From: Guo, Gua <gua.guo@intel.com>
Sent: Monday, January 9, 2023 1:07 PM
To: Feng, Ning <ning.feng@intel.com>; devel@edk2.groups.io; Lu, James <james.lu@intel.com>
Cc: Guo, Dong <dong.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

@Lu, James<mailto:james.lu@intel.com>
I may need to get your help to add push label for the PR.

Thanks,
Gua

From: Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Sent: Monday, January 9, 2023 1:04 PM
To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Guo, Dong <dong.guo@intel.com<mailto:dong.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

Hi, @Guo, Gua<mailto:gua.guo@intel.com>,
Thanks for the review.
I have already fix the commit message, and create the PR.
UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/3868>

Thanks,
Ning

From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Sent: Monday, January 9, 2023 9:58 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Cc: Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>; Guo, Dong <dong.guo@intel.com<mailto:dong.guo@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Rhodes, Sean <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

@Feng, Ning<mailto:ning.feng@intel.com>

Could you send Edk2 PR ? we can check in it.
https://github.com/tianocore/edk2/pulls

And please also change commit message like below

“””

UefiPayloadPkg: Fix debug print error level hob not save correct

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Fix debug print error level hob not save correct DebugPrintErrorlevel

Should cover the case:
Header.Length == UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()
Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Cc: Sean Rhodes <sean@starlabs.systems<mailto:sean@starlabs.systems>>
Cc: James Lu <james.lu@intel.com<mailto:james.lu@intel.com>>
Cc: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>
Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
“””

Reviewed-by: Gua Guo <gua.guo@intel.com<mailto:gua.guo@intel.com>>
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ning Feng
Sent: Monday, January 9, 2023 9:44 AM
To: Feng, Ning <ning.feng@intel.com<mailto:ning.feng@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob


fix debug print error level hob not save correct debugprinterrorlevel



should cover the case:



Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD ()



Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b

BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264

Signed-off-by: Ning Feng <ning.feng@intel.com<mailto:ning.feng@intel.com>>

---

 .../DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c     | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

index 4f6b4ef1fb..10bdbe2bbc 100644

--- a/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorLevelLibHob.c

+++ b/UefiPayloadPkg/Library/DebugPrintErrorLevelLibHob/DebugPrintErrorL

+++ evelLibHob.c

@@ -46,7 +46,7 @@ GetDebugPrintErrorLevel (

       {         if (GenericHeader->Revision == UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL_REVISION) {           DebugPrintErrorLevel =  (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL *)GET_GUID_HOB_DATA (GuidHob);-          if (DebugPrintErrorLevel->Header.Length > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {+          if (DebugPrintErrorLevel->Header.Length >= UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD (UEFI_PAYLOAD_DEBUG_PRINT_ERROR_LEVEL, ErrorLevel)) {             gDebugPrintErrorLevel = DebugPrintErrorLevel->ErrorLevel;           }         }--

2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98225): https://edk2.groups.io/g/devel/message/98225
Mute This Topic: https://groups.io/mt/96090853/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.