From nobody Tue May 14 19:32:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88028+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88028+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1648210694; cv=none; d=zohomail.com; s=zohoarc; b=V+sKZk6dRX+Sx85Wvq8mwpGPim2Hjjn9GjeYtWScVOKak5fZbPTfVKyezWB752NAzNMM3/iNRWxN70QjMAel1QbVUANlq6qkjlU6ujX6AwlPigpXHZwJU8mW73Kft1b+oJNmJkKKDKAuayJEAxlw4scKHvkOMYOtp54IDe969bw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648210694; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=YPhcSuOrZRqtgPJhJs7gIvk1xQEmbaWuL20JMBk18yg=; b=OHjEYnMUwiqV8Sk5rAR96GGSVBx06OsciQA+ga2C6IobK5MUmTB9zG/ZVRpr8wSNyV4jUGy8wsbceKsmKXJLjd4O8LEDi29TSWqX1fBrktsYUhXysBg5gevNRrmNrMJZzKfgrxK/SilMagwxh2wnUPcmyVMDo3D4JW2hN3le52A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88028+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1648210694374517.664846924946; Fri, 25 Mar 2022 05:18:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 3BXnYY1788612xwlt1X7nqgx; Fri, 25 Mar 2022 05:18:14 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.4308.1648210691237861050 for ; Fri, 25 Mar 2022 05:18:12 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10296"; a="283491544" X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="283491544" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 05:18:10 -0700 X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="520184563" X-Received: from pbandaru-mobl1.gar.corp.intel.com ([10.252.82.171]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 05:18:08 -0700 From: "Bandaru, Purna Chandra Rao" To: devel@edk2.groups.io Cc: Purna Chandra Rao Bandaru , Wu Hao A , Albecki Mateusz , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH] bRefClkFreq UFS card attribute need to be programmed after fDeviceInit Date: Fri, 25 Mar 2022 17:48:00 +0530 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,purna.chandra.rao.bandaru@intel.com X-Gm-Message-State: nPlqcKsesI94EXA9LctkkVZax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1648210694; bh=v1Z/ceQm0BxAyVutZH8DXR0+uI3AllKT3vQCDKN0Alo=; h=Cc:Date:From:Reply-To:Subject:To; b=kiQIfhXRcEWwyBP044rqGPm7HkShm1E1mQblzNjvGycAtinMyrRWS/LNjj0GYkcIb+H fLyuXhqAJhvDlbEV9irmDhEwiKREJZN0VllMVvh65E4YUWv8jnhJRxhS2eTglQA59fsJU rw/Cuh6T2QizyUGmKhBBy6S/j0M4u0iaddI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1648210696914100003 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3886 bRefClkFreq UFS card attribute need to be read and written after successful fDeviceInit and NOP response so that link will be stable. Cc: Wu Hao A Cc: Albecki Mateusz Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Purna Chandra Rao Bandaru Reviewed-by: Hao A Wu --- .../Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c b/MdeModuleP= kg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c index dc78e09678..ae593ff03a 100644 --- a/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c +++ b/MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c @@ -919,6 +919,23 @@ UfsPassThruDriverBindingStart ( goto Error; } =20 + // + // UFS 2.0 spec Section 13.1.3.3: + // At the end of the UFS Interconnect Layer initialization on both host = and device side, + // the host shall send a NOP OUT UPIU to verify that the device UTP Laye= r is ready. + // + Status =3D UfsExecNopCmds (Private); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Ufs Sending NOP IN command Error, Status =3D %r\= n", Status)); + goto Error; + } + + Status =3D UfsFinishDeviceInitialization (Private); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Device failed to finish initialization, Status = =3D %r\n", Status)); + goto Error; + } + if ((mUfsHcPlatform !=3D NULL) && ((mUfsHcPlatform->RefClkFreq =3D=3D EdkiiUfsCardRefClkFreq19p2Mhz) || (mUfsHcPlatform->RefClkFreq =3D=3D EdkiiUfsCardRefClkFreq26Mhz) || @@ -967,23 +984,6 @@ UfsPassThruDriverBindingStart ( } } =20 - // - // UFS 2.0 spec Section 13.1.3.3: - // At the end of the UFS Interconnect Layer initialization on both host = and device side, - // the host shall send a NOP OUT UPIU to verify that the device UTP Laye= r is ready. - // - Status =3D UfsExecNopCmds (Private); - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Ufs Sending NOP IN command Error, Status =3D %r\= n", Status)); - goto Error; - } - - Status =3D UfsFinishDeviceInitialization (Private); - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Device failed to finish initialization, Status = =3D %r\n", Status)); - goto Error; - } - // // Check if 8 common luns are active and set corresponding bit mask. // --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88028): https://edk2.groups.io/g/devel/message/88028 Mute This Topic: https://groups.io/mt/90020932/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-