From nobody Tue May 14 20:04:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112669+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702955226377808.3349748304572; Mon, 18 Dec 2023 19:07:06 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=QfogD75fQB7guZsTY/6zNTLoKxlYTn64ksm/M/qTAFo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702955226; v=1; b=w6YHuxP+QTpTFetAAlaouPr7ca4UanC/I9MijKdNODztV1rdLxPFDJaAU3w2Ay+98FQ3MdlP y62oIuw/ZFnFtvgWKhJxZvaOPBmqQrunHnyVvAykQBRGHy6TKrttoAGVvVHd3tYvycEt0FUchl2 XoUD0WDy4HHVY1IQ7P2wo5LA= X-Received: by 127.0.0.2 with SMTP id LWHGYY1788612xMx6r4hF6V8; Mon, 18 Dec 2023 19:07:06 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.85]) by mx.groups.io with SMTP id smtpd.web10.4256.1702955225062876169 for ; Mon, 18 Dec 2023 19:07:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E3P+9jmxiJmkAB45zEt+JY74urRnK5hrO018gtOJtW9Fgu1JxxVjZTb+MxaxpaJI5oZpIOHVKry9PRd1ERNA0/cLuxW0TdRtsfTufVaPJQ/ZmQ6XyvvycXgh77J++PVXNCq4FJyqFb6GcpPpfJuNE7Fn5tchAEPwYLR1gVdze/915DIMZEFnW4wPHkc9jyk8haGjCnhIZeAYeVvdTZUtawz1ztc1hgl4qeyVLahR/zOUogkT5a0oKqNf9AGpaUfHzcraQwk4pKVDJAxbA1SlXiVTiCjzaMwONCKcpRbfIxF9OBT0vVV7ZqhgYwpEfo1VQC3DNfZcek1mN4DcJl8T0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kS9MMwBZ4cFDzPwKn5dgKFC3GuyMq1ZN7j9sRnTgvz8=; b=U42VgR9KnDE59+eUDKx4L1GDL8NpNzsKo920tDprhHNBpe/RbSTF/GPlOJC7FmaQLZW8zXIDOzc/MlsLy1cs59cGrjdpRuo8bBOkY4ePzo9ABt5770nt9Vqh8WtzvSmBNbDfMbeIz7YxT3AZU65cBnYR3UdTIRzqyPBY9gegq6jVhaGUcDRztttL7Ss3qZBL2kfLM9/G0kPxpAy1Hdr31ekWkRlUhmqyMTatV1gPvAWtT0GqoxMonyc9IwSrbWzFpEH3VUyeTqr0Dsl+sAcjNu7pamKwrAGSmP1JmJ6qqRN/idncVDWoahsc8dPqqM5/zjIR4OHQyP5IdhFEksv/Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from MW4P220CA0015.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::20) by SA1PR12MB8742.namprd12.prod.outlook.com (2603:10b6:806:373::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec 2023 03:07:02 +0000 X-Received: from MWH0EPF000971E2.namprd02.prod.outlook.com (2603:10b6:303:115:cafe::94) by MW4P220CA0015.outlook.office365.com (2603:10b6:303:115::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 03:07:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112669+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000971E2.mail.protection.outlook.com (10.167.243.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:07:00 +0000 X-Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:06:59 -0600 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:06:59 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 21:06:58 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v4 1/4] DynamicTablesPkg: AML Code generation for word I/O ranges Date: Tue, 19 Dec 2023 08:36:50 +0530 Message-ID: <9cd0d6e1e596b83b623093160c4bb36ec7e3964f.1702954979.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E2:EE_|SA1PR12MB8742:EE_ X-MS-Office365-Filtering-Correlation-Id: 357a69db-a37c-445c-6664-08dc003f9244 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: LRnIR5ITwOYOblsTOe44ZhQWnM2eT4uVD6GSZm5acLGQClwQ4hFIvio+BYXtcPyYNPqKO2o8fH7qkGcpE5hBig7fDCelngWelU5kOBHSQAjFzuexyoW86AMGrQ6rWFPgJ0aZbR+5HiDMLet5vuSc7eA8IcqAs4Jhgc9hZiA+e07OgnSoFjcR5b+BsSMHDWPFAApKThyuAX/bwNCic1HQd9t/NV8VhIqrClu0prKK1jJSntzGAawCwmIsxxPugrjaz+d6vY71Na/G754ltKoUCPtezARz3D1oEfBItZp1R9XDxspmp//o1CwfC+0ea4nRvYv7gQNZ4FcULZw8DOBTbvIj8uGHFfJ/z1o/VkQhyxM/HlyExN8DhppTGBuFImqkd1SDYOYfyaUT/8BHh8SjeiW2FKjA8cv5sKXR9UW3txDC7y2ubItk/P2aEnd1KjKjqEtlBWokTlbVRzFeQ/G1huY25Nbsypkqd0M7ta6fMJXl7+YSTx3Ycle0wBMhJlhGjj14SSdgvlICJgxdCpxVposVEkw/R+975ZBudNtknGFHDEaDzd/xiJ3PbRXNkU0dN++Gsyl3qN/F7/sfnuArMMqXhB316Ob5x/Qa9NvqBZmK3FyVTWgnYvV3QwL+nerCZMvBE436emINbxIyAbN0grVobQNrhQxnRIJoBp0rgHSzwuE9GKzl60Lip6gVUjnJ+eN0QJzmqcDsE61aQ+/MqwFBjofKaTTMwkVz9P4bdRirftG8MaHEW2JwnLozlmApk5fXLcBYRBYyjk5RHSEr9Q== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:07:00.5569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 357a69db-a37c-445c-6664-08dc003f9244 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000971E2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8742 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DBfEHnCtLmA8nKi8QCZ1QrSfx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702955226837100004 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Add helper functions to generate AML resource data for word I/O. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h | 65 ++++++++++++++ .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 88 +++++++++++++++++++ 2 files changed, 153 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 71e8539b30..5e340b94ce 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -2,6 +2,7 @@ AML Lib. =20 Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -724,6 +725,70 @@ AmlCodeGenRdWordBusNumber ( OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL ); =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ); + /** Code generation for the "QWordIO ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 0bc1c1d119..60fe69ba6d 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -2,6 +2,7 @@ AML Resource Data Code Generation. =20 Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -878,6 +879,93 @@ AmlCodeGenRdWordBusNumber ( ); } =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ) +{ + return AmlCodeGenRdWordSpace ( + ACPI_ADDRESS_SPACE_TYPE_IO, + IsResourceConsumer, + IsPosDecode, + IsMinFixed, + IsMaxFixed, + RdIoRangeSpecificFlags ( + IsaRanges, + IsDenseTranslation, + IsTypeStatic + ), + AddressGranularity, + AddressMinimum, + AddressMaximum, + AddressTranslation, + RangeLength, + ResourceSourceIndex, + ResourceSource, + NameOpNode, + NewRdNode + ); +} + /** Code generation for the "QWordSpace ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112669): https://edk2.groups.io/g/devel/message/112669 Mute This Topic: https://groups.io/mt/103256859/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 20:04:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112671+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702955240258447.78232022379575; Mon, 18 Dec 2023 19:07:20 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=yuAtNfpYhwWo7qgZCdB3k53r3hwFwRlNzsCUJSv2uhM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702955228; v=1; b=FvBAPbHtGisUOXZxXnJjtuxRi0hUj46NdpDWrvhhaE81OBvsXigIXNuTOJ+UomjisCFXGAWS STxnuYBHVMf5NYejJ2iP4RCEsXK7RXZyAYNMCYHP25GiwvSkBybdB1UjMhUrnZFJjwq341hjwd4 5xhf5Alx6JeS8k2DhFEwMk0k= X-Received: by 127.0.0.2 with SMTP id Br1WYY1788612x0JNpA8hboV; Mon, 18 Dec 2023 19:07:08 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.63]) by mx.groups.io with SMTP id smtpd.web11.4303.1702955227800922148 for ; Mon, 18 Dec 2023 19:07:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOwg17db2uChA0yIlaM5tuzUoWONt3UgD/OJxwhz6mKrwq+t+s1WoOH+tv3VDPWB81q4BbPrK6M/pEa6uspZPM7jUlMUBBaS6R+C5riz6HUrQ6otFTviLXsW2qJq31LA96j2aqzUR69BYWqArBEoada2mnmqcop9znSRguOmGcxKy3vTcnxBqIkGpYnx61Z7STXqIfPpYdw5dw8MQPKjMSf5TczmFVth5S2R2Jmj0VSiAHwkvlo0bT/sP6gZW/USCXaaYJ53UAH1Ew5QzDEvwmagXhQLUDrkW2zuHamk9cbNbBd9ypY2jvcAkfRrD7RVEbvi6zHXWZiz8MNx4d+1wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7rLn+dce5q8QqQVI4aPAz3UY21Ary1U67HW/Sc4uu8=; b=QKOzldSFnBglW7OzhJ3btGw8aRl/PuplKAAkI4C76xYwcghKCGPdJy4ZZaBsJbLvXvNc6pIRO5H+k+M8ffrKy90oPLuoLuF1sVB51DmOu8iNavrn5oRezLkuPNOBlTHYc4IzN+CSncyibvh8bc7Mo7tjL2mXWhFIqQVvFCfiATztB/0zg1P9vjZKb9LF2acBELMIj+i5h42uvSupdGvGllO0U27JlIa1Ri78i3k9ww2ITxds/NL7URHzjucvD/DSgxY070Vcz+3pqU8gpkjOMZ8XhXr/bBDQ1CsaoO3qFhdr8rGVDxxAJLt6g+hpcLobWmnaZOsd11TYcrRxrE6L4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CY5PR22CA0091.namprd22.prod.outlook.com (2603:10b6:930:65::9) by BY5PR12MB4241.namprd12.prod.outlook.com (2603:10b6:a03:20c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 03:07:02 +0000 X-Received: from CY4PEPF0000EE36.namprd05.prod.outlook.com (2603:10b6:930:65:cafe::3b) by CY5PR22CA0091.outlook.office365.com (2603:10b6:930:65::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 03:07:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112671+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EE36.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:07:02 +0000 X-Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:07:01 -0600 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:07:01 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 21:06:59 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v4 2/4] DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters Date: Tue, 19 Dec 2023 08:36:51 +0530 Message-ID: <8423326acc44469fcc0f5381a87a43dcd2368e50.1702954979.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE36:EE_|BY5PR12MB4241:EE_ X-MS-Office365-Filtering-Correlation-Id: 721ff3ea-5c6b-473c-0f44-08dc003f928d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: TizIQAgLEkNhiQ30uD7tjFFn0oE2FYA5eZukv/0MW3/TZ/ryaIoA4/uOtWDRb8CMRaToT+JMiAD059sjDrazvFOn9V2axjTffwC/q7XYB7bNwCh5jJ3f4wpLhUQez2S4J05032jt7qD2Emll5xjtJrxxndRTK/vEmPxh4gjNOPagqhR/Ha81xoAbLNsI15u9PCAY2jr53xe6PtsVZUsr/YzM4FfwJDA/dGIlYn1cGMoOxQ0bW9NPctTd0mOh8yb7w3fu62hwza9NgtF16l+Dc5vbOHQpQ6wJflNZ/UUme6jLj/TsTff+a/ribeeE13GUObulL48azConeKOS9skkqHOoh/CY+XBi1SY0Yebfd7dc9bRq0stUflS7ycYKq/S9WJnBSzbFf4vaNcJBldU8mnyYvnhEcbOTBIHdg2UgMAOrjJM92gzC4ByQwDtdHKqvwTR8ryEyCdiytwsd2A11SnuJf1YbObFAhGpWjGugcw/9/hMt90AtETugKPwWsvpiAWma5+Ks2qBp8Hl8aa3N1mvf+lTVsIryRvJJtbKdvzxFqnyO+IWKtGwO9751jw7f3SnomjbGfuTtMdByJz/pSYPHLIdOT/NU2yjSPNRu6NA80CxRirQp8bG3dZvYQ86xBLUe3rMsXgkLqVFdXXrCkC/CslPF94nB2k6J9OGIew/8qErjIUbeoltEGND3+9nDRW3MUCuMrV9ESegJNvoOC5wMax+5c69Njo/XM00xK9SWLPwcpEg7UJzo+RofJjCgvdmtV9qg9U+bvStzDmYzxg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:07:02.0331 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 721ff3ea-5c6b-473c-0f44-08dc003f928d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE36.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4241 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MUuuRnCBv41YNeTZPoQwxdI9x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702955240940100001 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the parameters of AmlCodeGenRdWordBusNumber() to UINT16 to generate word bus number. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10 +++++----- .../Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 5e340b94ce..eb8740692f 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -714,11 +714,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 60fe69ba6d..46243f981c 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -848,11 +848,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112671): https://edk2.groups.io/g/devel/message/112671 Mute This Topic: https://groups.io/mt/103256861/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 20:04:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112670+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702955228811991.2148569333667; Mon, 18 Dec 2023 19:07:08 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=FGGS/VkzbBmzugA3Ey/BWL1GkELWebJGSxZRZ+1KEdA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702955227; v=1; b=qbb6uSpKTpvVssGbirKpPKe0w83Qew09hZx2ftlt9eK3UwCE3xUit2wD1Rrpx4yHWamb/qQK Afs2Mne82hEBxICflfYbksIOgcFMyim4kKp3JLAWk6Ef6l+jfHjhzteVreAuQc1/Ma4OrxPDAN+ Bp9uxoK39MXQw/0fQMIZ6BWc= X-Received: by 127.0.0.2 with SMTP id gKAfYY1788612xrkInIxyACD; Mon, 18 Dec 2023 19:07:07 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.47]) by mx.groups.io with SMTP id smtpd.web11.4302.1702955227231936954 for ; Mon, 18 Dec 2023 19:07:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n3ZVTIjNXsc/D2irM2/xCr9guAiEq+svy3yNLbfKBAFWd7j7cJBkwUM7tA9M6+n9UgA95LN+y6TjmEpVoDT3+ud2m0gOGdeO/9pd8e0QEX5EJmkutnc5fOj6DddN3x/xFMw3WOFivsHbBsOke9KH3k4fvTGWgXzMyDFw1RhEvISCtuDKUvHdBBYYbbOaHBd5teY0qvEJN3f3/eDWkHASOUYlmoNyEYIYBGNEFv5PbEuODe0zNkZBuT3KcrxUUO/LnJELSyKjC5Uaf8x/mF1gSFIWleEI82KQaTh4Ye4fsPsKuJmghK9n0vnxsGJ5TQtkSehBbS7rvt9wvzFGVz80kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Kb5JpOj9coXlncB+5Iq6ppdMQxvnqBqbcCRPEJWFD4=; b=JDaPOvhVzDVYdXtPzjoKQVY3yG17KX7CWiFmDc6f/uR+/8KAYJ2lAtPAs4N3PLXgzZIzaeWFOwZhZ6RJgBpKlprVi8wu8bRJOXY1UBqWCIP5RDdBHKhFmkhDxk9FbFEzq7TeghNvffKmuKQzYFKZb8jAlMLDI/lb1vGhFyjfYF/4zj9rBFzRIZ6nu7ovJci0XNJPUXxTo7pY/nHt8hoyCgznt0Yzakw1trRy6RCHjY99lYKHiPWM05VZJGG4s8+U09euWKpWL+ry2QiPjtVMDd23kqE3H0VQbcJaKuP46YQWPt5x8VhpIpw3lEuFgJniOgwvzPhhUauxK2iJlHCVcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CY5PR22CA0099.namprd22.prod.outlook.com (2603:10b6:930:65::24) by PH7PR12MB6980.namprd12.prod.outlook.com (2603:10b6:510:1ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 03:07:04 +0000 X-Received: from CY4PEPF0000EE36.namprd05.prod.outlook.com (2603:10b6:930:65:cafe::43) by CY5PR22CA0099.outlook.office365.com (2603:10b6:930:65::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Tue, 19 Dec 2023 03:07:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112670+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EE36.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:07:04 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:07:02 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 21:07:01 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v4 3/4] DynamicTablesPkg: Corrects function pointer typedef of AML_PARSE_FUNCTION Date: Tue, 19 Dec 2023 08:36:52 +0530 Message-ID: <518c2c038bdaeb18ab1458e020232ddd5573bbdb.1702954979.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE36:EE_|PH7PR12MB6980:EE_ X-MS-Office365-Filtering-Correlation-Id: 516b5e31-639f-4373-74f8-08dc003f93f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 7on3bb5myWE7MMPYyJYkT19aoQy5Ooz3GRhv4EVMHUuRAoqwGz2UKUXbzSg2dJvsuVWoKT3jw+S5yKIpJP+7T7PMyDLYnStG+JkYsOnBUsz67tU7IuXjMPqZP0hdMLJbTgshO+5pA19dGfXop2/brso2CejLsA2vA60daJ2eN2OifhYykB6xELlRfOkiSb6VLEKj2pO7jz+CDGAd6xXwKUepIbHxISIbg8nL1Too/yw/VP6KgT0Fw8Y5zeUlQu87GQIQCi5IwkYdRO5MIyCimSh5bifAuGhw3S/lLNZlH50vsR6CdcpdH2RvZ4Ff7jCeg1Ute9aNfxttIwQVNI9k7bVko+BiBJaJjz5wQMBxLJ4l9QRM7UhSSWTnBh4Ldy4nmnGsWD2opFjdWrFHHZluRufTLQnWa7Bmby0mGbg/bQkaJy6YBpexJWk/gHED+JM4iqfZb/6X3qNAkR2ZjWsqBY703ZO1zGQizeV7ZyRCVCop2clf/vTStP29Ei6aOofIvf2QVhoVwo+UUO6yHQzrvLDtkdK59Qy/sd0ugFyYjhegeqA5bfqR99ToWgIZcZ2xgCDC3Rp88nu5GrZDBqF6Z7Z5xEIC02ertHqWghgDkz1b8gHUMW5YUT3PtmrfEpPVv05JAae355vevsoUU9fe5kJYNDu/E3pH7VOi3sUZ+3Kp5xDvdKiS2gGjD4EIxPYDwSFGFTlECTWLgyqK8Q8FDBmh8xlYuh7tZBniC4fLeP+egmwaj6bDCfYK8fKw+zsOfM4TlPV70wuauD8YAaHFXg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:07:04.4081 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 516b5e31-639f-4373-74f8-08dc003f93f7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE36.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6980 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hsboHobXsQGOgMKKleougKdJx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702955230876100011 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the function pointer typedef AML_PARSE_FUNCTION, otherwise some compiler like VS2019 gives error. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c index 8e584d4930..d3a51a94c7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c @@ -100,8 +100,7 @@ AmlParseStream ( **/ typedef EFI_STATUS -EFIAPI -(*AML_PARSE_FUNCTION) ( +(EFIAPI *AML_PARSE_FUNCTION)( IN CONST AML_NODE_HEADER *Node, IN AML_PARSE_FORMAT ExpectedFormat, IN OUT AML_STREAM *FStream, --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112670): https://edk2.groups.io/g/devel/message/112670 Mute This Topic: https://groups.io/mt/103256860/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 20:04:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112672+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702955231204900.7562079659249; Mon, 18 Dec 2023 19:07:11 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=zSuYP+phmjHedarkx23F19E8ugN0T6q6mbadOtRENw0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702955230; v=1; b=XJXLhM4Q1fKci2WcLy6igrXbKVAq1Lx4PExvSJ1okWhSddk0i7gSSeN2ZfxrHmHyIybTAW2j 3fVIHj1mKTb8zVMquRLjq81mNWfPRQ470z9bJyJktrPWvqVE5nAIczh5KjPOykbqlSMmR6hCmkl 0FOoO3paezory411nIloO6TM= X-Received: by 127.0.0.2 with SMTP id UgcwYY1788612xQFpeUOPzH7; Mon, 18 Dec 2023 19:07:10 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.46]) by mx.groups.io with SMTP id smtpd.web10.4258.1702955229473991910 for ; Mon, 18 Dec 2023 19:07:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5bjsx2qenJdVTSvRU8c4l99L2K4PuzFJ3K9uKoeW6Ce3q3Ng7Jk42IG+ENQHj7RXkkRP7W3znSsvQPp5/GOUO4e8RNyeTrIudBFqPrjHE0C2VOgBozWvLKiWjzKdyWAddcD68JsSQX5LGpJwpNjC9O4t3IG5085nMSK+iGxZs1xYf0nec/M0LjjCFvEKFDaq3CoVd47/4me3A/X9WWTvNTMNY4MzRdx3x4xug7lTIAOovYyQpIZVtrNeRpvvEkfxYB1ePzFX61yMer/8KUziP4p37PYI2/tOC8lmN2NcvDyPiapAt2bOQ3/3cBz2nuRTRc9bAUzTWH4untbn3YHTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=43MBmcQu05UeunpHsvfWxHO5YWHAsbDQr8rfMCWdOoE=; b=K+/VOaMusCmXPK905LlGNpZJslBmu382sKOnQTcEoz204MPs8TLKx0bzhEvZFSBAdQcAlRa9UF75t59zE2AyYSK/f9Zg3FVNABeGnka4dNeAYeCED6H72XP8Kclqt+ui/OEYxm1hmXZwiZzRZRdGMI37hYZAbmLXVMcCpS5FujxgrZwGvJh5U7pOnEAtgV21hHg92nHMtZOOiE29T2rNY4KyR4usT079JLcej+jMJY3gBu9wG3gcOa2QRYSqDoBRC95OEHiHZcJKKpWe5Tz7RAeIDllH9j/7ysjFYUzI9nqC1bQo2hV3AV6uQ93MTEVc71IKk5P6jyLlHh3w7u4dLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CY5PR22CA0103.namprd22.prod.outlook.com (2603:10b6:930:65::25) by SA1PR12MB7319.namprd12.prod.outlook.com (2603:10b6:806:2b5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec 2023 03:07:05 +0000 X-Received: from CY4PEPF0000EE36.namprd05.prod.outlook.com (2603:10b6:930:65:cafe::e4) by CY5PR22CA0103.outlook.office365.com (2603:10b6:930:65::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.39 via Frontend Transport; Tue, 19 Dec 2023 03:07:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112672+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EE36.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Tue, 19 Dec 2023 03:07:05 +0000 X-Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 21:07:05 -0600 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 18 Dec 2023 19:07:04 -0800 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 21:07:03 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [Resend PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method Date: Tue, 19 Dec 2023 08:36:53 +0530 Message-ID: <1c56b1a9e5afe32036d950a33372849b36e10404.1702954979.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE36:EE_|SA1PR12MB7319:EE_ X-MS-Office365-Filtering-Correlation-Id: 3151584d-500d-44df-93c7-08dc003f94b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: GjOAs5+oMBOC5F08SbHVzfW+AHqJqGHl95DIiIQt/E0q0ZzuI9hHdcyy1Sn3Iovn/E7S1S+586CwOYuYpkyYBEICiJ83ul/UZf1ivHETcBFtNVnGmAC7k/gmTpjRXljHsNBaqhtFF2Yar0NpzOzkdIAiV+zglPKx+ngE3rToiHt8OsEFCfUdHSLpa7VKXM2xC+Kj2Bhn1Q13eqGZ6MUVK2ssxiNBYWQfwLbrdYMovgJIj6MSteB0PslqR8c4Rs9wuukWtHIvHWlwbSgKtBdNuW64R3Zj+FVz4flnirFluufvs3Gt6JzBa38iRIAPOvardR38DoxlPVMrhrY00Bykvn5vCmWPNoi8EDxWNJ8292srjKxoDHXYvuAA7OOSkOSBiSr8z908A0Fa2QMMLtYQfh/uMEkTBfx/eMQyPBo+UNSvUDqkdBFSesFw25vkG5RCmoiNGgzp0htlLmbzn00denLgvkifXOQIHvWA7ysT1d7oDZpYT4dnIuDnJYr0KoVo3NMTcaZBZXeMwfLqm0dR5xDrUelbw+0qtK0r71W8YN9Wv9v5DxLSA//TisOdqRYq/7eezGhbM7J7tQHefmyahA4RPQN1QiSV2eNKvo0F9Be6WfyOKo7v9gcgfcYGRrzkohfRKEQbVXkxbJ891A5fDEgWowsfr4clXAfesg05XCdhvM0a8FfRU1q5j3t1zsniRBGzn1im0wrL4/yNgCvXguwmZXy91EoYOgihZ2Lm7Tg3jqSaHYJ87BEp22kNAlonFF+4rlG48u2nCGgnbnagQQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 03:07:05.6738 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3151584d-500d-44df-93c7-08dc003f94b8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE36.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7319 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6nc8ipxOFnQPEIiGIcuwTqRGx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702955232874100015 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Adds API to generate AML code to invoke/call another method. Also provides ability to pass arguments of type integer, string, ArgObj or LocalObj. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h | 112 +++++++++ .../Common/AmlLib/CodeGen/AmlCodeGen.c | 236 +++++++++++++++++- 2 files changed, 347 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index eb8740692f..fb16637f02 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -101,6 +101,56 @@ typedef enum { AmlAddressRangeMax =3D 4 } AML_MEMORY_ATTRIBUTES_MTP; =20 +/** Method parameter types + + Possible values are: + 0 - AmlMethodParamTypeInteger + 1 - AmlMethodParamTypeString + 2 - AmlMethodParamTypeArg + 3 - AmlMethodParamTypeLocal + + @par Reference(s) + - ACPI 6.5, s20.2.5 "Term Objects Encoding" + +**/ +typedef enum { + AmlMethodParamTypeInteger =3D 0, + AmlMethodParamTypeString =3D 1, + AmlMethodParamTypeArg =3D 2, + AmlMethodParamTypeLocal =3D 3 +} AML_METHOD_PARAM_TYPE; + +/** AML Method parameter data + holds the AML method parameter data. +**/ +typedef union { + UINT8 Arg; + UINT8 Local; + UINT64 Integer; + VOID *Buffer; +} AML_METHOD_PARAM_DATA; + +/** structure to hold AML method parameter types + Type - Type of parameter + Data - holds data of parameter + if Type is AmlMethodParamTypeInteger + then Data is of type Integer to hold integer value. + if Type is AmlMethodParamTypeString + then Data contains null terminated string. + If Type is AmlMethodParamTypeArg + then Data contains the Argument number, + 0 to 6 are supported value. + If Type is AmlMethodParamTypeLocal + then Data contains the Local variable number, + 0 to 7 are supported value. + DataSize - for future use +**/ +typedef struct { + AML_METHOD_PARAM_TYPE Type; + AML_METHOD_PARAM_DATA Data; + UINTN DataSize; +} AML_METHOD_PARAM; + /** Parse the definition block. =20 The function parses the whole AML blob. It starts with the ACPI DSDT/SSDT @@ -1693,4 +1743,66 @@ AmlAddNameStringToNamedPackage ( IN AML_OBJECT_NODE_HANDLE NamedNode ); =20 +/** AML code generation to invoke/call another method. + + This method is subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent of the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent of the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + Example 3: + AML_METHOD_PARAM Param[2]; + Param[0].Data.Arg =3D 0; + Param[0].Type =3D AmlMethodParamTypeArg; + Param[1].Data.Integer =3D 0x100; + Param[1].Type =3D AmlMethodParamTypeInteger; + AmlCodeGenMethodRetNameString ("MET2", NULL, 2, TRUE, 0, ParentNode, &= MethodNode); + AmlCodeGenInvokeMethod ("MET3", 2, Param, MethodNode); + + is equivalent of the following ASL code: + Method (MET2, 2, Serialized) + { + MET3 (Arg0, 0x0100) + } + + @param [in] MethodNameString Method name to be called/invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameters contains the parameter data. + @param [in] ParentNode set ParentNode as the parent + of the node created. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ); + #endif // AML_LIB_H_ diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index a6db34fb97..688eefdcef 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -2,6 +2,7 @@ AML Code Generation. =20 Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -921,7 +922,7 @@ AmlCodeGenNameUnicodeString ( Status =3D AmlCreateDataNode ( EAmlNodeDataTypeRaw, (CONST UINT8 *)String, - StrSize (String), + (UINT32)StrSize (String), &DataNode ); if (EFI_ERROR (Status)) { @@ -3849,3 +3850,236 @@ exit_handler: =20 return Status; } + +/** AML code generation to invoke/call another method. + + This method is subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent of the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent of the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + Example 3: + AML_METHOD_PARAM Param[2]; + Param[0].Data.Arg =3D 0; + Param[0].Type =3D AmlMethodParamTypeArg; + Param[1].Data.Integer =3D 0x100; + Param[1].Type =3D AmlMethodParamTypeInteger; + AmlCodeGenMethodRetNameString ("MET2", NULL, 2, TRUE, 0, ParentNode, &= MethodNode); + AmlCodeGenInvokeMethod ("MET3", 2, Param, MethodNode); + + is equivalent of the following ASL code: + Method (MET2, 2, Serialized) + { + MET3 (Arg0, 0x0100) + } + + @param [in] MethodNameString Method name to be called/invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameters contains the parameter data. + @param [in] ParentNode set ParentNode as the parent + of the node created. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ) +{ + EFI_STATUS Status; + UINT8 Index; + CHAR8 *AmlNameString; + UINT32 AmlNameStringSize; + AML_DATA_NODE *DataNode; + AML_OBJECT_NODE *IntNode; + AML_NODE_HANDLE HeadNode; + AML_NODE_HANDLE CurrentNode; + AML_OBJECT_NODE *ObjectNode; + + if ((MethodNameString =3D=3D NULL) || (ParentNode =3D=3D NULL)) { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + if ((NumArgs > 7) || + ((Parameters =3D=3D NULL) && (NumArgs > 0))) + { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + if (Parameters !=3D NULL) { + /// Validate and convert the Parameters to the stream of node + HeadNode =3D NULL; + CurrentNode =3D NULL; + for (Index =3D 0; Index < NumArgs; Index++) { + switch (Parameters[Index].Type) { + case AmlMethodParamTypeInteger: + IntNode =3D NULL; + Status =3D AmlCodeGenInteger (Parameters[Index].Data.Integer, &= IntNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)IntNode; + break; + case AmlMethodParamTypeString: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Buffer =3D=3D NULL) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCodeGenString (Parameters[Index].Data.Buffer, &Obj= ectNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeArg: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Arg > (UINT8)(AML_ARG6 - AML_ARG0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_ARG0 + Parameters[Ind= ex].Data.Arg, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeLocal: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Local > (UINT8)(AML_LOCAL7 - AML_LOCA= L0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_LOCAL0 + Parameters[I= ndex].Data.Local, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)ObjectNode; + break; + default: + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + break; + } + + if (HeadNode =3D=3D NULL) { + HeadNode =3D CurrentNode; + } else { + Status =3D AmlVarListAddTail ( + HeadNode, + CurrentNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + } + } + } + + /// Create called/invoked method name string + Status =3D ConvertAslNameToAmlName (MethodNameString, &AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlGetNameStringSize (AmlNameString, &AmlNameStringSize); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + FreePool (AmlNameString); + goto exit_handler; + } + + DataNode =3D NULL; + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeNameString, + (UINT8 *)AmlNameString, + AmlNameStringSize, + &DataNode + ); + FreePool (AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HANDLE)ParentNode, + (AML_NODE_HANDLE)DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HANDLE)ParentNode, + HeadNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + return Status; + +exit_handler: + if (HeadNode !=3D NULL) { + AmlDeleteTree (HeadNode); + } + + return Status; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112672): https://edk2.groups.io/g/devel/message/112672 Mute This Topic: https://groups.io/mt/103256864/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-