From nobody Wed May 15 23:35:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112648+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702915962250114.04171720640556; Mon, 18 Dec 2023 08:12:42 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8dw8FU5SWPpSHbS9AO24/YH53j822SvRtG+b5S2vNPU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702915961; v=1; b=kcAPxh3yD3Wpf3fOhLzFWtfvC6XRjJdK1xLOSYz20Lu7SmTkc7jwZHDVWaagZjRisctPZiLO cSis2mQz9qH7RZ1hu2VW2NWs/KWAdqKI8Q406DE144UZJzkQ9tIgKFqfDP7T4qI0kpG7tfzP1rx 4vs8xKh2icjGKnX46Ki9XIko= X-Received: by 127.0.0.2 with SMTP id Nt1zYY1788612xCjMt93Czp8; Mon, 18 Dec 2023 08:12:41 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.47611.1702915961105466028 for ; Mon, 18 Dec 2023 08:12:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TQc4Ln/wzru3j+kiIK0FwVpSppGR0ZOv+HYQtf3rvYv4faGYwzHQD8d5TLccCzPnwEpwBFjrE10fFWucSZTA2OW2aB2OeBKSjJ6Yvu3jwOmaaxk69Lz5B8sYSpm87zBhzW0iEMusCoG9328dcZ5pJHXrgU7dAVmIL6baJr52+INdhWICJlUW6qGpBm5EmmLqBwLcEXJensQHjYBykV5Y85f6RGm5Js9hFDIZcySHEaUQqbTCVlxVP6rIb/hYcD5uSt//kEdyj3Ciqmz5CNYodzTIcN7PbJWlq8Put3rhvPArZ8SmQXHlnMUlFWaa5O1dQOODrNgZM3o+qk8tXO4+eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kS9MMwBZ4cFDzPwKn5dgKFC3GuyMq1ZN7j9sRnTgvz8=; b=l5QXW6tNbTrDvdF/cJ5Mb+D16eGufifC7FEX3u8t9IaJAPYKDuT82AxAJF7C1YGuKRedgSe7mAZnL5ZatNdJoxY+v3pJPLa/Jl7XAhh12VN11dhocd9xdu1hxI3gdwkSOWwjxZigedu7RRmmG23sBdEIdHGS7Dzz3TueWeO5cMEAkpBlL+wGWtzDAdVfufeJJMWW4vSgAy8+wa5RA5TtYPEfuATwKYZShBMMJ+iqqVvtUsO/JeNduQ3N5Ss0/UGT9KSwWzwWb2SlaKftfJunPLUiQBTzUjz5W6e2SbWPMukV4QM+Ejp0tIjwL7r1jeTDB9YycJAgNX8h+5eliMVolA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from BYAPR08CA0035.namprd08.prod.outlook.com (2603:10b6:a03:100::48) by CYYPR12MB8938.namprd12.prod.outlook.com (2603:10b6:930:c7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Mon, 18 Dec 2023 16:12:38 +0000 X-Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:a03:100:cafe::9f) by BYAPR08CA0035.outlook.office365.com (2603:10b6:a03:100::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37 via Frontend Transport; Mon, 18 Dec 2023 16:12:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112648+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 16:12:37 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 10:12:37 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 10:12:35 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v4 1/4] DynamicTablesPkg: AML Code generation for word I/O ranges Date: Mon, 18 Dec 2023 21:42:27 +0530 Message-ID: <9cd0d6e1e596b83b623093160c4bb36ec7e3964f.1702915458.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|CYYPR12MB8938:EE_ X-MS-Office365-Filtering-Correlation-Id: 13c346a2-4625-47ff-0ba9-08dbffe42751 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: O4i9FFUzpXGI8Kcx4z+Zmwb0StmIgQvvA0UbLTWj7HQV/WNUNTu3TOB/KDhd8G6GAex3vUYFtVHGtRkT9BRxNrHdCuxrmV2iVcmPecNPvofMxXXTVVBMYhLY1qUdlcf9KEUU/NwZEkYZdKFoyoGgjhU9Pt1goEo7eD6bU8c1T6WblXgnSTZzZ/oYMrtua4nEjxShmK8EtPQ0iNKQUkMN6uIRldrVhTnZ3z1s4LFawtWobWqFX1H9u3IhYRO4D6cF2TvmW1tceGMvMnFYmND5ki7RY5SpNZYt+n4wOqwQtHAbN5UFj/Z6yjY7ZI6o0nKtHLgIo+SVI+Aus7gz6PNWHArGf61fbVpP2Q02k0jmInILhzk3DkZxFMd1hhGv1okvESxldXhsFRDpWT9t40iko/gsNxuvOydy2uas0qOjrbUuIvM03OLGsXSKV6rpi2Etf2i1cK98mxtAfRfMlNKdvuRyyvubc8eSxF7lSXSvl0c/Vo86jjVsM8yy6I2sLT4+wSGIKfx+22BjJIRJjHFfuqx324kdfvPlaSgVxqvMRNd4bShOTUYZ5NdEYrG1Vfd30jYvSdnaQYb2VJoGB2krln3hlUDwpzFc2JIKj4F6CkKGKWBlOWiWG8t8T0qCTu+41swWO/I5IYbM5x6Q8RI6GW2KW9m3aItcGh8VVadoyYvWcZ6nsEI8DCA0Wk8B2U3ap4WjxpvBIzEQPvZsAQ1ZoOmP0wqL8pTn4Tv48UKW4yW9Gelb4g/YenBemN3y5B36DO45/l+e8BgpwpLVdunClA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 16:12:37.8118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13c346a2-4625-47ff-0ba9-08dbffe42751 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8938 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rU9RtimRt5wQRbWFkUQx0wYXx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702915963652100001 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Add helper functions to generate AML resource data for word I/O. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h | 65 ++++++++++++++ .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 88 +++++++++++++++++++ 2 files changed, 153 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 71e8539b30..5e340b94ce 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -2,6 +2,7 @@ AML Lib. =20 Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -724,6 +725,70 @@ AmlCodeGenRdWordBusNumber ( OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL ); =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ); + /** Code generation for the "QWordIO ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 0bc1c1d119..60fe69ba6d 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -2,6 +2,7 @@ AML Resource Data Code Generation. =20 Copyright (c) 2020 - 2021, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -878,6 +879,93 @@ AmlCodeGenRdWordBusNumber ( ); } =20 +/** Code generation for the "WordIO ()" ASL function. + + The Resource Data effectively created is a Word Address Space Resource + Data. Cf ACPI 6.5: + - s6.4.3.5.3 "Word Address Space Descriptor". + + The created resource data node can be: + - appended to the list of resource data elements of the NameOpNode. + In such case NameOpNode must be defined by a the "Name ()" ASL statem= ent + and initially contain a "ResourceTemplate ()". + - returned through the NewRdNode parameter. + + @param [in] IsResourceConsumer ResourceUsage parameter. + @param [in] IsMinFixed Minimum address is fixed. + @param [in] IsMaxFixed Maximum address is fixed. + @param [in] IsPosDecode Decode parameter + @param [in] IsaRanges Possible values are: + 0-Reserved + 1-NonISAOnly + 2-ISAOnly + 3-EntireRange + @param [in] AddressGranularity Address granularity. + @param [in] AddressMinimum Minimum address. + @param [in] AddressMaximum Maximum address. + @param [in] AddressTranslation Address translation. + @param [in] RangeLength Range length. + @param [in] ResourceSourceIndex Resource Source index. + Not supported. Must be 0. + @param [in] ResourceSource Resource Source. + Not supported. Must be NULL. + @param [in] IsDenseTranslation TranslationDensity parameter. + @param [in] IsTypeStatic TranslationType parameter. + @param [in] NameOpNode NameOp object node defining a named ob= ject. + If provided, append the new resource d= ata + node to the list of resource data elem= ents + of this node. + @param [out] NewRdNode If provided and success, + contain the created node. + + @retval EFI_SUCCESS The function completed successfully. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Could not allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlCodeGenRdWordIo ( + IN BOOLEAN IsResourceConsumer, + IN BOOLEAN IsMinFixed, + IN BOOLEAN IsMaxFixed, + IN BOOLEAN IsPosDecode, + IN UINT8 IsaRanges, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, + IN UINT8 ResourceSourceIndex, + IN CONST CHAR8 *ResourceSource, + IN BOOLEAN IsDenseTranslation, + IN BOOLEAN IsTypeStatic, + IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL + OUT AML_DATA_NODE_HANDLE *NewRdNode OPTIONAL + ) +{ + return AmlCodeGenRdWordSpace ( + ACPI_ADDRESS_SPACE_TYPE_IO, + IsResourceConsumer, + IsPosDecode, + IsMinFixed, + IsMaxFixed, + RdIoRangeSpecificFlags ( + IsaRanges, + IsDenseTranslation, + IsTypeStatic + ), + AddressGranularity, + AddressMinimum, + AddressMaximum, + AddressTranslation, + RangeLength, + ResourceSourceIndex, + ResourceSource, + NameOpNode, + NewRdNode + ); +} + /** Code generation for the "QWordSpace ()" ASL function. =20 The Resource Data effectively created is a QWord Address Space Resource --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112648): https://edk2.groups.io/g/devel/message/112648 Mute This Topic: https://groups.io/mt/103245324/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 23:35:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112649+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702915965638208.0173257104193; Mon, 18 Dec 2023 08:12:45 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8XT6EWNxJeTVU7Odbzx8ufCs9Kz22i3+7ZGBV64Qg/w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702915965; v=1; b=wL2ZFFhX7kBwrlKx7E/SM8AnmCcBiLe3D+LrU/M4wpmjz9IByV7Jrn/gOOUOOlhZ5RjN2wX3 2FRywXOHcttu/kTQrT1s8qKFjerXeSINsdjQIZ7gUhL+ylBBlqd6FNn5U+azCfFZsEhkPo8MDiR qKz+g0CeAFXR3kUs9uCtyk68= X-Received: by 127.0.0.2 with SMTP id o2hYYY1788612xatkuHle3Bf; Mon, 18 Dec 2023 08:12:45 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.47613.1702915964591683715 for ; Mon, 18 Dec 2023 08:12:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hEnqlQdhdxd8a6PmZPQa6bPmJIQOZFtFOnCMTdNvslrn3iCrLmBJgDQsgmT7+vSJOrNg9cUoCdxcewkWjqucB0r2UvGLxBKPI9Wx6O0FV8TiSAlQSHXxs1DgneFsVE9VcgU7W9Ieco1bceGHIztXJvsj+Jv9tAnQ8CgmeaZJrga9etKMAvb6gRNxdxwTrg0FMMipAXudQiuFQde9B6yqMWJpYfL61Eo2ce3oeRowbWck3xlENxwD9C+DSZjbiydYKFEU/7Khnfaa9JywLfzxmxJjXIAVlbPNUOcZZZ0FV6zfXsApuRN8zs8BB5++XXHd/C7eejarKnjn9bxB8W3Myg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X7rLn+dce5q8QqQVI4aPAz3UY21Ary1U67HW/Sc4uu8=; b=PI70gdC2XEmYrt5vzJx+NETdcKVA6idOllgm7lS9TSo3N26vgft8OA7Q28nJaJOYqvdOT2uA/S8IuS16XyTP+Vav5LhoNGP/oLt2Jzc4+bJqjWgE7yNUxIE9c33nRObCPxsgSTcBgwnJNClZg0r6D0QQxEAQX0+x6RcDE9KKSj21xC3j/vqr+1nmfGSerXMfJNSw6/LEYRs5GHONsfCC8PHQEPpRv6t917PeHQm8piRpuLijxRaV5S9BdoFCOU498V8bLIIpbwbza1K+nfBunBTH8X5mUaa4WwH46yEwMFJGNN9prI2oqU5Gn3jWoGNmBTsH1c1yDlnXrDN7L3RP0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from BYAPR08CA0025.namprd08.prod.outlook.com (2603:10b6:a03:100::38) by PH0PR12MB5499.namprd12.prod.outlook.com (2603:10b6:510:d5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 16:12:40 +0000 X-Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:a03:100:cafe::90) by BYAPR08CA0025.outlook.office365.com (2603:10b6:a03:100::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38 via Frontend Transport; Mon, 18 Dec 2023 16:12:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112649+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 16:12:39 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 10:12:39 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 10:12:37 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v4 2/4] DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters Date: Mon, 18 Dec 2023 21:42:28 +0530 Message-ID: <8423326acc44469fcc0f5381a87a43dcd2368e50.1702915458.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|PH0PR12MB5499:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c6f4db1-9f61-4241-fde8-08dbffe42886 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 5AZNabzWFJJFD4qK+rDcgcR+ex8tS6pKc55QXmhxponxNtSVqqz0Own2+Bxh1AKGCrAZG9OHcpt0N3H3CDv2SI6V5vgUI9WAQ5IpLEaKgXCl+tRZwGqlPphZq8Qt8Lp9mK+uZmPqPA4A0txD1GXUDYyZ4AIHBPJgUV6I1vXkRl8aaUpupzoadn8OqmICy+AYEEjfCOhxHCpEy/U06r+gdy80RamqXzIlx3ZshTo2hje4mToW5QbuPkZyrIOZAHpxs4/3RNPyrdGIDW8hTPIvmN7U/ZbRZyIi0UrpJocQ/NzXDwkr8xQlBn17IhUVhRJL8/Tg/URMd6+CQP/UelkEdsyPq+zkfBNGh22HJCNbJZB4LPUz9wFqSSLp6wjRsL4KFA0l3yADO0k6i67Mh4P8/+W714x1dWO2mPIYErAZqKPS1pTnZKPFqvwgH0OxO7WAuSfu5dlOFPjdJw86pXCvxRn6k137Ao1zoBI3uajVodB0WIepk8UeUihmGPUT1HYq/515AQif/a9IBYSDJRYNpHisoRMOLn2mpKOHyjeIi8P+16rYpSasoCqHw84Topm+Z5lkCbw20Vmhc4qXH9jkWH1Ida4wjn3H8uuhkpzXqUSf36RNIK93YrGNbC1lpIthR7lOHDTRfZoSSEb1MmSwzfLgrYS6k8iawVYYO296QWxr2/4KukTNzUzhF8SsTbvVpetlwsf5E0/iOBbVa3QauUabjdDCg9WJeynmaUjn9Lb1G6bcG5PjxEjw6S1NeeK8WeoCfxsDsa++p1iX5zRwqA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 16:12:39.8431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6f4db1-9f61-4241-fde8-08dbffe42886 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5499 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NieM55N7Ins9qtK5Du0U5za2x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702915967519100001 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the parameters of AmlCodeGenRdWordBusNumber() to UINT16 to generate word bus number. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10 +++++----- .../Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index 5e340b94ce..eb8740692f 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -714,11 +714,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 60fe69ba6d..46243f981c 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -848,11 +848,11 @@ AmlCodeGenRdWordBusNumber ( IN BOOLEAN IsMinFixed, IN BOOLEAN IsMaxFixed, IN BOOLEAN IsPosDecode, - IN UINT32 AddressGranularity, - IN UINT32 AddressMinimum, - IN UINT32 AddressMaximum, - IN UINT32 AddressTranslation, - IN UINT32 RangeLength, + IN UINT16 AddressGranularity, + IN UINT16 AddressMinimum, + IN UINT16 AddressMaximum, + IN UINT16 AddressTranslation, + IN UINT16 RangeLength, IN UINT8 ResourceSourceIndex, IN CONST CHAR8 *ResourceSource, IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112649): https://edk2.groups.io/g/devel/message/112649 Mute This Topic: https://groups.io/mt/103245325/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 23:35:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112650+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702915966078409.6158423907941; Mon, 18 Dec 2023 08:12:46 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=a/4pBQGNtSNl7lXlZER5wPdZRJTvDHsUwILQNxncrw0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702915965; v=1; b=q/tSr2ny8Dlp24sT74mjtYS563SzBYk1+RnWu+J5i7sTbL3ALGM1CxZn40v1/I7EORgxECIz 0FEfSle6Y+tpF5vNpi7B+iuROMr9cqOVz7T13hE0Izobi518HgRMKkpM3nHwCTnbYbIGNDQx8gR l0ucHMbM9wG6yqEAaFRt4rj8= X-Received: by 127.0.0.2 with SMTP id jUSPYY1788612x5xsU26lJpI; Mon, 18 Dec 2023 08:12:45 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.41]) by mx.groups.io with SMTP id smtpd.web10.47259.1702915965015620780 for ; Mon, 18 Dec 2023 08:12:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VoWeAi9yFsNl+z3XoTAKwL6QEC5GUj4bATpiEuvDt19/9Soyx1/tSkO33yFaWqkQrc9XBFYwUZ3K3gsIaW25I+ILW5AP3HTfPhC2A9r4BT1h3GNKTJHRFR1SSoKUtSzu0vppawF48kL3iW1lrwfJdNLSqZRGm/58ccqbSenhqM4YAqypr4pji+TX23aZJgA9ns0VT05/TouIbnoRAt+TStvtDf3Yhh8EO9iCM7yl8XdBqS8CM6/yEwOp/4aZ4lc4uQqP95NSc94gd9SGTBamq9TiehNE6xNraxvYbF9BNJsF8psp8hu6hII9/WEmZSXxjw83Oo4mcvJl5ILnh7oEzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Kb5JpOj9coXlncB+5Iq6ppdMQxvnqBqbcCRPEJWFD4=; b=amdTWe+bWrjDKsY1hksCtfdMVTzl0H8/5dAAfKWKTRP0VuaNMEzlIy9qVrlTp6urHcyaslKwd0SWJJLKFc/Yhr/I8NHAGbEo/YT/eXKqPmPiSfgrDZQ1gMPnBMNBqR3koRpVeB0ljasD2OrQOS+mwcCVco5Gpj55EmLADFzxxhhF4Qu0SUcf805xjTe5nG2u94TZkx/sHyld/gupVDqrPp91eyAauclf2UQBiFFe7mHG8UP0fQNpujQ+86L77e8RkCXsWEKraX7E0b1ZzLJaSLarnw9UpMUUqBwop5hZKrVZ+zpFT2jM+4DvcxAfMT/69L52wqgYk+zuFyeQmCRwsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SJ0PR05CA0023.namprd05.prod.outlook.com (2603:10b6:a03:33b::28) by SA0PR12MB4511.namprd12.prod.outlook.com (2603:10b6:806:95::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Mon, 18 Dec 2023 16:12:42 +0000 X-Received: from CO1PEPF000042A7.namprd03.prod.outlook.com (2603:10b6:a03:33b:cafe::80) by SJ0PR05CA0023.outlook.office365.com (2603:10b6:a03:33b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.16 via Frontend Transport; Mon, 18 Dec 2023 16:12:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112650+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042A7.mail.protection.outlook.com (10.167.243.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 16:12:41 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 10:12:40 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 10:12:39 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v4 3/4] DynamicTablesPkg: Corrects function pointer typedef of AML_PARSE_FUNCTION Date: Mon, 18 Dec 2023 21:42:29 +0530 Message-ID: <518c2c038bdaeb18ab1458e020232ddd5573bbdb.1702915458.git.AbdulLateef.Attar@amd.com> In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A7:EE_|SA0PR12MB4511:EE_ X-MS-Office365-Filtering-Correlation-Id: 11b167ff-a4f7-494d-6e84-08dbffe429c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: RHEAO07JrNtDx1SPkK927hfDgO5KNNuVP7c0+KbMxyLmjFEbKxktZtDejgO2mPH0ICqrQ/VC3g4kcOAsXqVbIA0dinl99K+YXrkKjQuwQy1K8i9JvoDY45C6/ziGcYeNijQ7IXQuwsy2NEKMHsg+phml116LFHk3FOpbKrOdSzIs7HKgIi2EijxQ9WTtoo9q58pvdL+e5GoL9zEEeSbfww+SL4MSTIhAPP7CwbLmBr4av5hLPCVBSBkluDdJTSBkkP1y8ongJwn1IBYP277OR5eSqSo78ft4gsoTVZ1FUc3R/6d3aahXwnmTAofReI9khFM6BaLy9r0RNPVah/whMtUIpWe/zbVUA4FNqeM95ig44JPibXYPgtCf0a5WUnBW8KZfzovJapdus6hJpeKbVLbxs43VVL+An5Kogd2rpEnOYiRkGSlJjWpIUMQcIADVRn4mCvoVLH70cG+J7aTmLL015B5gfYNHVi0R2vxqyXZ6/9okYDiyrgOBViZy7srmZV9u8msBr5peW18/sDe/bZqk9eaGYMm8L34/W0VLuL0wUd7dGEy+w47dzRco3a/gd/lvMLqbke8MtXyDpp8DqA9mGqHX1xV2HBo5mSF91LCxXk4FIGzlrFCOB9sMAWkQMgW3arSjcaxM20zobtkRyy4NqP6eXzr6sPIs/+cK9TnDcBfIr/G1gqNpzx3HqvUuLWcAtF+vGaeBTkhVECLOPCjSXXPOMuwU1wseUDNoDXMMD7un51jS8+/liUtYphubrG6ecsdPixBLMvoc7yunHA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 16:12:41.8453 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11b167ff-a4f7-494d-6e84-08dbffe429c4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4511 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JyftxguVN2grpRweEY43lct1x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702915967524100002 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Corrects the function pointer typedef AML_PARSE_FUNCTION, otherwise some compiler like VS2019 gives error. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c index 8e584d4930..d3a51a94c7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c @@ -100,8 +100,7 @@ AmlParseStream ( **/ typedef EFI_STATUS -EFIAPI -(*AML_PARSE_FUNCTION) ( +(EFIAPI *AML_PARSE_FUNCTION)( IN CONST AML_NODE_HEADER *Node, IN AML_PARSE_FORMAT ExpectedFormat, IN OUT AML_STREAM *FStream, --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112650): https://edk2.groups.io/g/devel/message/112650 Mute This Topic: https://groups.io/mt/103245326/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 23:35:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112651+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170291596961067.58467729133451; Mon, 18 Dec 2023 08:12:49 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=AC6l6tRqgkbX488QF/BVHYgGvNq64++WGVbXJQGFfUw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1702915969; v=1; b=HxVcZs4ns8D2oW2+e+UZNVZrcXg/8vfDECTcJiVQxO8FaePiNc2G9xRruQ0SnTiSAPObmJwF x2v2Wi/AlL1mgDsM1FalODYy1GlOHs/6ADEidkMHJ0khlN7tGmopZ6tC2iqUVH/C3yxFQj4n9Rm ZOyPaSLxuTgtt+ie2GUspDio= X-Received: by 127.0.0.2 with SMTP id uUklYY1788612xgsoiKLWcdI; Mon, 18 Dec 2023 08:12:49 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.88]) by mx.groups.io with SMTP id smtpd.web11.47617.1702915968606424289 for ; Mon, 18 Dec 2023 08:12:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QFi8a0X4mZ/k5ZjqzIPqs7plCwnMFlRoAvay+pvkE1Tj1d3lSfQQr0ihiXVzNBZNq8YzKgkeXKEi7S9+EpCnqliQp81DhoV//+ru+/9GPT0Iv9c60i4D3p7Kl3AoK2zw+xkWifgAtNg9ZparALGk1jJJTQlAWHKL7EjkdahhczsPLRek/IjkyvS99gJo4JMnv/KkJniqcGh2+Cm1kWT3gaWMJF3CGelh5v9ZsFRoKWsC0fpMV5g8uP66Pg/i88IMBMuRVJNYhjKPgbbxsegmKmF8BT/GNPmIkGjXGMhhd99J9s2OilxhLrzlsScS21THR2NuznIFUC7s2iw1MzGL+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zHc0JrJoKveSYYVl/pGN02yAqoVBksDtW+ji3cxDOZg=; b=bKsKdlLvlAtC3JcaEpiIg/XQWBUCEIuXUL5muA0NCmolUGfZfkeP4z/RxIPgLDyMROE2ow7PDlPYjqp05dmIQsiykZY7Q4Dzpfp42yF6EbUG6loZXaSr7pGliL1yfz8b6b/lP7AdARrCRXWIkOEQmeRi/e3ICcSEZde+OtEyeVxDydrHnrU6yXqNTnf4H9ioTJ7fmXK5JWgPMGUehOitbytARk9e4dBj2BSFXF4+CE7Pno7vKodd0dRn2hBitvzrXt5IDkS5tzLkoc8hbyxZzc3qh5LqJYPls1LjUqA7ayt1fST4EJGOHGxaeO0iWUapw4KhXjWQcd94nm1XBhaVlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SJ0PR05CA0018.namprd05.prod.outlook.com (2603:10b6:a03:33b::23) by DS7PR12MB5791.namprd12.prod.outlook.com (2603:10b6:8:76::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 16:12:43 +0000 X-Received: from CO1PEPF000042A7.namprd03.prod.outlook.com (2603:10b6:a03:33b:cafe::af) by SJ0PR05CA0018.outlook.office365.com (2603:10b6:a03:33b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.17 via Frontend Transport; Mon, 18 Dec 2023 16:12:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112651+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042A7.mail.protection.outlook.com (10.167.243.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7113.14 via Frontend Transport; Mon, 18 Dec 2023 16:12:43 +0000 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 18 Dec 2023 10:12:42 -0600 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.34 via Frontend Transport; Mon, 18 Dec 2023 10:12:41 -0600 From: "Abdul Lateef Attar via groups.io" To: CC: Abdul Lateef Attar , Pierre Gondois , Sami Mujawar Subject: [edk2-devel] [PATCH v4 4/4] DynamicTablesPkg: AML Code generation to invoke a method Date: Mon, 18 Dec 2023 21:42:30 +0530 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A7:EE_|DS7PR12MB5791:EE_ X-MS-Office365-Filtering-Correlation-Id: f1ef4d18-20e4-4922-2c38-08dbffe42a64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: CmyGFiW+KlEY+Poh1qye58HVJKRYlvmDb7PD6x9IbL3Q2JTcH3B+/50iiTBjGrlJGzYLOq5Y/hq2hNVzFtEBw9/+cBCVtlz59RKOgx2LS0nIti05IPlmalotgvG5lYsMHYtKD5BGJlJG4MSr3FN8RFEBd+bGiATKICqlB7UeAYlgz+W2IZ+fL8D5UtkrhxqgO7xGaIv5zOoDCUU6/p4Q605vs73univNTJrh63z4x5cTya/H3D2k8pwD7ffT20rL62F+iOSc9B6rCEMKMXJ/zExm2JsDR9L8Aw7+Mh9cRaHT69HJxyLK2QJcKiaW29uKbGq64WwxZIfmVvjuNelKYYNFBXx9QvzDiv7sy1FfrqcEcsWwjX0McOjN81CxxqXrU0C/llRDkqgUs/i7rlip/xVjgL0b5OIDr66GosNaL5MjH0AFaxo23VDms7jYqam0LjMrbmzN4eMxrYNEPrMD1G27b6C+p/oGVmAFKTAA2CYdVOBcOTmlRCAyOjH2QKSaRKxyXo0ms+FstfHGH+d4U/Gil0s8Cbkpctcfrbg3YsUDE+BhuXqVYmeZ42yYchlMZuPl1ZKRYoFHXV8Gwm4jyVR/5HQsXBQoCLC/FtWV+JRnSVeOwOLIzr9aVwvtKpL+bdHi2c53amR6CFUxhQLaFZGb8k7DdAaJfRN16K+R9vhCaOji1O3FrtWJ7apcm+WnzRzBZBO/7OG5vSs5kKNEPIRm9PeXKoZ6ZBvKc7DB2PIrjfBwzCzrXJORuQVEy3M0fRnerh8TUvaiun8AaIsO1w== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2023 16:12:43.0329 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1ef4d18-20e4-4922-2c38-08dbffe42a64 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5791 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kES25AWqrSr1m0YEmD8bDEcOx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702915971624100011 Content-Type: text/plain; charset="utf-8" From: Abdul Lateef Attar Adds API to generate AML code to invoke/call another method. Also provides ability to pass arguments of type integer, string, ArgObj or LocalObj. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- .../Include/Library/AmlLib/AmlLib.h | 94 ++++++++ .../Common/AmlLib/CodeGen/AmlCodeGen.c | 221 +++++++++++++++++- 2 files changed, 314 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index eb8740692f..5e6a6fde21 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -101,6 +101,53 @@ typedef enum { AmlAddressRangeMax =3D 4 } AML_MEMORY_ATTRIBUTES_MTP; =20 +/** Method parameter types + + Possible values are: + 0 - AmlMethodParamTypeInteger + 1 - AmlMethodParamTypeString + 2 - AmlMethodParamTypeArg + 3 - AmlMethodParamTypeLocal + + @par Reference(s) + - ACPI 6.5, s20.2.5 "Term Objects Encoding" + +**/ +typedef enum { + AmlMethodParamTypeInteger =3D 0, + AmlMethodParamTypeString =3D 1, + AmlMethodParamTypeArg =3D 2, + AmlMethodParamTypeLocal =3D 3 +} AML_METHOD_PARAM_TYPE; + +/** structure to hold AML method parameter types + Type - Type of parameter + Data - holds data of parameter + if Type is AmlMethodParamTypeInteger + then Data is of type Integer to hold integer value. + if Type is AmlMethodParamTypeString + then Data contains null terminated string. + If Type is AmlMethodParamTypeArg + then Data contains the Argument number, + 0 to 6 are supported value. + If Type is AmlMethodParamTypeLocal + then Data contains the Local variable number, + 0 to 7 are supported value. + DataSize - for future use +**/ +typedef struct { + AML_METHOD_PARAM_TYPE Type; + + union { + UINT8 Arg; + UINT8 Local; + UINT64 Integer; + VOID *Buffer; + } Data; + + UINTN DataSize; +} AML_METHOD_PARAM; + /** Parse the definition block. =20 The function parses the whole AML blob. It starts with the ACPI DSDT/SSDT @@ -1693,4 +1740,51 @@ AmlAddNameStringToNamedPackage ( IN AML_OBJECT_NODE_HANDLE NamedNode ); =20 +/** AML code generation to invoke/call another method. + + This method is subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent of the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent of the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + @param [in] MethodNameString Method name to be called/invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameter contains the parameter data. + @param [in] ParentNode set ParentNode as the parent + of the node created. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ); + #endif // AML_LIB_H_ diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index a6db34fb97..3565a4dd58 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -2,6 +2,7 @@ AML Code Generation. =20 Copyright (c) 2020 - 2022, Arm Limited. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -921,7 +922,7 @@ AmlCodeGenNameUnicodeString ( Status =3D AmlCreateDataNode ( EAmlNodeDataTypeRaw, (CONST UINT8 *)String, - StrSize (String), + (UINT32)StrSize (String), &DataNode ); if (EFI_ERROR (Status)) { @@ -3849,3 +3850,221 @@ exit_handler: =20 return Status; } + +/** AML code generation to invoke/call another method. + + This method is subset implementation of MethodInvocation + defined in the ACPI specification 6.5, + section 20.2.5 "Term Objects Encoding". + Added integer, string, ArgObj and LocalObj support. + + Example 1: + AmlCodeGenInvokeMethod ("MET0", 0, NULL, ParentNode); + is equivalent of the following ASL code: + MET0 (); + + Example 2: + AML_METHOD_PARAM Param[4]; + Param[0].Data.Integer =3D 0x100; + Param[0].Type =3D AmlMethodParamTypeInteger; + Param[1].Data.Buffer =3D "TEST"; + Param[1].Type =3D AmlMethodParamTypeString; + Param[2].Data.Arg =3D 0; + Param[2].Type =3D AmlMethodParamTypeArg; + Param[3].Data.Local =3D 2; + Param[3].Type =3D AmlMethodParamTypeLocal; + AmlCodeGenInvokeMethod ("MET0", 4, Param, ParentNode); + + is equivalent of the following ASL code: + MET0 (0x100, "TEST", Arg0, Local2); + + @param [in] MethodNameString Method name to be called/invoked. + @param [in] NumArgs Number of arguments to be passed, + 0 to 7 are permissible values. + @param [in] Parameter contains the parameter data. + @param [in] ParentNode set ParentNode as the parent + of the node created. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. + **/ +EFI_STATUS +EFIAPI +AmlCodeGenInvokeMethod ( + IN CONST CHAR8 *MethodNameString, + IN UINT8 NumArgs, + IN AML_METHOD_PARAM *Parameters OPTIONAL, + IN AML_NODE_HANDLE ParentNode + ) +{ + EFI_STATUS Status; + UINT8 Index; + CHAR8 *AmlNameString; + UINT32 AmlNameStringSize; + AML_DATA_NODE *DataNode; + AML_OBJECT_NODE *IntNode; + AML_NODE_HANDLE HeadNode; + AML_NODE_HANDLE CurrentNode; + AML_OBJECT_NODE *ObjectNode; + + if ((MethodNameString =3D=3D NULL) || (ParentNode =3D=3D NULL)) { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + if ((NumArgs > 7) || + ((Parameters =3D=3D NULL) && (NumArgs > 0))) + { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + if (Parameters !=3D NULL) { + /// Validate and convert the Parameters to the stream of node + HeadNode =3D NULL; + CurrentNode =3D NULL; + for (Index =3D 0; Index < NumArgs; Index++) { + switch (Parameters[Index].Type) { + case AmlMethodParamTypeInteger: + IntNode =3D NULL; + Status =3D AmlCodeGenInteger (Parameters[Index].Data.Integer, &= IntNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)IntNode; + break; + case AmlMethodParamTypeString: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Buffer =3D=3D NULL) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCodeGenString (Parameters[Index].Data.Buffer, &Obj= ectNode); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeArg: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Arg > (UINT8)(AML_ARG6 - AML_ARG0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_ARG0 + Parameters[Ind= ex].Data.Arg, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)ObjectNode; + break; + case AmlMethodParamTypeLocal: + ObjectNode =3D NULL; + if (Parameters[Index].Data.Local > (UINT8)(AML_LOCAL7 - AML_LOCA= L0)) { + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + } + + Status =3D AmlCreateObjectNode ( + AmlGetByteEncodingByOpCode (AML_LOCAL0 + Parameters[I= ndex].Data.Local, 0), + 0, + &ObjectNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + CurrentNode =3D (AML_NODE_HANDLE)ObjectNode; + break; + default: + ASSERT_EFI_ERROR (EFI_INVALID_PARAMETER); + Status =3D EFI_INVALID_PARAMETER; + goto exit_handler; + break; + } + + if (HeadNode =3D=3D NULL) { + HeadNode =3D CurrentNode; + } else { + Status =3D AmlVarListAddTail ( + HeadNode, + CurrentNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + } + } + } + + /// Create called/invoked method name string + Status =3D ConvertAslNameToAmlName (MethodNameString, &AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlGetNameStringSize (AmlNameString, &AmlNameStringSize); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + FreePool (AmlNameString); + goto exit_handler; + } + + DataNode =3D NULL; + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeNameString, + (UINT8 *)AmlNameString, + AmlNameStringSize, + &DataNode + ); + FreePool (AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HANDLE)ParentNode, + (AML_NODE_HANDLE)DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HANDLE)ParentNode, + HeadNode + ); + if (EFI_ERROR (Status)) { + ASSERT_EFI_ERROR (Status); + goto exit_handler; + } + + return Status; + +exit_handler: + if (HeadNode !=3D NULL) { + AmlDeleteTree (HeadNode); + } + + return Status; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112651): https://edk2.groups.io/g/devel/message/112651 Mute This Topic: https://groups.io/mt/103245330/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-